Trace stack dump and log at warning for exceptions

Author: RexWheeler

IISWithBindings/Jobs/Inventory.cs

@@ -4,6 +4,7 @@
 using System.Management.Automation.Runspaces;
 using System.Net;
 using System.Security;
+using Keyfactor.Logging;
 using Keyfactor.Orchestrators.Common.Enums;
 using Keyfactor.Orchestrators.Extensions;
 using Microsoft.Extensions.Logging;
@@ -122,15 +123,17 @@ private JobResult PerformInventory(InventoryJobConfiguration config, SubmitInven
             }
             catch (Exception ex)
             {
-                _logger.LogTrace(ex.Message);
+                _logger.LogTrace(LogHandler.FlattenException(ex));
+
+                string failureMessage = $"Inventory job failed for Site '{config.CertificateStoreDetails.StorePath}' on server '{config.CertificateStoreDetails.ClientMachine}' with error: '{ex.Message}'";
+                _logger.LogWarning(failureMessage);
+
                 return new JobResult
                 {
                     Result = OrchestratorJobStatusJobResult.Failure,
                     JobHistoryId = config.JobHistoryId,
-                    FailureMessage =
-                        $"Site {config.CertificateStoreDetails.StorePath} on server {config.CertificateStoreDetails.ClientMachine}: {ex.Message}"
+                    FailureMessage = failureMessage
                 };
-
             }
         }
 

IISWithBindings/Jobs/Management.cs

@@ -4,6 +4,7 @@
 using System.Management.Automation.Runspaces;
 using System.Net;
 using System.Security.Cryptography.X509Certificates;
+using Keyfactor.Logging;
 using Keyfactor.Orchestrators.Common.Enums;
 using Keyfactor.Orchestrators.Extensions;
 using Microsoft.Extensions.Logging;
@@ -140,13 +141,16 @@ private JobResult PerformRemoval(ManagementJobConfiguration config)
             }
             catch (Exception ex)
             {
-                _logger.LogTrace(ex.Message);
+                _logger.LogTrace(LogHandler.FlattenException(ex));
+
+                string failureMessage = $"Remove job failed for Site '{config.CertificateStoreDetails.StorePath}' on server '{config.CertificateStoreDetails.ClientMachine}' with error: '{ex.Message}'";
+                _logger.LogWarning(failureMessage);
+
                 return new JobResult
                 {
-                    Result = OrchestratorJobStatusJobResult.Failure,
+                    Result = OrchestratorJobStatusJobResult.Failure,
                     JobHistoryId = config.JobHistoryId,
-                    FailureMessage =
-                        $"Site {config.CertificateStoreDetails.StorePath} on server {config.CertificateStoreDetails.ClientMachine}: {ex.Message}"
+                    FailureMessage = failureMessage
                 };
             }
         }
@@ -318,13 +322,16 @@ function InstallPfxToMachineStore([byte[]]$bytes, [string]$password, [string]$st
             }
             catch (Exception ex)
             {
-                _logger.LogTrace(ex.Message);
+                _logger.LogTrace(LogHandler.FlattenException(ex));
+
+                string failureMessage = $"Add job failed for Site '{config.CertificateStoreDetails.StorePath}' on server '{config.CertificateStoreDetails.ClientMachine}' with error: '{ex.Message}'";
+                _logger.LogWarning(failureMessage);
+
                 return new JobResult
                 {
                     Result = OrchestratorJobStatusJobResult.Failure,
                     JobHistoryId = config.JobHistoryId,
-                    FailureMessage =
-                        $"Site {config.CertificateStoreDetails.StorePath} on server {config.CertificateStoreDetails.ClientMachine}: {ex.Message}"
+                    FailureMessage = failureMessage
                 };
             }
         }