Merge pull request #55 from Keyfactor/ab#69253

v1.2.1 approved by Chadd on 91507(https://css-security.lightning.force.com/lightning/r/Case/500Pc00000UfeY5IAJ/view)

Author: fiddlermikey

CHANGELOG.md

@@ -1,3 +1,6 @@
+# 1.2.1
+- fix(management): `K8SNS` management jobs handle `storepath` parsed length is less than expected.
+
 # 1.2.0
 
 ## Features

kubernetes-orchestrator-extension/Jobs/JobBase.cs

@@ -443,13 +443,13 @@ protected K8SJobCertificate InitJobCertificate(dynamic config)
 
     private static bool IsNamespaceStore(string capability)
     {
-        return capability != null && string.IsNullOrEmpty(capability) &&
+        return !string.IsNullOrEmpty(capability) &&
                capability.Contains("K8SNS", StringComparison.OrdinalIgnoreCase);
     }
 
     private static bool IsClusterStore(string capability)
     {
-        return capability != null && string.IsNullOrEmpty(capability) &&
+        return !string.IsNullOrEmpty(capability) &&
                capability.Contains("K8SCLUSTER", StringComparison.OrdinalIgnoreCase);
     }
 

kubernetes-orchestrator-extension/Jobs/Management.cs

@@ -281,10 +281,10 @@ private V1Secret HandlePkcs12Secret(ManagementJobConfiguration config, bool remo
             {
                 if (config.OperationType == CertStoreOperationType.Remove)
                 {
-                    Logger.LogWarning("Secret {Name} not found in Kubernetes so nothing to remove...", KubeSecretName);
+                    Logger.LogWarning("Secret {Name} not found in Kubernetes, nothing to remove...", KubeSecretName);
                     return null;
                 }
-                Logger.LogWarning("Secret {Name} not found in Kubernetes so creating new secret...", KubeSecretName);
+                Logger.LogWarning("Secret {Name} not found in Kubernetes, creating new secret...", KubeSecretName);
             }
         }
 
@@ -548,6 +548,13 @@ private JobResult HandleCreateOrUpdate(string secretType, ManagementJobConfigura
                 jobCertObj.Alias = config.JobCertificate.Alias;
                 // Split alias by / and get second to last element KubeSecretType
                 var splitAlias = jobCertObj.Alias.Split("/");
+                if (splitAlias.Length < 2)
+                {
+                    var invalidAliasErrMsg = "Invalid alias format for K8SNS store type. Alias pattern: `<secret_type>/<secret_name>` where `secret_type` is one of 'opaque' or 'tls' and `secret_name` is the name of the secret.";
+                    Logger.LogError(invalidAliasErrMsg);
+                    Logger.LogInformation("End MANAGEMENT job " + config.JobId + " " + invalidAliasErrMsg + " Failed!");
+                    return FailJob(invalidAliasErrMsg, config.JobHistoryId);
+                }
                 KubeSecretType = splitAlias[^2];
                 KubeSecretName = splitAlias[^1];
                 Logger.LogDebug("Handling managment add job for K8SNS secret type '" + KubeSecretType + "(" + jobCertObj.Alias + ")'...");