fix(certs): Download cert can now download a cert w/o a chain

spbsoluble · spbsoluble · commit 7e5c8aaeb51d · 2023-07-27T11:01:09.000-07:00
diff --git a/v2/api/certificate.go b/v2/api/certificate.go
@@ -168,13 +168,15 @@ func (c *Client) DownloadCertificate(certId int, thumbprint string, serialNumber
 	}
 
 	//todo: review this as it seems to be returning the wrong cert
-	leaf := certs.Certificates[1]
 
+	var leaf *x509.Certificate
 	if len(certs.Certificates) > 1 {
+		//leaf is last cert in chain
+		leaf = certs.Certificates[len(certs.Certificates)-1]
 		return leaf, certs.Certificates, nil
 	}
 
-	return leaf, nil, nil
+	return certs.Certificates[0], nil, nil
 }
 
 // EnrollCSR takes arguments for EnrollCSRFctArgs to enroll a passed Certificate Signing

Original file line number	Diff line number	Diff line change
`@@ -168,13 +168,15 @@ func (c *Client) DownloadCertificate(certId int, thumbprint string, serialNumber`
`168`	`168`	`}`
`169`	`169`
`170`	`170`	`//todo: review this as it seems to be returning the wrong cert`
`171`		`- leaf := certs.Certificates[1]`
`172`	`171`
	`172`	`+ var leaf *x509.Certificate`
`173`	`173`	`if len(certs.Certificates) > 1 {`
	`174`	`+ //leaf is last cert in chain`
	`175`	`+ leaf = certs.Certificates[len(certs.Certificates)-1]`
`174`	`176`	`return leaf, certs.Certificates, nil`
`175`	`177`	`}`
`176`	`178`
`177`		`- return leaf, nil, nil`
	`179`	`+ return certs.Certificates[0], nil, nil`
`178`	`180`	`}`
`179`	`181`
`180`	`182`	`// EnrollCSR takes arguments for EnrollCSRFctArgs to enroll a passed Certificate Signing`