Skip to content

Commit 6163d96

Browse files
author
Lee Fine
committed
1 parent 6ba9e5f commit 6163d96

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

RemoteFile/RemoteFileJobTypeBase.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ internal void SetJobProperties(JobConfiguration config, CertificateStore certifi
7474
ApplicationSettings.CreateCSROnDevice :
7575
Convert.ToBoolean(properties.CreateCSROnDevice.Value);
7676

77-
UseShellCommands = properties.UseShellCommands == null || string.IsNullOrEmpty(properties.UseShellCommands.Value) || !int.TryParse(properties.UseShellCommands.Value, out int _) ?
77+
UseShellCommands = properties.UseShellCommands == null || string.IsNullOrEmpty(properties.UseShellCommands.Value) ?
7878
ApplicationSettings.UseShellCommands :
7979
properties.UseShellCommands;
8080

docsource/content.md

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -184,17 +184,19 @@ determines whether or not Linux shell commands will be used when managing certif
184184
This is useful for environments where shell access is limited or even not allowed. In those scenarios setting this value to 'N'
185185
will substitute SFTP commands for certain specific Linux shell commands. The following restrictions will be in place when
186186
using RemoteFile in this mode:
187-
1. The config.json and custom field options SeparateUploadFilePath, DefaultLinuxPermissionsOnStoreCreation, DefaultOwnerOnStoreCreation,
187+
1. The config.json option SeparateUploadFilePath must NOT be used (option missing from the config.json file or set to empty) for shell
188+
commands to be suppressed for all use cases.
189+
2. The config.json and custom field options SeparateUploadFilePath, DefaultLinuxPermissionsOnStoreCreation, DefaultOwnerOnStoreCreation,
188190
LinuxFilePermissionsOnStoreCreation, and LinuxFileOwnerOnStoreCreation are not supported and will be ignored. As a result, file
189-
permissions and ownership when creating a certificate store or adding a certificate to an existing store will be based
190-
on the user assigned to the Command certificate store and other Linux environmental settings.
191-
2. Discovery jobs are excluded and will still use the `find` shell command
192-
3. A rare issue exists where the user id assigned to a certificate store has an expired password causing the orchestrator to hang
191+
permissions and ownership when creating certificate stores will be based on the user assigned to the Command certificate store and
192+
other Linux environmental settings.
193+
3. Discovery jobs are excluded and will still use the `find` shell command
194+
4. A rare issue exists where the user id assigned to a certificate store has an expired password causing the orchestrator to hang
193195
when attempting an SFTP/SCP connection. A modification was added to RemoteFile to check for this condition. Running RemoteFile
194196
with Use Shell Commands = N will cause this validation check to NOT occur.
195-
4. Both RFORA and RFKDB use proprietary CLI commands in order to manage their respective certificate stores. These commands
197+
5. Both RFORA and RFKDB use proprietary CLI commands in order to manage their respective certificate stores. These commands
196198
will still be executed when Use Shell Commands is set to Y.
197-
5. If executing in local mode ('|LocalMachine' at the end of your client machine name for your certificate store), Use Shell
199+
6. If executing in local mode ('|LocalMachine' at the end of your client machine name for your certificate store), Use Shell
198200
Commands = 'N' will have no effect. Shell commands will continue to be used because there will be no SSH connection
199201
available from which to execute SFTP commands.
200202

0 commit comments

Comments
 (0)