Skip to content

Commit 95e2d3e

Browse files
authored
Merge pull request #118 from KeystoneHQ/bug-fix
fix spaniese issues
2 parents 88db50d + 67b0ab2 commit 95e2d3e

File tree

5 files changed

+11
-4
lines changed

5 files changed

+11
-4
lines changed

app/src/main/java/com/keystone/cold/ui/fragment/main/web3/EthFeeMarketTxFragment.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,9 +84,9 @@ protected void init(View view) {
8484
coinListViewModel.loadETHTx(bundle.getString(KEY_TX_ID)).observe(this, genericETHTxEntity -> {
8585
this.genericETHTxEntity = genericETHTxEntity;
8686
if (this.genericETHTxEntity != null) {
87-
double maxPriorityFee = Double.parseDouble(genericETHTxEntity.getMaxPriorityFeePerGas().replaceAll("[^0-9\\\\.]", ""));
87+
double maxPriorityFee = genericETHTxEntity.getMaxPriorityFeePerGasValue().doubleValue();
8888
boolean isMaxPriorityFeeExceeded = maxPriorityFee > MAX_PRIORITY_PER_GAS;
89-
double maxfee = Double.parseDouble(genericETHTxEntity.getMaxFeePerGas().replaceAll("[^0-9\\\\.]", ""));
89+
double maxfee = genericETHTxEntity.getMaxFeePerGasValue().doubleValue();
9090
boolean isMaxFeeExceeded = maxfee > MAX_FEE_PER_GAS;
9191
isExceeded = isMaxPriorityFeeExceeded || isMaxFeeExceeded;
9292
updateUI();

app/src/main/java/com/keystone/cold/ui/fragment/main/web3/EthLegacyTxFragment.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ protected void init(View view) {
7979
coinListViewModel.loadETHTx(bundle.getString(KEY_TX_ID)).observe(this, genericETHTxEntity -> {
8080
this.genericETHTxEntity = genericETHTxEntity;
8181
if (this.genericETHTxEntity != null) {
82-
if (viewModel.getGasPrice(genericETHTxEntity.getFee(), genericETHTxEntity.getGasLimit()).doubleValue() > MAX_PER_GAS) {
82+
if (viewModel.getGasPrice(genericETHTxEntity.getFeeValue(), genericETHTxEntity.getGasLimitValue()).doubleValue() > MAX_PER_GAS) {
8383
isExceeded = true;
8484
}
8585
updateUI();

app/src/main/java/com/keystone/cold/ui/fragment/main/web3/EthTxConfirmFragment.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -319,7 +319,7 @@ protected void initData(Bundle savedInstanceState) {
319319
viewModel.getObservableEthTx().observe(this, genericETHTxEntity -> {
320320
this.genericETHTxEntity = genericETHTxEntity;
321321
if (this.genericETHTxEntity != null) {
322-
if (viewModel.getGasPrice(genericETHTxEntity.getFee(), genericETHTxEntity.getGasLimit()).doubleValue() > MAX_PER_GAS) {
322+
if (viewModel.getGasPrice(genericETHTxEntity.getFeeValue(), genericETHTxEntity.getGasLimitValue()).doubleValue() > MAX_PER_GAS) {
323323
isExceeded = true;
324324
}
325325
updateUI();

app/src/main/java/com/keystone/cold/viewmodel/tx/GenericETHTxEntity.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,7 @@ public static GenericETHTxEntity transformDbEntity(Web3TxEntity web3TxEntity) {
9999
genericETHTxEntity.setAmountValue(amount);
100100
genericETHTxEntity.setAmount(nf.format(value) + Web3TxViewModel.getSymbol(chainId));
101101
genericETHTxEntity.setFee(nf.format(fee) + Web3TxViewModel.getSymbol(chainId));
102+
genericETHTxEntity.setFeeValue(fee);
102103
JSONObject addition = new JSONObject(web3TxEntity.getAddition());
103104
genericETHTxEntity.setFromTFCard(addition.getBoolean("isFromTFCard"));
104105
break;

app/src/main/java/com/keystone/cold/viewmodel/tx/Web3TxViewModel.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -589,6 +589,12 @@ public BigDecimal getGasPrice(String fee, String limit) {
589589
return value.divide(gasLimit.multiply(BigDecimal.TEN.pow(9)), 8, BigDecimal.ROUND_HALF_UP);
590590
}
591591

592+
public BigDecimal getGasPrice(BigDecimal feeValue, BigDecimal limitValue) {
593+
if (limitValue == null) return new BigDecimal(-1);
594+
BigDecimal value = feeValue.multiply(BigDecimal.TEN.pow(18));
595+
return value.divide(limitValue.multiply(BigDecimal.TEN.pow(9)), 8, BigDecimal.ROUND_HALF_UP);
596+
}
597+
592598
public static String getSymbol(int chainId) {
593599
String symbol = " ";
594600
if (chainIdJSONObject != null) {

0 commit comments

Comments
 (0)