add compression support in GetMsgPackedValueAsString #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hendrikmuhs
force-pushed
the
getmsgpackedvalue-compressed
branch
from
1e47f94 to
f90462c
Compare
gmossessian
reviewed
Apr 11, 2025
Contributor
gmossessian
left a comment
gmossessian
left a comment
There was a problem hiding this comment.
didn't really check the c++ code very carefully but left some questions. feel free to ping on slack :)
|
|
||
| std::string GetValueAsString(uint64_t fsa_value) const override { return ""; } | ||
|
|
||
| std::string GetRawValueAsString(uint64_t fsa_value) const override { return "\x00\xc0"; } |
Contributor
There was a problem hiding this comment.
just curious, what is \x00\xc0? both here and \xc0 below.
Contributor
There was a problem hiding this comment.
hmm, wish there were a msgpack::nil constant or something but oh well. resolving.
gmossessian
reviewed
Apr 17, 2025
gmossessian
approved these changes
Apr 17, 2025
Contributor
Author
|
I made a workaround for the boost issue on mac by downgrading the version. The newest version on homebrew has an incompatible change in boost. This should be fixed in a separate PR. |
hendrikmuhs
added a commit
that referenced
this pull request
Oct 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds support to retrieve a compressed version of the msgpacked value. If values are stored compressed directly uses the stored/compressed value.