Skip to content

Commit 639b46d

Browse files
Avoid putting incorrect extensions on error snapshot files (#92)
## Summary: They were accidentally ending up as `.go` or `.graphql`, but are actually just text. Issue: #90 ## Test plan: make check Author: benjaminjkraft Reviewers: StevenACoffman, dnerdy Required Reviewers: Approved By: StevenACoffman Checks: ✅ Test (1.17), ✅ Test (1.16), ✅ Test (1.15), ✅ Test (1.14), ✅ Lint, ✅ Test (1.17), ✅ Test (1.16), ✅ Test (1.15), ✅ Test (1.14), ✅ Lint Pull Request URL: #92
1 parent 9804d42 commit 639b46d

17 files changed

+2
-3
lines changed

generate/generate_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,8 +250,9 @@ func TestGenerateErrors(t *testing.T) {
250250

251251
baseFilename := strings.TrimSuffix(sourceFilename, filepath.Ext(sourceFilename))
252252
schemaFilename := baseFilename + ".schema.graphql"
253+
testFilename := strings.ReplaceAll(sourceFilename, ".", "/")
253254

254-
t.Run(sourceFilename, func(t *testing.T) {
255+
t.Run(testFilename, func(t *testing.T) {
255256
_, err := Generate(&Config{
256257
Schema: filepath.Join(errorsDir, schemaFilename),
257258
Operations: []string{filepath.Join(errorsDir, sourceFilename)},

0 commit comments

Comments
 (0)