Skip to content

Commit 9ef7636

Browse files
[🔥AUDIT🔥] Add white background for social preview image (#122)
🖍 _This is an audit!_ 🖍 ## Summary: This has the same dark mode problem (if your Twitter client, say, is in dark mode), but we can't be so fancy with CSS, I uess. So I just switched to a white background, which looks fine in context. The actual source of truth for the social preview image is in the github settings page, but I checked in the image for reference. ## Test plan: looks fine in the compose window on Facebook: ![Screenshot 2021-09-30 at 09-34-49 Facebook](https://user-images.githubusercontent.com/111238/135495585-39208971-04d8-4c56-9df1-61970504858b.png) Author: benjaminjkraft Auditors: dnerdy Required Reviewers: Approved By: Checks: ⌛ Test (1.17), ⌛ Test (1.16), ⌛ Test (1.15), ⌛ Test (1.14), ✅ Lint, ⌛ Test (1.17), ✅ Test (1.16), ✅ Test (1.15), ✅ Test (1.14), ✅ Lint Pull Request URL: #122
1 parent c6d087c commit 9ef7636

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

docs/images/README.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
# genqlient logo
22

3-
`genqlient-orig.svg` is the original logo. To create `genqlient.svg`, I:
3+
`genqlient-orig.svg` is the original logo, in editable SVG. To create `genqlient.svg`, I:
44
- converted all text to paths
55
- added media queries to make the paths white if the user is in dark mode (see issue #17)
6+
7+
For the social preview image (in GitHub settings), I ran:
8+
```sh
9+
convert -resize 2560x1280 -density 600 -gravity center \
10+
-extent 2560x1280 docs/images/genqlient.{svg,png}
11+
```

docs/images/genqlient.png

52.5 KB
Loading

0 commit comments

Comments
 (0)