Skip to content

Commit 0fab6b1

Browse files
committed
[benc/remove-json-mode-toggle] Remove JSON mode checkbox from EditorPage
1 parent 1654756 commit 0fab6b1

File tree

2 files changed

+9
-31
lines changed

2 files changed

+9
-31
lines changed

packages/perseus-editor/src/__docs__/editor-page-with-storybook-preview.tsx

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ const onChangeAction = action("onChange");
3131
function EditorPageWithStorybookPreview(props: Props) {
3232
const [previewDevice, setPreviewDevice] =
3333
React.useState<DeviceType>("phone");
34-
const [jsonMode, setJsonMode] = React.useState<boolean | undefined>(false);
34+
const [jsonMode, setJsonMode] = React.useState(false);
3535
const [answerArea, setAnswerArea] = React.useState<
3636
PerseusAnswerArea | undefined | null
3737
>();
@@ -50,6 +50,14 @@ function EditorPageWithStorybookPreview(props: Props) {
5050

5151
return (
5252
<View>
53+
<label>
54+
Developer JSON Mode:{" "}
55+
<input
56+
type="checkbox"
57+
checked={jsonMode}
58+
onChange={(event) => setJsonMode(event.currentTarget.checked)}
59+
/>
60+
</label>
5361
<EditorPage
5462
apiOptions={apiOptions}
5563
previewDevice={previewDevice}
@@ -66,9 +74,6 @@ function EditorPageWithStorybookPreview(props: Props) {
6674
onChange={(props) => {
6775
onChangeAction(props);
6876

69-
if ("jsonMode" in props) {
70-
setJsonMode(props.jsonMode);
71-
}
7277
if ("answerArea" in props) {
7378
setAnswerArea(props.answerArea);
7479
}

packages/perseus-editor/src/editor-page.tsx

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -132,19 +132,6 @@ class EditorPage extends React.Component<Props, State> {
132132
this._isMounted = false;
133133
}
134134

135-
toggleJsonMode: () => void = () => {
136-
this.setState(
137-
{
138-
json: this.serialize({keepDeletedWidgets: true}),
139-
},
140-
() => {
141-
this.props.onChange({
142-
jsonMode: !this.props.jsonMode,
143-
});
144-
},
145-
);
146-
};
147-
148135
updateRenderer() {
149136
// Some widgets (namely the image widget) like to call onChange before
150137
// anything has actually been mounted, which causes problems here. We
@@ -237,20 +224,6 @@ class EditorPage extends React.Component<Props, State> {
237224
return (
238225
<div id="perseus" className={className}>
239226
<div style={{marginBottom: 10}}>
240-
{this.props.developerMode && (
241-
<span>
242-
<label>
243-
{" "}
244-
Developer JSON Mode:{" "}
245-
<input
246-
type="checkbox"
247-
checked={this.props.jsonMode}
248-
onChange={this.toggleJsonMode}
249-
/>
250-
</label>{" "}
251-
</span>
252-
)}
253-
254227
{!this.props.jsonMode && (
255228
<ViewportResizer
256229
deviceType={this.props.previewDevice}

0 commit comments

Comments
 (0)