Skip to content

Commit 299c87e

Browse files
authored
Remove startAnswerless (#3269)
## Summary: - Originally as we were working on having widgets support "answerless" data, we needed a way in Storybook to provide answerless for some widgets and answerful for others - Once all widgets supported answerless, we kept the flag because KAL started answerless but KAC started answerful - Now both KAL and KAC start answerless, so this PR removes the ability to configure whether we start answerless or not - we just always start answerless now Issue: LEMS-3882 ## Test plan: - Nothing should change really - Storybook only, not learner facing Author: handeyeco Reviewers: benchristel, jeremywiebe, SonicScrewdriver Required Reviewers: Approved By: benchristel Checks: ⏭️ 1 check has been skipped, ✅ 9 checks were successful, ⌛ 1 check is pending Pull Request URL: #3269
1 parent 9ccbf9b commit 299c87e

File tree

21 files changed

+5
-55
lines changed

21 files changed

+5
-55
lines changed

.changeset/strong-cups-do.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
---
2+
---

packages/perseus/src/testing/item-renderer-hooks.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ import type {
2121
export const useItemRenderer = (
2222
item: PerseusItem,
2323
apiOptions: APIOptions = {},
24-
startAnswerless: boolean = false,
2524
reviewMode: boolean = false,
2625
showSolutions?: ShowSolutions,
2726
) => {
@@ -30,7 +29,6 @@ export const useItemRenderer = (
3029
itemRendererReducer,
3130
createInitialState(
3231
item,
33-
startAnswerless,
3432
apiOptions.isMobile ?? false,
3533
false, // isRtl defaults to false
3634
reviewMode,

packages/perseus/src/testing/item-renderer-reducer.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ export type ItemRendererState = {
1212
perseusItem: PerseusItem;
1313
originalItem: PerseusItem;
1414
answerless: boolean;
15-
startAnswerless: boolean;
1615
score: PerseusScore | undefined;
1716
userInput: UserInputMap | undefined;
1817
showPopover: boolean;
@@ -38,7 +37,6 @@ export type ItemRendererAction =
3837
// Create initial state function to allow passing props
3938
export const createInitialState = (
4039
item: PerseusItem,
41-
startAnswerless: boolean = false,
4240
isMobile: boolean = false,
4341
isRtl: boolean = false,
4442
reviewMode: boolean = false,
@@ -48,8 +46,7 @@ export const createInitialState = (
4846
isRtl,
4947
perseusItem: item,
5048
originalItem: item,
51-
answerless: startAnswerless,
52-
startAnswerless,
49+
answerless: true,
5350
score: undefined,
5451
userInput: undefined,
5552
showPopover: false,
@@ -97,7 +94,6 @@ export const itemRendererReducer = (
9794
return {
9895
...createInitialState(
9996
state.originalItem,
100-
state.startAnswerless,
10197
state.isMobile,
10298
state.isRtl,
10399
state.reviewMode,

packages/perseus/src/testing/server-item-renderer-with-debug-ui.tsx

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,6 @@ type Props = {
2121
item: PerseusItem;
2222
apiOptions?: APIOptions;
2323
linterContext?: LinterContextProps;
24-
// Temporary measure testing rendering with answerless data;
25-
// only exists until all widgets are renderable with answerless data
26-
startAnswerless?: boolean;
2724
reviewMode?: boolean;
2825
showSolutions?: ShowSolutions;
2926
};
@@ -37,7 +34,6 @@ export const ServerItemRendererWithDebugUI = ({
3734
apiOptions = Object.freeze({}),
3835
linterContext,
3936
reviewMode = false,
40-
startAnswerless = false,
4137
showSolutions,
4238
}: Props): React.ReactElement => {
4339
// Use our custom hook to manage the renderer state
@@ -52,13 +48,7 @@ export const ServerItemRendererWithDebugUI = ({
5248
handleSkip,
5349
handleCheck,
5450
setShowPopover,
55-
} = useItemRenderer(
56-
item,
57-
apiOptions,
58-
startAnswerless,
59-
reviewMode,
60-
showSolutions,
61-
);
51+
} = useItemRenderer(item, apiOptions, reviewMode, showSolutions);
6252

6353
return (
6454
<View>

packages/perseus/src/widgets/categorizer/categorizer.stories.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,5 @@ export const Question1: Story = {
3434
export const AnswerlessCategorizer: Story = {
3535
args: {
3636
item: generateTestPerseusItem({question: question1}),
37-
startAnswerless: true,
3837
},
3938
};

packages/perseus/src/widgets/dropdown/__docs__/dropdown.stories.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,5 @@ export const DropdownWithEmptyPlaceholder: Story = {
6565
export const AnswerlessBasicDropdown: Story = {
6666
args: {
6767
item: generateTestPerseusItem({question: basicDropdown}),
68-
startAnswerless: true,
6968
},
7069
};

packages/perseus/src/widgets/grapher/grapher.stories.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,6 @@ export const ComplexQuestion: Story = {
8181
export const AnswerlessQuestion: Story = {
8282
args: {
8383
item: generateTestPerseusItem({question: absoluteValueQuestion}),
84-
startAnswerless: true,
8584
},
8685
};
8786

packages/perseus/src/widgets/group/group.stories.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,5 @@ export const Answerful: Story = {
3939
export const Answerless: Story = {
4040
args: {
4141
item: getFullGroupTestItem(),
42-
startAnswerless: true,
4342
},
4443
};

packages/perseus/src/widgets/input-number/input-number.stories.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,5 +145,5 @@ export const Answerless = (): React.ReactElement => {
145145
// TODO(LEMS-3083): Remove eslint suppression
146146
// eslint-disable-next-line
147147
item.question.content = `The answer is 42\n${item.question.content}`;
148-
return <ServerItemRendererWithDebugUI item={item} startAnswerless />;
148+
return <ServerItemRendererWithDebugUI item={item} />;
149149
};

packages/perseus/src/widgets/interactive-graphs/__docs__/interactive-graph.stories.tsx

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,6 @@ export const AnswerlessCircle: Story = {
234234
item: generateTestPerseusItem({
235235
question: circleQuestion,
236236
}),
237-
startAnswerless: true,
238237
},
239238
};
240239

@@ -243,7 +242,6 @@ export const AnswerlessLinear: Story = {
243242
item: generateTestPerseusItem({
244243
question: linearQuestion,
245244
}),
246-
startAnswerless: true,
247245
},
248246
};
249247

@@ -252,7 +250,6 @@ export const AnswerlessLinearSystem: Story = {
252250
item: generateTestPerseusItem({
253251
question: linearSystemQuestion,
254252
}),
255-
startAnswerless: true,
256253
},
257254
};
258255

@@ -261,7 +258,6 @@ export const AnswerlessPoint: Story = {
261258
item: generateTestPerseusItem({
262259
question: pointQuestion,
263260
}),
264-
startAnswerless: true,
265261
},
266262
};
267263

@@ -270,7 +266,6 @@ export const AnswerlessPolygon: Story = {
270266
item: generateTestPerseusItem({
271267
question: polygonQuestion,
272268
}),
273-
startAnswerless: true,
274269
},
275270
};
276271

@@ -279,7 +274,6 @@ export const AnswerlessUnlimitedPolygon: Story = {
279274
item: generateTestPerseusItem({
280275
question: unlimitedPolygonQuestion,
281276
}),
282-
startAnswerless: true,
283277
},
284278
};
285279

@@ -288,7 +282,6 @@ export const AnswerlessRay: Story = {
288282
item: generateTestPerseusItem({
289283
question: rayQuestion,
290284
}),
291-
startAnswerless: true,
292285
},
293286
};
294287

@@ -297,7 +290,6 @@ export const AnswerlessSegment: Story = {
297290
item: generateTestPerseusItem({
298291
question: segmentQuestion,
299292
}),
300-
startAnswerless: true,
301293
},
302294
};
303295

@@ -306,6 +298,5 @@ export const AnswerlessSinusoid: Story = {
306298
item: generateTestPerseusItem({
307299
question: sinusoidQuestion,
308300
}),
309-
startAnswerless: true,
310301
},
311302
};

0 commit comments

Comments
 (0)