Commit 2d5364d
authored
[Image] | (UX) | Stop weird shadow on zoomed view in Classroom (#3260)
## Summary:
When you zoom into an image in Khan Academy classroom, it has a weird shadowy outline
around the modal.
This can be easily fixed by using `margin` instead of `padding`.
Issue: https://khanacademy.atlassian.net/browse/LEMS-3897
## Test plan:
Storybook
- Go to `/perseus/?path=/story/widgets-image-widget-demo--image`
- Make sure nothing looks wrong in the Classic theme
- Go to `/perseus/?path=/story/widgets-image-widget-demo--image&globals=theme:thunderblocks`
- Make sure the weird shadow is gone in the Classroom theme
### Before
<img width="707" height="489" alt="Screenshot 2026-02-17 at 3 53 48 PM" src="https://github.com/user-attachments/assets/c390bbe5-4e07-43c4-8049-1a18131979da" />
### After
<img width="693" height="418" alt="Screenshot 2026-02-17 at 3 53 53 PM" src="https://github.com/user-attachments/assets/9e154927-91da-4e27-896a-941eab0e8985" />
Author: nishasy
Reviewers: catandthemachines, mark-fitzgerald, ivyolamit
Required Reviewers:
Approved By: catandthemachines
Checks: ⏭️ 1 check has been skipped, ✅ 10 checks were successful
Pull Request URL: #32601 parent 8fbeee1 commit 2d5364d
File tree
2 files changed
+8
-3
lines changed- .changeset
- packages/perseus/src/components
2 files changed
+8
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
92 | 92 | | |
93 | 93 | | |
94 | 94 | | |
95 | | - | |
| 95 | + | |
96 | 96 | | |
97 | | - | |
| 97 | + | |
98 | 98 | | |
99 | 99 | | |
100 | 100 | | |
101 | | - | |
| 101 | + | |
102 | 102 | | |
103 | 103 | | |
104 | 104 | | |
0 commit comments