[benc/delete-old-todos] Delete more TODOs

Author: benchristel

packages/kas/src/__tests__/comparing.test.ts

@@ -163,8 +163,6 @@ describe("comparing", () => {
         expect("x^2+y^2=r^2").toEqualExpr("r^2=x^2+y^2");
         expect("23^1.5=110.304").toEqualExpr("110.304=23^1.5");
 
-        // TODO(alex): make sure that I have both positive and negative
-        // test cases for all functionality
         expect("6.12*10^-2").toEqualExpr("6.12*10^-2");
         expect("6.12*10^-2").not.toEqualExpr("6.12*10^-6");
 
@@ -198,7 +196,6 @@ describe("comparing", () => {
         expect("sin(500pi x)").not.toEqualExpr("sin(pi x)");
 
         // Check that floating point error isn't killing us
-        // TODO(jack): These don't seem to test much; make better tests
         expect("0").toEqualExpr("sin(7pi)");
         expect("sin(7pi)").toEqualExpr("0");
         expect("0").toEqualExpr("sin(500pi)");
@@ -293,8 +290,6 @@ describe("comparing", () => {
         // to isolate `f(x)` in each expression and then check that the
         // expressions that they're equal to are equal.  In this case that
         // would be `sin^2(x)+cos^2(x)` and `1`.
-        // TODO(TP-11651): Update compare to isolate functions on wide side
-        // before comparing expressions on the other side.
         // expect("f(x) = sin^2(x)+cos^2(x)").toEqualExpr("f(x) = 1");
         expect("f(x) = ln|x|+c").toEqualExpr("f(x)-ln|x|-c = 0");
 

packages/kas/src/__tests__/index.test.ts

@@ -263,7 +263,6 @@ describe("KAS", () => {
             expect("ln(x+y)").toBeSimplified();
 
             // Will only expand logarithms if leads to a simpler expression
-            // TODO(alex): Combine all simplify(assert, ) and isSimplified(assert, ) tests!
             expect("ln(x/y)").toBeSimplified();
             expect("ln(x/y)+ln(y)").not.toBeSimplified();
         });
@@ -329,7 +328,6 @@ describe("KAS", () => {
             expect("y=(x+1)/(x+2)").toBeSimplified();
             expect("y/(x+1)=1/(x+2)").toBeSimplified();
 
-            // TODO(alex): Combine all isSimplified(assert, ) and simplify(assert, ) tests!
             expect("y=(x+1)/(2x+2)").not.toBeSimplified();
             expect("y=1/2").toBeSimplified();
 

packages/kas/src/__tests__/parsing.test.ts

@@ -290,8 +290,6 @@ describe("parsing", () => {
 
         expect("|x|").toParseAs("abs(x)");
         expect("||x||").toParseAs("abs(abs(x))");
-        // TODO(alex): fix the below so it doesn't require an *
-        // may require own lexer/preprocessor
         expect("|x|*|y|").toParseAs("abs(x)*abs(y)");
 
         expect("\\abs(x)").toParseAs("abs(x)");

packages/math-input/src/components/input/__tests__/mathquill.test.ts

@@ -28,8 +28,6 @@ describe("MathQuill", () => {
         document.body.removeChild(span);
     });
 
-    // TODO(charlie): Add tests for "FRAC_EXCLUSIVE" (the mixed-number
-    // fraction key).
     describe("Fraction Bar", () => {
         it("should work with no content", () => {
             mathField.pressKey("FRAC_INCLUSIVE");
@@ -166,14 +164,6 @@ describe("MathQuill", () => {
             mathField.pressKey("EXP");
             expect(mathField.getContent()).toEqual("35x^{ }");
         });
-
-        // TODO(kevinb): makes the expression an exponent when it shouldn't
-        it.skip("should work on a selected expression", () => {
-            mathField.setContent("35x+5");
-            mathField.selectAll();
-            mathField.pressKey("EXP");
-            expect(mathField.getContent()).toEqual("\\left(35x+5\\right)^{ }");
-        });
     });
 
     describe("Square Root", () => {
@@ -207,14 +197,6 @@ describe("MathQuill", () => {
             mathField.pressKey("RADICAL");
             expect(mathField.getContent()).toEqual("35x^{2}\\sqrt[]{}");
         });
-
-        it.skip("should work on a selected expression", () => {
-            mathField.setContent("35x+5");
-            mathField.selectAll();
-            mathField.pressKey("RADICAL");
-            // TODO(kevinb): check cursor location
-            expect(mathField.getContent()).toEqual("\\sqrt[ ]{35x+5}");
-        });
     });
 
     describe("Log", () => {
@@ -279,7 +261,6 @@ describe("MathQuill", () => {
             expect(mathField.getContent()).toEqual("35x^{2}");
         });
 
-        // TODO(kevinb) math isn't selected
         it("should select a fraction when deleting from outside of it", () => {
             const expr = "\\frac{35x+5}{x^{2}}";
             mathField.setContent(expr);
@@ -314,15 +295,6 @@ describe("MathQuill", () => {
             expect(mathField.getContent()).toEqual("\\left(35x+\\right)");
         });
 
-        // TODO(kevinb) fix this behavior so that we delete the exponent too
-        it.skip("should not delete squared exponents", () => {
-            mathField.setContent("35x^{2}");
-            mathField.pressKey("BACKSPACE");
-            expect(mathField.getContent()).toEqual("35x^{2}");
-            mathField.pressKey("BACKSPACE");
-            expect(mathField.getContent()).toEqual("35x^{ }");
-        });
-
         it("should not delete non-square exponents", () => {
             mathField.setContent("35x^5");
             mathField.pressKey("BACKSPACE");
@@ -643,10 +615,4 @@ describe("MathQuill", () => {
             expect(cursor[MQ.R].ctrlSeq).toEqual("5");
         });
     });
-
-    describe.skip("Jump out", () => {
-        // TODO(charlie): Write extensive tests for the 'Jump out' behavior.
-    });
-
-    describe.skip("Equals =, !=, <, <=, >, >=", () => {});
 });

packages/math-input/src/components/keypad/__tests__/keypad.test.tsx

@@ -47,9 +47,7 @@ describe("keypad", () => {
                         cursorContext={
                             context as (typeof CursorContext)[keyof typeof CursorContext]
                         }
-                        onAnalyticsEvent={async () => {
-                            /* TODO: verify correct analytics event sent */
-                        }}
+                        onAnalyticsEvent={async () => {}}
                     />,
                 );
 

packages/perseus-score/src/widgets/numeric-input/score-numeric-input.test.ts

@@ -613,7 +613,7 @@ describe("scoreNumericInput", () => {
     });
 
     it("rejects percentages greater than 100%", () => {
-        // TODO(benchristel): This seems like incorrect behavior. I've added
+        // NOTE(benchristel): This seems like incorrect behavior. I've added
         // this test to characterize the current behavior. Feel free to
         // delete/change it if it's in your way.
         const rubric: PerseusNumericInputRubric = {
@@ -636,7 +636,7 @@ describe("scoreNumericInput", () => {
     });
 
     it("accepts answers with an extra, incorrect percent sign if > 1", () => {
-        // TODO(benchristel): This seems like incorrect behavior. I've added
+        // NOTE(benchristel): This seems like incorrect behavior. I've added
         // this test to characterize the current behavior. Feel free to
         // delete/change it if it's in your way.
         const rubric: PerseusNumericInputRubric = {

packages/perseus/src/__tests__/perseus-markdown.test.ts

@@ -528,10 +528,6 @@ describe("perseus markdown", () => {
         });
     });
 
-    // TODO(michaelpolyak): Ideally we would render the output with React,
-    // to assert the markup. However, the `simple-markdown` library currently
-    // produces rendering warnings such as missing `key` for table rows/columns.
-    // We'll need to fix these warnings in order to not fail the tests.
     describe("output", () => {
         it("should output paragraphs", () => {
             // Arrange

packages/perseus/src/__tests__/renderer.test.tsx

@@ -907,9 +907,6 @@ describe("renderer", () => {
 
             // Act and Assert
             expect(() => {
-                // TODO: Right now KAError is mocked because we're
-                // jest.mock()ing the logging module. Figure out how to
-                // unmock.
                 widget2.props.onFocus("this is not an array");
             }).toThrow("widget props.onFocus focusPath must be an Array");
         });

packages/perseus/src/interactive2/__tests__/movable-point.test.ts

@@ -21,7 +21,6 @@ const createPoint = function (options) {
 
             // Mock visibleShape which is only added when a movable point is used
             // with a shape.
-            // TODO(kevinb): update MovablePoint to require a visibleShape
             visibleShape: {
                 wrapper: {},
             },

packages/perseus/src/styles/shared.ts

@@ -28,7 +28,6 @@ export default StyleSheet.create({
     responsiveLabel: {
         // NOTE(charlie): The values used here should be kept in sync with the
         // caption text sizing in Perseus' styles.css.
-        // TODO(charlie): Migrate the captions over to using this style.
         [mediaQueries.smOrSmaller]: {
             fontSize: 14,
             lineHeight: 1.3,