Skip to content

Commit 6801516

Browse files
[PEICH] Adding check to whether perseus markdown is accessible. (#2692)
## Summary: Updated our `isItemAccessible` function to include a check to confirm our markdown is accessible. Which ammounts to checking if markdown images include alt text. If it does not the item is considered inaccessible. Issue: LEMS-3106 ## Test plan: Run `pnpm test` and all tests should return as passing. Author: catandthemachines Reviewers: catandthemachines, jeremywiebe, tatianasnook Required Reviewers: Approved By: jeremywiebe, tatianasnook Checks: ✅ 8 checks were successful Pull Request URL: #2692
1 parent e539e6d commit 6801516

File tree

7 files changed

+337
-148
lines changed

7 files changed

+337
-148
lines changed

.changeset/twelve-plants-doubt.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@khanacademy/perseus-core": patch
3+
---
4+
5+
Adding extra check to accessible markkdown in isItemAccessible.

packages/perseus-core/.eslintrc.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ module.exports = {
1717
"@khanacademy/perseus-linter",
1818
"@khanacademy/perseus-score",
1919
"@khanacademy/pure-markdown",
20-
"@khanacademy/simple-markdown",
2120
],
2221
},
2322
};

packages/perseus-core/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
"dependencies": {
2828
"@khanacademy/kas": "workspace:*",
2929
"@khanacademy/perseus-utils": "workspace:*",
30+
"@khanacademy/simple-markdown": "workspace:*",
3031
"tiny-invariant": "catalog:prodDeps"
3132
},
3233
"devDependencies": {
@@ -39,4 +40,4 @@
3940
"underscore": "catalog:peerDeps"
4041
},
4142
"keywords": []
42-
}
43+
}

0 commit comments

Comments
 (0)