Skip to content

Commit d0d03f8

Browse files
authored
Delete the blocked-widget and blockquoted-math content linter rules (#2693)
## Summary: From Amanda Leff (content creator): When we can't indent definition widget it causes pedagogical issues for ELA and social studies - For example, means we can't appropriately scaffold text that needs to be indented, can't format some article content in the way that would be most accessible to students, and can't use some authentic texts that we plan to use in the courses b/c those texts use block quotes of other texts. Issue: LEMS-3288 ## Test plan: 1. in the content editor add a definition widget inside a blockquote - `> [☃️ definition 1]` (or reference the test everything [definition article](https://www.khanacademy.org/internal-courses/test-everything/test-everything-1/definition/a/definition-article)) 2. observe that there is no linter warning about the widget being inside quoted text 3. observe that the line does not break before and after the definition widget Author: jeanettehead Reviewers: jeremywiebe Required Reviewers: Approved By: jeremywiebe Checks: ✅ 8 checks were successful Pull Request URL: #2693
1 parent 611da42 commit d0d03f8

File tree

6 files changed

+5
-45
lines changed

6 files changed

+5
-45
lines changed

.changeset/famous-mice-collect.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@khanacademy/perseus-linter": minor
3+
---
4+
5+
Remove blockquote content linter rules

packages/perseus-linter/src/rules/all-rules.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55
// we add a new rule?
66

77
import AbsoluteUrl from "./absolute-url";
8-
import BlockquotedMath from "./blockquoted-math";
9-
import BlockquotedWidget from "./blockquoted-widget";
108
import DoubleSpacingAfterTerminal from "./double-spacing-after-terminal";
119
import ExpressionWidget from "./expression-widget";
1210
import ExtraContentSpacing from "./extra-content-spacing";
@@ -40,8 +38,6 @@ import WidgetInTable from "./widget-in-table";
4038

4139
export default [
4240
AbsoluteUrl,
43-
BlockquotedMath,
44-
BlockquotedWidget,
4541
DoubleSpacingAfterTerminal,
4642
ImageUrlEmpty,
4743
ExpressionWidget,

packages/perseus-linter/src/rules/blockquoted-math.test.ts

Lines changed: 0 additions & 12 deletions
This file was deleted.

packages/perseus-linter/src/rules/blockquoted-math.ts

Lines changed: 0 additions & 9 deletions
This file was deleted.

packages/perseus-linter/src/rules/blockquoted-widget.test.ts

Lines changed: 0 additions & 11 deletions
This file was deleted.

packages/perseus-linter/src/rules/blockquoted-widget.ts

Lines changed: 0 additions & 9 deletions
This file was deleted.

0 commit comments

Comments
 (0)