Skip to content

Commit 0f964f7

Browse files
elisemccrorieelisemccrorie
authored
Adding rules for Spanish (Chile) (#56)
## Summary: Adding translation-assistant rules for translating math notations in es-cl. Stacked on #55 Issue: https://khanacademy.atlassian.net/browse/CP-10089 ## Test plan: npm run lint && npm run build && npm run test Author: elisemccrorie Reviewers: justinmayhew Required Reviewers: Approved By: justinmayhew Checks: ✅ 3 checks were successful Pull Request URL: #56
1 parent 36c6829 commit 0f964f7

File tree

2 files changed

+22
-22
lines changed

2 files changed

+22
-22
lines changed

‎lib/math-translator.js‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,9 @@ require("core-js/modules/web.dom-collections.iterator.js");
3131
var MATH_RULES_LOCALES = {
3232
// Number formats
3333
THOUSAND_SEP_AS_THIN_SPACE: ['az', 'bg', 'cs', 'de', 'fr', 'hu', 'it', 'ka', 'km', 'ky', 'lt', 'lv', 'nb', 'nl', 'pl', 'pt-pt', 'ro', 'sk', 'sq', 'sv', 'uk', 'uz', 'vi'],
34-
THOUSAND_SEP_AS_DOT: ['da', 'el', 'id', 'is', 'mk', 'pt', 'rw', 'sl', 'sr', 'tr'],
34+
THOUSAND_SEP_AS_DOT: ['da', 'el', 'es-cl', 'id', 'is', 'mk', 'pt', 'rw', 'sl', 'sr', 'tr'],
3535
NO_THOUSAND_SEP: ['hy', 'kk', 'ko', 'ru', 'zh-hans'],
36-
DECIMAL_COMMA: ['az', 'bg', 'cs', 'da', 'de', 'el', 'fr', 'hu', 'hy', 'id', 'is', 'it', 'ka', 'kk', 'ky', 'lt', 'lv', 'mk', 'nb', 'nl', 'pl', 'pt', 'pt-pt', 'ro', 'ru', 'rw', 'sk', 'sl', 'sq', 'sr', 'sv', 'tr', 'uz', 'vi'],
36+
DECIMAL_COMMA: ['az', 'bg', 'cs', 'da', 'de', 'el', 'es-cl', 'fr', 'hu', 'hy', 'id', 'is', 'it', 'ka', 'kk', 'ky', 'lt', 'lv', 'mk', 'nb', 'nl', 'pl', 'pt', 'pt-pt', 'ro', 'ru', 'rw', 'sk', 'sl', 'sq', 'sr', 'sv', 'tr', 'uz', 'vi'],
3737
// Pashto team would like to use both perso-arabic numerals for Early Math
3838
// and western digits for more advanced math courses.
3939
// Unfortunately, we don't support this at the moment,
@@ -66,15 +66,15 @@ var MATH_RULES_LOCALES = {
6666
// Binary operators
6767
// TODO(danielhollas):remove 'bg' from TIMES_AS_CDOT
6868
// when \mathbin{.} becomes available for them (currently blocked by linter)
69-
TIMES_AS_CDOT: ['az', 'bg', 'cs', 'da', 'de', 'hu', 'hy', 'lt', 'lv', 'nb', 'pl', 'ro', 'sk', 'sr', 'sv', 'uz'],
69+
TIMES_AS_CDOT: ['az', 'bg', 'cs', 'da', 'de', 'es-cl', 'hu', 'hy', 'lt', 'lv', 'nb', 'pl', 'ro', 'sk', 'sr', 'sv', 'uz'],
7070
CDOT_AS_TIMES: ['fr', 'ps', 'pt-pt'],
7171
DIV_AS_COLON: ['az', 'bg', 'cs', 'da', 'de', 'hu', 'hy', 'it', 'ky', 'lt', 'lv', 'nb', 'nl', 'pl', 'pt-pt', 'ro', 'ru', 'sk', 'sv', 'uk', 'vi'],
7272
// Trig functions
73-
SIN_AS_SEN: ['it', 'pt', 'pt-pt'],
74-
TAN_AS_TG: ['az', 'bg', 'cs', 'hu', 'hy', 'kk', 'km', 'ky', 'lt', 'lv', 'pl', 'pt', 'pt-pt', 'ro', 'ru', 'sk', 'uz'],
75-
COT_AS_COTG: ['cs', 'pt', 'pt-pt', 'sk'],
73+
SIN_AS_SEN: ['es-cl', 'it', 'pt', 'pt-pt'],
74+
TAN_AS_TG: ['az', 'bg', 'cs', 'es-cl', 'hu', 'hy', 'kk', 'km', 'ky', 'lt', 'lv', 'pl', 'pt', 'pt-pt', 'ro', 'ru', 'sk', 'uz'],
75+
COT_AS_COTG: ['cs', 'es-cl', 'pt', 'pt-pt', 'sk'],
7676
COT_AS_CTG: ['az', 'bg', 'hu', 'hy', 'kk', 'km', 'ky', 'lt', 'lv', 'pl', 'ro', 'ru', 'uz'],
77-
CSC_AS_COSEC: ['as', 'az', 'bg', 'bn', 'cs', 'gu', 'hi', 'id', 'ja', 'kn', 'ky', 'lt', 'lv', 'mr', 'my', 'nl', 'pa', 'pl', 'ro', 'ru', 'sk', 'sv', 'ta', 'te', 'tr', 'uk'],
77+
CSC_AS_COSEC: ['as', 'az', 'bg', 'bn', 'cs', 'es-cl', 'gu', 'hi', 'id', 'ja', 'kn', 'ky', 'lt', 'lv', 'mr', 'my', 'nl', 'pa', 'pl', 'ro', 'ru', 'sk', 'sv', 'ta', 'te', 'tr', 'uk'],
7878
CSC_AS_COSSEC: ['pt', 'pt-pt'],
7979
// Rules conditional on the translated template
8080
MAYBE_DIV_AS_COLON: ['id', 'lol'],

‎src/math-translator.js‎

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,13 @@ const MATH_RULES_LOCALES = {
1313
THOUSAND_SEP_AS_THIN_SPACE: ['az', 'bg', 'cs', 'de', 'fr', 'hu', 'it', 'ka',
1414
'km', 'ky', 'lt', 'lv', 'nb', 'nl', 'pl', 'pt-pt', 'ro', 'sk', 'sq',
1515
'sv', 'uk', 'uz', 'vi'],
16-
THOUSAND_SEP_AS_DOT: ['da', 'el', 'id', 'is', 'mk', 'pt', 'rw', 'sl', 'sr',
17-
'tr'],
16+
THOUSAND_SEP_AS_DOT: ['da', 'el', 'es-cl', 'id', 'is', 'mk', 'pt', 'rw',
17+
'sl', 'sr', 'tr'],
1818
NO_THOUSAND_SEP: ['hy', 'kk', 'ko', 'ru', 'zh-hans'],
19-
DECIMAL_COMMA: ['az', 'bg', 'cs', 'da', 'de', 'el', 'fr', 'hu', 'hy', 'id',
20-
'is', 'it', 'ka', 'kk', 'ky', 'lt', 'lv', 'mk', 'nb', 'nl', 'pl', 'pt',
21-
'pt-pt', 'ro', 'ru', 'rw', 'sk', 'sl', 'sq', 'sr', 'sv', 'tr', 'uz',
22-
'vi'],
19+
DECIMAL_COMMA: ['az', 'bg', 'cs', 'da', 'de', 'el', 'es-cl', 'fr', 'hu',
20+
'hy', 'id', 'is', 'it', 'ka', 'kk', 'ky', 'lt', 'lv', 'mk', 'nb',
21+
'nl', 'pl', 'pt', 'pt-pt', 'ro', 'ru', 'rw', 'sk', 'sl', 'sq', 'sr',
22+
'sv', 'tr', 'uz', 'vi'],
2323
// Pashto team would like to use both perso-arabic numerals for Early Math
2424
// and western digits for more advanced math courses.
2525
// Unfortunately, we don't support this at the moment,
@@ -54,21 +54,21 @@ const MATH_RULES_LOCALES = {
5454
// Binary operators
5555
// TODO(danielhollas):remove 'bg' from TIMES_AS_CDOT
5656
// when \mathbin{.} becomes available for them (currently blocked by linter)
57-
TIMES_AS_CDOT: ['az', 'bg', 'cs', 'da', 'de', 'hu', 'hy', 'lt', 'lv', 'nb',
58-
'pl', 'ro', 'sk', 'sr', 'sv', 'uz'],
57+
TIMES_AS_CDOT: ['az', 'bg', 'cs', 'da', 'de', 'es-cl', 'hu', 'hy', 'lt',
58+
'lv', 'nb', 'pl', 'ro', 'sk', 'sr', 'sv', 'uz'],
5959
CDOT_AS_TIMES: [ 'fr', 'ps', 'pt-pt'],
6060
DIV_AS_COLON: ['az', 'bg', 'cs', 'da', 'de', 'hu', 'hy', 'it', 'ky', 'lt',
6161
'lv', 'nb', 'nl', 'pl', 'pt-pt', 'ro', 'ru', 'sk', 'sv', 'uk', 'vi'],
6262
// Trig functions
63-
SIN_AS_SEN: ['it', 'pt', 'pt-pt'],
64-
TAN_AS_TG: ['az', 'bg', 'cs', 'hu', 'hy', 'kk', 'km', 'ky', 'lt', 'lv',
65-
'pl', 'pt', 'pt-pt', 'ro', 'ru', 'sk', 'uz'],
66-
COT_AS_COTG: ['cs', 'pt', 'pt-pt', 'sk'],
63+
SIN_AS_SEN: ['es-cl', 'it', 'pt', 'pt-pt'],
64+
TAN_AS_TG: ['az', 'bg', 'cs', 'es-cl', 'hu', 'hy', 'kk', 'km', 'ky',
65+
'lt', 'lv', 'pl', 'pt', 'pt-pt', 'ro', 'ru', 'sk', 'uz'],
66+
COT_AS_COTG: ['cs', 'es-cl', 'pt', 'pt-pt', 'sk'],
6767
COT_AS_CTG: ['az', 'bg', 'hu', 'hy', 'kk', 'km', 'ky', 'lt', 'lv', 'pl',
6868
'ro', 'ru', 'uz'],
69-
CSC_AS_COSEC: ['as', 'az', 'bg', 'bn', 'cs', 'gu', 'hi', 'id', 'ja', 'kn',
70-
'ky', 'lt', 'lv', 'mr', 'my', 'nl', 'pa', 'pl', 'ro', 'ru', 'sk', 'sv',
71-
'ta', 'te', 'tr', 'uk'],
69+
CSC_AS_COSEC: ['as', 'az', 'bg', 'bn', 'cs', 'es-cl', 'gu', 'hi', 'id',
70+
'ja', 'kn', 'ky', 'lt', 'lv', 'mr', 'my', 'nl', 'pa', 'pl', 'ro',
71+
'ru', 'sk', 'sv', 'ta', 'te', 'tr', 'uk'],
7272
CSC_AS_COSSEC: ['pt', 'pt-pt'],
7373
// Rules conditional on the translated template
7474
MAYBE_DIV_AS_COLON: ['id', 'lol'],

0 commit comments

Comments
 (0)