Fix python artifact upload (#981)

Stop using now broken `upload-artifact-as-is` action.

Author: MarkCallow

.github/workflows/windows.yml

@@ -115,6 +115,7 @@ jobs:
       OPENGL_ES_EMULATOR_WIN: C:\Imagination\Windows_x86_64
       PVR_SDK_HOME: https://github.com/powervr-graphics/Native_SDK/raw/master/lib/Windows_x86_64/
       PYTHON: C:\hostedtoolcache\windows\Python\3.11.4\x64\python.exe
+      PYTHON_DIST_DIR: interface/python_binding/dist
       # This is set to avoid the compiler running out of heap space
       # when vcpkg is compiling glew. Default is logical cores + 1.
       # Runners have 1 thread per core and 2 cores.
@@ -294,18 +295,23 @@ jobs:
         $KTX_VERSION = Get-Content $env:BUILD_DIR/ktx.version
         echo "KTX_VERSION=$KTX_VERSION" >> $env:GITHUB_ENV
 
-    - name: Upload Artifact
+    # For these artifact uploads, need to take care that only one CLangCL
+    # "package" job for each architecture produces artifacts. A second
+    # job would attempt to upload a same-named artifact.
+    - name: Upload artifact Install Package
       if: matrix.options.package == 'YES' && matrix.toolset == 'CLangCL'
       uses: actions/upload-artifact@v4
       with:
         name: KTX-Software-${{env.KTX_VERSION}}-Windows-${{matrix.arch}}
         path: ${{env.BUILD_DIR}}/KTX-Software-*.exe*
+        compression-level: 0 # Installer already compressed.
 
-    - name: Upload pyktx artifacts
-      if: matrix.options.package == 'YES' && matrix.options.py == 'ON'
-      uses: kittaakos/upload-artifact-as-is@v0
+    - name: Upload artifact pyktx
+      if: matrix.options.package == 'YES' && matrix.options.py == 'ON' && matrix.toolset == 'CLangCL'
+      uses: actions/upload-artifact@v4
       with:
-        path: ${{env.BUILD_DIR}}/interface/python_binding/dist/
+        name: pyktx-${{env.KTX_VERSION}}-Windows-${{matrix.arch}}
+        path: ${{env.BUILD_DIR}}/${{env.PYTHON_DIST_DIR}}
 
     - name: Upload to Release
       uses: softprops/action-gh-release@v1
@@ -315,7 +321,7 @@ jobs:
         prerelease: true
         files: |
             ${{env.BUILD_DIR}}/KTX-Software-*.exe*
-            ${{env.BUILD_DIR}}/interface/python_binding/dist/pyktx-*
+            ${{env.BUILD_DIR}}/${{env.PYTHON_DIST_DIR}}/pyktx-*
       env:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}