Skip to content

Commit eefa63b

Browse files
committed
Remove prohibition on HLG_UNNORMALIZED.
1 parent fc24e7b commit eefa63b

File tree

3 files changed

+4
-11
lines changed

3 files changed

+4
-11
lines changed

lib/texture2.c

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -776,7 +776,7 @@ ktxTexture2_constructFromStreamAndHeader(ktxTexture2* This, ktxStream* pStream,
776776
result = KTX_FILE_DATA_ERROR;
777777
goto cleanup;
778778
}
779-
if (pBDFD->transfer >= KHR_DF_TRANSFER_HLG_UNNORMALIZED_OETF) {
779+
if (pBDFD->transfer > KHR_DF_TRANSFER_HLG_UNNORMALIZED_OETF) {
780780
// Invalid transfer function
781781
result = KTX_FILE_DATA_ERROR;
782782
goto cleanup;
@@ -2046,9 +2046,6 @@ ktxTexture2_NeedsTranscoding(ktxTexture2* This)
20462046
ktx_error_code_e
20472047
ktxTexture2_SetTransferFunction(ktxTexture2* This, khr_df_transfer_e tf)
20482048
{
2049-
if (tf == KHR_DF_TRANSFER_HLG_UNNORMALIZED_OETF)
2050-
return KTX_INVALID_VALUE;
2051-
20522049
if (isSrgbFormat(This->vkFormat) && tf != KHR_DF_TRANSFER_SRGB)
20532050
return KTX_INVALID_OPERATION;
20542051

tools/ktx/command_create.cpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -259,8 +259,8 @@ struct OptionsCreate {
259259
{ "BT1886_EOTF", KHR_DF_TRANSFER_BT1886_EOTF }, // BT1886
260260
{ "HLG_OETF", KHR_DF_TRANSFER_HLG_OETF },
261261
{ "HLG_EOTF", KHR_DF_TRANSFER_HLG_EOTF },
262-
{ "PQ_OETF", KHR_DF_TRANSFER_HLG_OETF },
263-
{ "PQ_EOTF", KHR_DF_TRANSFER_HLG_EOTF },
262+
{ "PQ_OETF", KHR_DF_TRANSFER_PQ_OETF },
263+
{ "PQ_EOTF", KHR_DF_TRANSFER_PQ_EOTF },
264264
{ "DCIP3", KHR_DF_TRANSFER_DCIP3 },
265265
{ "DCIP3_EOTF", KHR_DF_TRANSFER_DCIP3_EOTF }, // DCIP3
266266
{ "PAL_OETF", KHR_DF_TRANSFER_PAL_OETF },
@@ -274,8 +274,7 @@ struct OptionsCreate {
274274
{ "ACESCCT_OETF", KHR_DF_TRANSFER_ACESCCT_OETF }, // ACESCCT
275275
{ "ADOBERGB", KHR_DF_TRANSFER_ADOBERGB },
276276
{ "ADOBERGB_EOTF", KHR_DF_TRANSFER_ADOBERGB_EOTF }, // ADOBERGB
277-
// HLG_UNNORMALIZED_OETF is deliberately excluded as it is no
278-
// longer part of the HLG standard.
277+
{ "HLG_UNNORMALIZED_OETF", KHR_DF_TRANSFER_HLG_UNNORMALIZED_OETF },
279278
};
280279

281280
std::optional<khr_df_transfer_e> result = {};

tools/ktx/validate.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -886,9 +886,6 @@ void ValidationContext::validateDFDBasic(uint32_t blockIndex, const uint32_t* df
886886
error(DFD::BasicVersionNotSupported, blockIndex, toString(khr_df_versionnumber_e(block.versionNumber)));
887887

888888
// Validate transferFunction
889-
if (block.transfer == KHR_DF_TRANSFER_HLG_UNNORMALIZED_OETF)
890-
error(DFD::BasicProhibitedTransferFunction, blockIndex, toString(khr_df_transfer_e(block.transfer)));
891-
892889
if (block.transfer > KHR_DF_TRANSFER_HLG_UNNORMALIZED_OETF)
893890
error(DFD::BasicInvalidTransferFunction, blockIndex, block.transfer);
894891

0 commit comments

Comments
 (0)