Include Win32 loader symbols in release artifact (#225)

brycehutchings · web-flow · commit 06b5b7f84021 · 2020-11-19T17:17:35.000-08:00
* Copy openxr_loader PDB to install folder when building as a DLL for automatic inclusion in the release artifacts.
diff --git a/.azure-pipelines/build_jobs.yml b/.azure-pipelines/build_jobs.yml
@@ -98,6 +98,9 @@ jobs:
       - download: current
         patterns: "**/*.dll"
         displayName: Download dynamic libraries
+      - download: current
+        patterns: "**/*.pdb"
+        displayName: Download dynamic library symbols
       - download: current
         patterns: "**/*.lib"
         displayName: Download link import libraries
diff --git a/changes/sdk/pr.225.gh.OpenXR-SDK-Source.md b/changes/sdk/pr.225.gh.OpenXR-SDK-Source.md
@@ -0,0 +1 @@
+Include PDB symbols to go along with the openxr_loader.dll Windows artifacts.
diff --git a/src/loader/CMakeLists.txt b/src/loader/CMakeLists.txt
@@ -283,6 +283,9 @@ install(
     DESTINATION ${TARGET_DESTINATION}
 )
 
+if(WIN32 AND DYNAMIC_LOADER)
+    install(FILES $<TARGET_PDB_FILE:openxr_loader> DESTINATION ${CMAKE_INSTALL_BINDIR} OPTIONAL)
+endif()
 
 # Make the "meta" cmake config/version file to redirect to the right arch/build
 if(WIN32 AND INSTALL_TO_ARCHITECTURE_PREFIXES)

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Include PDB symbols to go along with the openxr_loader.dll Windows artifacts.`
Original file line number	Diff line number	Diff line change
`@@ -283,6 +283,9 @@ install(`
`283`	`283`	`DESTINATION ${TARGET_DESTINATION}`
`284`	`284`	`)`
`285`	`285`
	`286`	`+if(WIN32 AND DYNAMIC_LOADER)`
	`287`	`+ install(FILES $<TARGET_PDB_FILE:openxr_loader> DESTINATION ${CMAKE_INSTALL_BINDIR} OPTIONAL)`
	`288`	`+endif()`
`286`	`289`
`287`	`290`	`# Make the "meta" cmake config/version file to redirect to the right arch/build`
`288`	`291`	`if(WIN32 AND INSTALL_TO_ARCHITECTURE_PREFIXES)`