Skip to content

Commit 3ffb204

Browse files
committed
OpenXR 1.0.5 release (6-December-2019)
Patch release for the 1.0 series. This release primarily contains extension reservations and small specification clarifications/fixes. ### GitHub Pull Requests These had been integrated into the public repo incrementally. - Loader tests - #147 - Small bugfix and output extension ### Internal issues - Registry - Reserve Microsoft extension numbers (Internal MR 1613)
1 parent 1cbb91b commit 3ffb204

File tree

8 files changed

+117
-48
lines changed

8 files changed

+117
-48
lines changed

.appveyor.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
version: 1.0.1.{build}
1+
version: 1.0.5.{build}
22
image: Visual Studio 2017
33

44

CHANGELOG.SDK.md

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,25 @@ along with any public pull requests that have been accepted.
1313
In this repository in particular, since it is primarily software,
1414
pull requests may be integrated as they are accepted even between periodic updates.
1515

16+
## OpenXR 1.0.5 release (6-December-2019)
17+
18+
Patch release for the 1.0 series.
19+
20+
This release primarily contains extension reservations and small specification
21+
clarifications/fixes.
22+
23+
### GitHub Pull Requests
24+
25+
These had been integrated into the public repo incrementally.
26+
27+
- Loader tests
28+
- #147 - Small bugfix and output extension
29+
30+
### Internal issues
31+
32+
- Registry
33+
- Reserve Microsoft extension numbers (Internal MR 1613)
34+
1635
## OpenXR 1.0.4 release (21-November-2019)
1736

1837
Patch release for the 1.0 series.

checkCodespell

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ IGNORE_WORDS="lod,LOD"
4444
# Add to this to exclude individual files or directories (comma-delimited)
4545
# - Skipping external code.
4646
# - Skipping binary files.
47-
SKIP="${ROOT}/src/external,${ROOT}/src/conformance/framework/catch2,*.pyc,*.png,*.jpg,*.svg"
47+
SKIP="${ROOT}/src/external,${ROOT}/src/conformance/framework/catch2,*.pyc,*.png,*.jpg,*.svg,*.otf"
4848

4949
# Args that get passed if no args are provided to this script.
5050
# -q4 to silence "UINT ==> UNIT | disabled due to being a data type"

openxr-codespell.exclude

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,3 +4,4 @@
44
| homogeneous | homogenous | More common
55
if (timebase_info.numer == 0) mach_timebase_info(&timebase_info);
66
return ((mach_absolute_time() * timebase_info.numer) / timebase_info.denom);
7+
'\b[aA]nd [aA]nd\b'

specification/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ ifneq (,$(strip $(VERY_STRICT)))
4242
ASCIIDOC := $(ASCIIDOC) --failure-level WARN
4343
endif
4444

45-
SPECREVISION = 1.0.4
45+
SPECREVISION = 1.0.5
4646
REVISION_COMPONENTS = $(subst ., ,$(SPECREVISION))
4747
MAJORMINORVER = $(word 1,$(REVISION_COMPONENTS)).$(word 2,$(REVISION_COMPONENTS))
4848

specification/registry/xr.xml

Lines changed: 50 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ maintained in the master branch of the Khronos OpenXR GitHub project.
113113
updates them automatically by processing a line at a time.
114114
-->
115115
<type category="define">// OpenXR current version number.
116-
#define <name>XR_CURRENT_API_VERSION</name> <type>XR_MAKE_VERSION</type>(1, 0, 4)</type>
116+
#define <name>XR_CURRENT_API_VERSION</name> <type>XR_MAKE_VERSION</type>(1, 0, 5)</type>
117117

118118
<!--
119119
NOTE: For avoidance of ambiguity, there should only be 1 <name> tag immediately in
@@ -2448,5 +2448,54 @@ maintained in the master branch of the Khronos OpenXR GitHub project.
24482448
</require>
24492449
</extension>
24502450

2451+
<extension name="XR_MSFT_extension_50" number="50" type="instance" supported="disabled">
2452+
<require>
2453+
<enum value="1" name="XR_MSFT_extension_50_SPEC_VERSION"/>
2454+
<enum value="&quot;XR_MSFT_extension_50&quot;" name="XR_MSFT_extension_50_EXTENSION_NAME"/>
2455+
</require>
2456+
</extension>
2457+
<extension name="XR_MSFT_extension_51" number="51" type="instance" supported="disabled">
2458+
<require>
2459+
<enum value="1" name="XR_MSFT_extension_51_SPEC_VERSION"/>
2460+
<enum value="&quot;XR_MSFT_extension_51&quot;" name="XR_MSFT_extension_51_EXTENSION_NAME"/>
2461+
</require>
2462+
</extension>
2463+
<extension name="XR_MSFT_extension_52" number="52" type="instance" supported="disabled">
2464+
<require>
2465+
<enum value="1" name="XR_MSFT_extension_52_SPEC_VERSION"/>
2466+
<enum value="&quot;XR_MSFT_extension_52&quot;" name="XR_MSFT_extension_52_EXTENSION_NAME"/>
2467+
</require>
2468+
</extension>
2469+
<extension name="XR_MSFT_extension_53" number="53" type="instance" supported="disabled">
2470+
<require>
2471+
<enum value="1" name="XR_MSFT_extension_53_SPEC_VERSION"/>
2472+
<enum value="&quot;XR_MSFT_extension_53&quot;" name="XR_MSFT_extension_53_EXTENSION_NAME"/>
2473+
</require>
2474+
</extension>
2475+
<extension name="XR_MSFT_extension_54" number="54" type="instance" supported="disabled">
2476+
<require>
2477+
<enum value="1" name="XR_MSFT_extension_54_SPEC_VERSION"/>
2478+
<enum value="&quot;XR_MSFT_extension_54&quot;" name="XR_MSFT_extension_54_EXTENSION_NAME"/>
2479+
</require>
2480+
</extension>
2481+
<extension name="XR_MSFT_extension_55" number="55" type="instance" supported="disabled">
2482+
<require>
2483+
<enum value="1" name="XR_MSFT_extension_55_SPEC_VERSION"/>
2484+
<enum value="&quot;XR_MSFT_extension_55&quot;" name="XR_MSFT_extension_55_EXTENSION_NAME"/>
2485+
</require>
2486+
</extension>
2487+
<extension name="XR_MSFT_extension_56" number="56" type="instance" supported="disabled">
2488+
<require>
2489+
<enum value="1" name="XR_MSFT_extension_56_SPEC_VERSION"/>
2490+
<enum value="&quot;XR_MSFT_extension_56&quot;" name="XR_MSFT_extension_56_EXTENSION_NAME"/>
2491+
</require>
2492+
</extension>
2493+
<extension name="XR_MSFT_extension_57" number="57" type="instance" supported="disabled">
2494+
<require>
2495+
<enum value="1" name="XR_MSFT_extension_57_SPEC_VERSION"/>
2496+
<enum value="&quot;XR_MSFT_extension_57&quot;" name="XR_MSFT_extension_57_EXTENSION_NAME"/>
2497+
</require>
2498+
</extension>
2499+
24512500
</extensions>
24522501
</registry>

src/CMakeLists.txt

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,48 @@ if (BUILD_ALL_EXTENSIONS AND NOT VulkanHeaders_FOUND)
9292
message(FATAL_ERROR "Vulkan headers not found")
9393
endif()
9494

95+
# Find glslc shader compiler.
96+
# On Android, the NDK includes the binary, so no external dependency.
97+
if(ANDROID)
98+
file(GLOB glslc-folders ${ANDROID_NDK}/shader-tools/*)
99+
else()
100+
file(GLOB glslc-folders $ENV{VULKAN_SDK}/*)
101+
endif()
102+
find_program(CMAKE_GLSL_COMPILER glslc PATHS ${glslc-folders} NO_DEFAULT_PATH)
103+
if(CMAKE_GLSL_COMPILER)
104+
message(STATUS "Found glslc: ${CMAKE_GLSL_COMPILER}")
105+
else()
106+
message(STATUS "Could NOT find glslc, using precompiled .spv files")
107+
endif()
108+
109+
function(compile_glsl run_target_name)
110+
set(glsl_output_files "")
111+
foreach(in_file IN LISTS ARGN)
112+
get_filename_component(glsl_stage ${in_file} NAME_WE)
113+
set(out_file ${CMAKE_CURRENT_BINARY_DIR}/${glsl_stage}.spv)
114+
if(CMAKE_GLSL_COMPILER)
115+
# Run glslc if we can find it
116+
add_custom_command(
117+
OUTPUT ${out_file}
118+
COMMAND ${CMAKE_GLSL_COMPILER} -mfmt=c -fshader-stage=${glsl_stage} ${in_file} -o ${out_file}
119+
DEPENDS ${in_file}
120+
)
121+
else()
122+
# Use the precompiled .spv files
123+
get_filename_component(glsl_src_dir ${in_file} DIRECTORY)
124+
set(precompiled_file ${glsl_src_dir}/${glsl_stage}.spv)
125+
configure_file(${precompiled_file} ${out_file} COPYONLY)
126+
endif()
127+
list(APPEND glsl_output_files ${out_file})
128+
endforeach()
129+
add_custom_target(
130+
${run_target_name} ALL
131+
DEPENDS ${glsl_output_files}
132+
)
133+
set_target_properties(${run_target_name} PROPERTIES FOLDER ${HELPER_FOLDER})
134+
135+
endfunction()
136+
95137
find_package(OpenGL)
96138
if (OPENGL_FOUND)
97139
add_definitions(-DXR_USE_GRAPHICS_API_OPENGL)

src/tests/hello_xr/CMakeLists.txt

Lines changed: 2 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -31,53 +31,11 @@ set_target_properties(hello_xr PROPERTIES FOLDER ${SAMPLES_FOLDER})
3131
source_group("Headers" FILES ${LOCAL_HEADERS})
3232
source_group("Shaders" FILES ${VULKAN_SHADERS})
3333

34-
# Find glslc shader compiler.
35-
# On Android, the NDK includes the binary, so no external dependency.
36-
if(ANDROID)
37-
file(GLOB glslc-folders ${ANDROID_NDK}/shader-tools/*)
38-
else()
39-
file(GLOB glslc-folders $ENV{VULKAN_SDK}/*)
40-
endif()
41-
find_program(CMAKE_GLSL_COMPILER glslc PATHS ${glslc-folders} NO_DEFAULT_PATH)
42-
if(CMAKE_GLSL_COMPILER)
43-
message(STATUS "Found glslc: ${CMAKE_GLSL_COMPILER}")
44-
else()
45-
message(STATUS "Could NOT find glslc, using precompiled .spv files")
46-
endif()
47-
48-
function(compile_glsl)
49-
set(glsl_output_files "")
50-
foreach(in_file IN LISTS ARGN)
51-
get_filename_component(glsl_stage ${in_file} NAME_WE)
52-
set(out_file ${CMAKE_CURRENT_BINARY_DIR}/${glsl_stage}.spv)
53-
if(CMAKE_GLSL_COMPILER)
54-
# Run glslc if we can find it
55-
add_custom_command(
56-
OUTPUT ${out_file}
57-
COMMAND ${CMAKE_GLSL_COMPILER} -mfmt=c -fshader-stage=${glsl_stage} ${in_file} -o ${out_file}
58-
DEPENDS ${in_file}
59-
)
60-
else()
61-
# Use the precompiled .spv files
62-
get_filename_component(glsl_src_dir ${in_file} DIRECTORY)
63-
set(precompiled_file ${glsl_src_dir}/${glsl_stage}.spv)
64-
configure_file(${precompiled_file} ${out_file} COPYONLY)
65-
endif()
66-
list(APPEND glsl_output_files ${out_file})
67-
endforeach()
68-
add_custom_target(
69-
run_glsl_compiles ALL
70-
DEPENDS ${glsl_output_files}
71-
)
72-
set_target_properties(run_glsl_compiles PROPERTIES FOLDER ${HELPER_FOLDER})
73-
74-
endfunction()
75-
76-
compile_glsl(${VULKAN_SHADERS})
34+
compile_glsl(run_hello_xr_glsl_compiles ${VULKAN_SHADERS})
7735

7836
add_dependencies(hello_xr
7937
generate_openxr_header
80-
run_glsl_compiles
38+
run_hello_xr_glsl_compiles
8139
)
8240

8341
target_include_directories(hello_xr

0 commit comments

Comments
 (0)