Remove warning since it isn't logged by default in the loader

Author: brycehutchings

src/api_layers/api_dump.cpp

@@ -76,12 +76,6 @@ void LogPlatformUtilsError(const std::string &message) {
     OutputDebugStringA((message + "\n").c_str());
 #endif
 }
-void LogPlatformUtilsWarning(const std::string &message) {
-    std::cout << message << std::endl;
-#if defined(XR_OS_WINDOWS)
-    OutputDebugStringA((message + "\n").c_str());
-#endif
-}
 
 // HTML utilities
 bool ApiDumpLayerWriteHtmlHeader() {

src/api_layers/core_validation.cpp

@@ -218,12 +218,6 @@ void LogPlatformUtilsError(const std::string &message) {
     OutputDebugStringA((message + "\n").c_str());
 #endif
 }
-void LogPlatformUtilsWarning(const std::string &message) {
-    std::cout << message << std::endl;
-#if defined(XR_OS_WINDOWS)
-    OutputDebugStringA((message + "\n").c_str());
-#endif
-}
 
 // Function to record all the core validation information
 void CoreValidLogMessage(GenValidUsageXrInstanceInfo *instance_info, const std::string &message_id,

src/common/platform_utils.hpp

@@ -36,10 +36,9 @@
 #include "common_config.h"
 #endif  // OPENXR_HAVE_COMMON_CONFIG
 
-// Consumers of this file must ensure these two functions are implemented. For example, the loader will implement these functions so
-// that it can route messages through the loader's logging system.
+// Consumers of this file must ensure this function is implemented. For example, the loader will implement this function so that it
+// can route messages through the loader's logging system.
 void LogPlatformUtilsError(const std::string& message);
-void LogPlatformUtilsWarning(const std::string& message);
 
 // Environment variables
 #if defined(XR_OS_LINUX) || defined(XR_OS_APPLE)
@@ -85,9 +84,9 @@ static inline std::string PlatformUtilsGetSecureEnv(const char* name) {
     if (str == nullptr) {
         str = detail::ImplGetEnv(name);
         if (!str.empty()) {
-            LogPlatformUtilsWarning(std::string("!!! WARNING !!! Environment variable ") + name +
-                                    " is being ignored due to running with secure execution. The value '" + str +
-                                    "' will NOT be used.");
+            LogPlatformUtilsError(std::string("!!! WARNING !!! Environment variable ") + name +
+                                  " is being ignored due to running with secure execution. The value '" + str +
+                                  "' will NOT be used.");
         }
         return {};
     }
@@ -266,9 +265,9 @@ static inline std::string PlatformUtilsGetSecureEnv(const char* name) {
     // Do not allow high integrity processes to act on data that can be controlled by medium integrity processes.
     if (IsHighIntegrityLevel()) {
         if (!envValue.empty()) {
-            LogPlatformUtilsWarning(std::string("!!! WARNING !!! Environment variable ") + name +
-                                    " is being ignored due to running from an elevated context. The value '" + envValue +
-                                    "' will NOT be used.");
+            LogPlatformUtilsError(std::string("!!! WARNING !!! Environment variable ") + name +
+                                  " is being ignored due to running from an elevated context. The value '" + envValue +
+                                  "' will NOT be used.");
         }
         return {};
     }

src/loader/loader_logger.cpp

@@ -28,7 +28,6 @@
 
 // For routing platform_utils.hpp messages into the LoaderLogger.
 void LogPlatformUtilsError(const std::string& message) { LoaderLogger::LogErrorMessage("platform_utils", message); }
-void LogPlatformUtilsWarning(const std::string& message) { LoaderLogger::LogWarningMessage("platform_utils", message); }
 
 bool LoaderLogRecorder::LogDebugUtilsMessage(XrDebugUtilsMessageSeverityFlagsEXT /*message_severity*/,
                                              XrDebugUtilsMessageTypeFlagsEXT /*message_type*/,