Skip to content

Commit d5c52b8

Browse files
committed
Return value is set incorrectly.
On Android if XR_KHR_LOADER_INIT_SUPPORT is defined but that method fails result will be set to a failure value. If next PlatformGetGlobalRuntimeFileName succeeds it doesn't set result to XR_SUCCESS failing when it should have succeeded.
1 parent bd5e5cb commit d5c52b8

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

src/loader/manifest_file.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -637,6 +637,8 @@ XrResult RuntimeManifestFile::FindManifestFiles(std::vector<std::unique_ptr<Runt
637637
LoaderLogger::LogErrorMessage(
638638
"", "RuntimeManifestFile::FindManifestFiles - failed to determine active runtime file path for this environment");
639639
return XR_ERROR_RUNTIME_UNAVAILABLE;
640+
} else {
641+
result = XR_SUCCESS;
640642
}
641643
LoaderLogger::LogInfoMessage("", "RuntimeManifestFile::FindManifestFiles - using global runtime file " + filename);
642644
#endif

0 commit comments

Comments
 (0)