Skip to content

Commit ea89384

Browse files
quic-dengkailrpavlik
authored andcommitted
OpenXR loader: Retrieve runtime info source
1 parent d173b91 commit ea89384

File tree

3 files changed

+10
-6
lines changed

3 files changed

+10
-6
lines changed

src/loader/android_utilities.cpp

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -273,12 +273,14 @@ static bool getActiveRuntimeCursor(wrap::android::content::Context const &contex
273273
return getCursor(context, projection, uri, systemBroker, "active runtime", cursor);
274274
}
275275

276-
int getActiveRuntimeVirtualManifest(wrap::android::content::Context const &context, Json::Value &virtualManifest) {
277-
jni::Array<std::string> projection = makeArray({active_runtime::Columns::PACKAGE_NAME, active_runtime::Columns::NATIVE_LIB_DIR,
278-
active_runtime::Columns::SO_FILENAME, active_runtime::Columns::HAS_FUNCTIONS});
276+
int getActiveRuntimeVirtualManifest(wrap::android::content::Context const &context, Json::Value &virtualManifest,
277+
bool &systemBroker) {
278+
const jni::Array<std::string> projection =
279+
makeArray({active_runtime::Columns::PACKAGE_NAME, active_runtime::Columns::NATIVE_LIB_DIR,
280+
active_runtime::Columns::SO_FILENAME, active_runtime::Columns::HAS_FUNCTIONS});
279281

280282
// First, try getting the installable broker's provider
281-
bool systemBroker = false;
283+
systemBroker = false;
282284
Cursor cursor;
283285
if (!getActiveRuntimeCursor(context, projection, systemBroker, cursor)) {
284286
// OK, try the system broker as a fallback.

src/loader/android_utilities.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,8 @@ using wrap::android::content::Context;
2626
*
2727
* @return 0 on success, something else on failure.
2828
*/
29-
int getActiveRuntimeVirtualManifest(wrap::android::content::Context const &context, Json::Value &virtualManifest);
29+
int getActiveRuntimeVirtualManifest(wrap::android::content::Context const &context, Json::Value &virtualManifest,
30+
bool &systemBroker);
3031
} // namespace openxr_android
3132

3233
#endif // __ANDROID__

src/loader/runtime_interface.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,9 @@ XrResult GetPlatformRuntimeVirtualManifest(Json::Value& out_manifest) {
4545
if (context.isNull()) {
4646
return XR_ERROR_INITIALIZATION_FAILED;
4747
}
48+
bool systemBroker = false;
4849
Json::Value virtualManifest;
49-
if (0 != openxr_android::getActiveRuntimeVirtualManifest(context, virtualManifest)) {
50+
if (0 != openxr_android::getActiveRuntimeVirtualManifest(context, virtualManifest, systemBroker)) {
5051
return XR_ERROR_INITIALIZATION_FAILED;
5152
}
5253
out_manifest = virtualManifest;

0 commit comments

Comments
 (0)