validation_layer_generator: do not check static array addresses

The generator creates the same validation code for a static array
of structs than for a pointer to a struct (used for dynamically
allocated arrays): it first checks if the content of the member is not
null.

Given that static array addresses are always not null, GCC (12.2.1) and
CLANG (16.0.1) emit pointer-bool-conversion warnings.

Author: sdegrande

src/scripts/validation_layer_generator.py

@@ -1437,9 +1437,10 @@ def outputParamMemberContents(self, is_command, struct_command_name, param_membe
                                                                                indent)
             if (param_member.is_handle or self.isEnumType(param_member.type) or
                     (self.isStruct(param_member.type) and not self.isStructAlwaysValid(param_member.type))):
-                loop_string += self.writeIndent(indent)
-                loop_string += 'if (%s) {\n' % (prefixed_param_member_name)
-                indent = indent + 1
+                if not param_member.is_static_array:
+                    loop_string += self.writeIndent(indent)
+                    loop_string += 'if (%s) {\n' % (prefixed_param_member_name)
+                    indent = indent + 1
                 loop_string += self.writeIndent(indent)
                 loop_string += 'for (uint32_t %s = 0; %s < %s; ++%s) {\n' % (loop_param_name,
                                                                              loop_param_name,
@@ -1841,12 +1842,14 @@ def outputParamMemberContents(self, is_command, struct_command_name, param_membe
                 param_member_contents += self.writeIndent(indent)
                 param_member_contents += '}\n'
         if is_loop:
-            indent = indent - 2
             if wrote_loop:
-                param_member_contents += self.writeIndent(indent + 1)
-                param_member_contents += '}\n'
+                indent = indent - 1
                 param_member_contents += self.writeIndent(indent)
                 param_member_contents += '}\n'
+                if not param_member.is_static_array:
+                    indent = indent - 1
+                    param_member_contents += self.writeIndent(indent)
+                    param_member_contents += '}\n'
 
         return param_member_contents