Skip to content

Commit 266f7c0

Browse files
committed
Fix BFloat16 argument type demangling (#3563)
Ensure we get all the information about parameter types from the mangled builtin name.
1 parent a46879b commit 266f7c0

File tree

3 files changed

+66
-0
lines changed

3 files changed

+66
-0
lines changed

lib/SPIRV/SPIRVUtil.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -625,6 +625,7 @@ static Type *parsePrimitiveType(LLVMContext &Ctx, StringRef Name) {
625625
.Cases("long", "unsigned long", Type::getInt64Ty(Ctx))
626626
.Cases("long long", "unsigned long long", Type::getInt64Ty(Ctx))
627627
.Case("half", Type::getHalfTy(Ctx))
628+
.Case("std::bfloat16_t", Type::getBFloatTy(Ctx))
628629
.Case("float", Type::getFloatTy(Ctx))
629630
.Case("double", Type::getDoubleTy(Ctx))
630631
.Case("void", Type::getInt8Ty(Ctx))
@@ -804,6 +805,10 @@ parseNode(Module *M, const llvm::itanium_demangle::Node *ParamType,
804805
// struct types were are looking for here.
805806
}
806807
} else if (auto *VendorTy = dyn_cast<VendorExtQualType>(ParamType)) {
808+
if (auto *NameTy = dyn_cast<NameType>(VendorTy->getTy())) {
809+
if (NameTy->getName() == "std::bfloat16_t")
810+
PointeeTy = llvm::Type::getBFloatTy(M->getContext());
811+
}
807812
// This is a block parameter. Decode the pointee type as if it were a
808813
// void (*)(void) function pointer type.
809814
if (VendorTy->getExt() == "block_pointer") {

test/extensions/INTEL/SPV_INTEL_bfloat16/bfloat16_math.ll renamed to test/extensions/INTEL/SPV_INTEL_bfloat16_arithmetic/bfloat16_math.ll

File renamed without changes.
Lines changed: 61 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,61 @@
1+
; RUN: llvm-as %s -o %t.bc
2+
; RUN: llvm-spirv %t.bc -spirv-text -o %t.spt --spirv-ext=+SPV_KHR_bfloat16,+SPV_INTEL_bfloat16_arithmetic
3+
; RUN: FileCheck < %t.spt %s --check-prefix=CHECK-SPIRV
4+
; RUN: llvm-spirv -to-binary %t.spt -o %t.spv
5+
; TODO: reenable the validation once the BFloat16 type is supported in ExtInst.
6+
; Currently fails with: ExtInst doesn't support BFloat16 type.
7+
; RUNx: spirv-val %t.spv
8+
; RUN: llvm-spirv -r %t.spv -o - | llvm-dis -o %t.rev.ll
9+
; RUN: FileCheck < %t.rev.ll %s --check-prefix=CHECK-LLVM
10+
; RUN: llvm-spirv -r %t.spv --spirv-target-env=SPV-IR -o - | llvm-dis -o %t.rev.ll
11+
; RUN: FileCheck < %t.rev.ll %s --check-prefix=CHECK-SPV-IR
12+
13+
14+
; CHECK-SPIRV: Capability BFloat16TypeKHR
15+
; CHECK-SPIRV: Extension "SPV_KHR_bfloat16"
16+
; CHECK-SPIRV: TypeFloat [[#BFLOAT:]] 16 0
17+
; CHECK-SPIRV: TypeVector [[#VEC:]] [[#BFLOAT]] 2
18+
; CHECK-SPIRV: TypePointer [[#PTR:]] [[#]] [[#BFLOAT]]
19+
20+
; CHECK-LABEL: Function
21+
; CHECK-SPIRV: FunctionParameter [[#PTR]] [[#PTR_ARG:]]
22+
; CHECK-SPIRV: ExtInst [[#VEC]] [[#]] [[#]] vloadn [[#]] [[#PTR_ARG]] 2
23+
24+
; CHECK-LABEL: Function
25+
; CHECK-SPIRV: FunctionParameter [[#VEC]] [[#DATA_ARG:]]
26+
; CHECK-SPIRV: FunctionParameter [[#PTR]] [[#PTR_ARG2:]]
27+
; CHECK-SPIRV: ExtInst [[#]] [[#]] [[#]] vstoren [[#DATA_ARG]] [[#]] [[#PTR_ARG2]]
28+
29+
target datalayout = "e-i64:64-v16:16-v24:32-v32:32-v48:64-v96:128-v192:256-v256:256-v512:512-v1024:1024-n8:16:32:64"
30+
target triple = "spir64-unknown-unknown"
31+
32+
; CHECK-LLVM: call spir_func <2 x bfloat> @_Z6vload2mPU3AS1KDF16b(i64 %offset, ptr addrspace(1) %ptr)
33+
; CHECK-LLVM: call spir_func void @_Z7vstore2Dv2_DF16bmPU3AS1DF16b(<2 x bfloat> %data, i64 %offset, ptr addrspace(1) %ptr)
34+
35+
; CHECK-SPV-IR: call spir_func <2 x bfloat> @_Z26__spirv_ocl_vloadn_RDF16b2mPU3AS1KDF16bi(i64 %offset, ptr addrspace(1) %ptr, i32 2)
36+
; CHECK-SPV-IR: call spir_func void @_Z19__spirv_ocl_vstorenDv2_DF16bmPU3AS1DF16b(<2 x bfloat> %data, i64 %offset, ptr addrspace(1) %ptr)
37+
38+
define spir_func <2 x bfloat> @test_spirv_ocl_vload2(i64 %offset, ptr addrspace(1) %ptr) {
39+
%result = call spir_func <2 x bfloat> @_Z26__spirv_ocl_vloadn__RDF16blPU3AS1DF16bi(i64 %offset, ptr addrspace(1) %ptr, i32 2)
40+
ret <2 x bfloat> %result
41+
}
42+
43+
define spir_func void @test_spirv_ocl_vstore2(<2 x bfloat> %data, i64 %offset, ptr addrspace(1) %ptr) {
44+
call spir_func void @_Z19__spirv_ocl_vstorenDv2_DF16blPU3AS1DF16b(<2 x bfloat> %data, i64 %offset, ptr addrspace(1) %ptr)
45+
ret void
46+
}
47+
48+
declare spir_func <2 x bfloat> @_Z26__spirv_ocl_vloadn__RDF16blPU3AS1DF16bi(i64, bfloat addrspace(1)*, i32)
49+
declare spir_func void @_Z19__spirv_ocl_vstorenDv2_DF16blPU3AS1DF16b(<2 x bfloat>, i64, bfloat addrspace(1)*)
50+
51+
!opencl.enable.FP_CONTRACT = !{}
52+
!opencl.spir.version = !{!0}
53+
!opencl.ocl.version = !{!1}
54+
!opencl.used.extensions = !{!2}
55+
!opencl.used.optional.core.features = !{!3}
56+
!opencl.compiler.options = !{!3}
57+
58+
!0 = !{i32 1, i32 2}
59+
!1 = !{i32 2, i32 0}
60+
!2 = !{!"cl_khr_fp16"}
61+
!3 = !{}

0 commit comments

Comments
 (0)