Skip to content

Commit 6b581f9

Browse files
authored
[Backport to 18] Remove SPV_INTEL_fast_composite extension (#3226)
1 parent 1b4a17c commit 6b581f9

File tree

11 files changed

+1
-104
lines changed

11 files changed

+1
-104
lines changed

include/LLVMSPIRVExtensions.inc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ EXT(SPV_INTEL_arbitrary_precision_integers)
3434
EXT(SPV_INTEL_optimization_hints)
3535
EXT(SPV_INTEL_float_controls2)
3636
EXT(SPV_INTEL_vector_compute)
37-
EXT(SPV_INTEL_fast_composite)
37+
EXT(SPV_INTEL_fast_composite) // TODO: to remove
3838
EXT(SPV_INTEL_usm_storage_classes)
3939
EXT(SPV_INTEL_fpga_buffer_location)
4040
EXT(SPV_INTEL_arbitrary_precision_fixed_point)

lib/SPIRV/PreprocessMetadata.cpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -366,12 +366,6 @@ void PreprocessMetadataBase::preprocessVectorComputeMetadata(Module *M,
366366
.add(SLMSize)
367367
.done();
368368
}
369-
if (Attrs.hasFnAttr(kVCMetadata::VCFCEntry)) {
370-
EM.addOp()
371-
.add(&F)
372-
.add(spv::internal::ExecutionModeFastCompositeKernelINTEL)
373-
.done();
374-
}
375369

376370
if (Attrs.hasFnAttr(kVCMetadata::VCNamedBarrierCount)) {
377371
SPIRVWord NBarrierCnt = 0;

lib/SPIRV/SPIRVReader.cpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4506,12 +4506,6 @@ bool SPIRVToLLVM::transMetadata() {
45064506
if (BM->getDesiredBIsRepresentation() == BIsRepresentation::SPIRVFriendlyIR)
45074507
transFunctionDecorationsToMetadata(BF, F);
45084508

4509-
if (BF->hasDecorate(internal::DecorationCallableFunctionINTEL))
4510-
F->addFnAttr(kVCMetadata::VCCallable);
4511-
if (isKernel(BF) &&
4512-
BF->getExecutionMode(internal::ExecutionModeFastCompositeKernelINTEL))
4513-
F->addFnAttr(kVCMetadata::VCFCEntry);
4514-
45154509
if (F->getCallingConv() != CallingConv::SPIR_KERNEL)
45164510
continue;
45174511

lib/SPIRV/SPIRVWriter.cpp

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -991,11 +991,6 @@ SPIRVFunction *LLVMToSPIRVBase::transFunctionDecl(Function *F) {
991991
BF->addDecorate(DecorationReferencedIndirectlyINTEL);
992992
}
993993

994-
if (Attrs.hasFnAttr(kVCMetadata::VCCallable) &&
995-
BM->isAllowedToUseExtension(ExtensionID::SPV_INTEL_fast_composite)) {
996-
BF->addDecorate(internal::DecorationCallableFunctionINTEL);
997-
}
998-
999994
if (BM->isAllowedToUseExtension(ExtensionID::SPV_INTEL_vector_compute))
1000995
transVectorComputeMetadata(F);
1001996

@@ -5988,11 +5983,6 @@ bool LLVMToSPIRVBase::transExecutionMode() {
59885983
break;
59895984
AddSingleArgExecutionMode(static_cast<ExecutionMode>(EMode));
59905985
} break;
5991-
case spv::internal::ExecutionModeFastCompositeKernelINTEL: {
5992-
if (BM->isAllowedToUseExtension(ExtensionID::SPV_INTEL_fast_composite))
5993-
BF->addExecutionMode(BM->add(new SPIRVExecutionMode(
5994-
OpExecutionMode, BF, static_cast<ExecutionMode>(EMode))));
5995-
} break;
59965986
default:
59975987
llvm_unreachable("invalid execution mode");
59985988
}

lib/SPIRV/libSPIRV/SPIRVDecorate.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -182,8 +182,6 @@ class SPIRVDecorate : public SPIRVDecorateGeneric {
182182
return ExtensionID::SPV_INTEL_fpga_cluster_attributes;
183183
case DecorationFuseLoopsInFunctionINTEL:
184184
return ExtensionID::SPV_INTEL_loop_fuse;
185-
case internal::DecorationCallableFunctionINTEL:
186-
return ExtensionID::SPV_INTEL_fast_composite;
187185
case DecorationMathOpDSPModeINTEL:
188186
return ExtensionID::SPV_INTEL_fpga_dsp_control;
189187
case DecorationInitiationIntervalINTEL:

lib/SPIRV/libSPIRV/SPIRVEntry.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -907,8 +907,6 @@ class SPIRVCapability : public SPIRVEntryNoId<OpCapability> {
907907
case CapabilityVectorComputeINTEL:
908908
case CapabilityVectorAnyINTEL:
909909
return ExtensionID::SPV_INTEL_vector_compute;
910-
case internal::CapabilityFastCompositeINTEL:
911-
return ExtensionID::SPV_INTEL_fast_composite;
912910
default:
913911
return {};
914912
}

lib/SPIRV/libSPIRV/SPIRVEnum.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -286,8 +286,6 @@ template <> inline void SPIRVMap<SPIRVExecutionModeKind, SPIRVCapVec>::init() {
286286
{CapabilityFloatingPointModeINTEL});
287287
ADD_VEC_INIT(ExecutionModeSharedLocalMemorySizeINTEL,
288288
{CapabilityVectorComputeINTEL});
289-
ADD_VEC_INIT(internal::ExecutionModeFastCompositeKernelINTEL,
290-
{internal::CapabilityFastCompositeINTEL});
291289
ADD_VEC_INIT(ExecutionModeRegisterMapInterfaceINTEL,
292290
{CapabilityFPGAKernelAttributesv2INTEL});
293291
ADD_VEC_INIT(ExecutionModeStreamingInterfaceINTEL,
@@ -467,8 +465,6 @@ template <> inline void SPIRVMap<Decoration, SPIRVCapVec>::init() {
467465
ADD_VEC_INIT(DecorationAliasScopeINTEL,
468466
{CapabilityMemoryAccessAliasingINTEL});
469467
ADD_VEC_INIT(DecorationNoAliasINTEL, {CapabilityMemoryAccessAliasingINTEL});
470-
ADD_VEC_INIT(internal::DecorationCallableFunctionINTEL,
471-
{internal::CapabilityFastCompositeINTEL});
472468
ADD_VEC_INIT(DecorationMediaBlockIOINTEL, {CapabilityVectorComputeINTEL});
473469
ADD_VEC_INIT(DecorationStallEnableINTEL,
474470
{CapabilityFPGAClusterAttributesINTEL});

lib/SPIRV/libSPIRV/SPIRVNameMapEnum.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,6 @@ template <> inline void SPIRVMap<Decoration, std::string>::init() {
212212
add(DecorationCacheControlStoreINTEL, "CacheControlStoreINTEL");
213213

214214
// From spirv_internal.hpp
215-
add(internal::DecorationCallableFunctionINTEL, "CallableFunctionINTEL");
216215
add(internal::DecorationRuntimeAlignedINTEL, "RuntimeAlignedINTEL");
217216
add(internal::DecorationHostAccessINTEL, "HostAccessINTEL");
218217
add(internal::DecorationInitModeINTEL, "InitModeINTEL");
@@ -651,7 +650,6 @@ template <> inline void SPIRVMap<Capability, std::string>::init() {
651650
"SubgroupMatrixMultiplyAccumulateINTEL");
652651
add(CapabilityTernaryBitwiseFunctionINTEL, "TernaryBitwiseFunctionINTEL");
653652
// From spirv_internal.hpp
654-
add(internal::CapabilityFastCompositeINTEL, "FastCompositeINTEL");
655653
add(internal::CapabilityTokenTypeINTEL, "TokenTypeINTEL");
656654
add(internal::CapabilityBfloat16ConversionINTEL, "Bfloat16ConversionINTEL");
657655
add(internal::CapabilityJointMatrixINTEL, "JointMatrixINTEL");

lib/SPIRV/libSPIRV/spirv_internal.hpp

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,6 @@ enum InternalDecoration {
9898
};
9999

100100
enum InternalCapability {
101-
ICapFastCompositeINTEL = 6093,
102101
ICapTokenTypeINTEL = 6112,
103102
ICapBfloat16ConversionINTEL = 6115,
104103
ICapabilityJointMatrixINTEL = 6118,
@@ -118,10 +117,6 @@ enum InternalCapability {
118117
ICapabilityBindlessImagesINTEL = 6528
119118
};
120119

121-
enum InternalExecutionMode {
122-
IExecModeFastCompositeKernelINTEL = 6088,
123-
};
124-
125120
constexpr LinkageType LinkageTypeInternal =
126121
static_cast<LinkageType>(ILTInternal);
127122

@@ -243,8 +238,6 @@ constexpr Op OpTypeTokenINTEL = static_cast<Op>(IOpTypeTokenINTEL);
243238
constexpr Op OpConvertFToBF16INTEL = static_cast<Op>(IOpConvertFToBF16INTEL);
244239
constexpr Op OpConvertBF16ToFINTEL = static_cast<Op>(IOpConvertBF16ToFINTEL);
245240

246-
constexpr Decoration DecorationCallableFunctionINTEL =
247-
static_cast<Decoration>(IDecCallableFunctionINTEL);
248241
constexpr Decoration DecorationRuntimeAlignedINTEL =
249242
static_cast<Decoration>(IDecRuntimeAlignedINTEL);
250243
constexpr Decoration DecorationHostAccessINTEL =
@@ -256,18 +249,13 @@ constexpr Decoration DecorationImplementInCSRINTEL =
256249
constexpr Decoration DecorationArgumentAttributeINTEL =
257250
static_cast<Decoration>(IDecArgumentAttributeINTEL);
258251

259-
constexpr Capability CapabilityFastCompositeINTEL =
260-
static_cast<Capability>(ICapFastCompositeINTEL);
261252
constexpr Capability CapabilityTokenTypeINTEL =
262253
static_cast<Capability>(ICapTokenTypeINTEL);
263254
constexpr Capability CapabilityBfloat16ConversionINTEL =
264255
static_cast<Capability>(ICapBfloat16ConversionINTEL);
265256
constexpr Capability CapabilityGlobalVariableDecorationsINTEL =
266257
static_cast<Capability>(ICapGlobalVariableDecorationsINTEL);
267258

268-
constexpr ExecutionMode ExecutionModeFastCompositeKernelINTEL =
269-
static_cast<ExecutionMode>(IExecModeFastCompositeKernelINTEL);
270-
271259
} // namespace internal
272260
} // namespace spv
273261

test/extensions/INTEL/SPV_INTEL_fast_composite/callable-attribute-decoration.ll

Lines changed: 0 additions & 19 deletions
This file was deleted.

0 commit comments

Comments
 (0)