Skip to content

Commit 74843f2

Browse files
[Backport to llvm_release_200] Remove SPV_INTEL_fast_composite extension (#3223)
Backport of PR #3183 into `llvm_release_200`. All commits applied cleanly. Co-authored-by: Vadim Semenov <sematom@gmail.com>
1 parent 34a02c4 commit 74843f2

File tree

11 files changed

+1
-101
lines changed

11 files changed

+1
-101
lines changed

include/LLVMSPIRVExtensions.inc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ EXT(SPV_INTEL_arbitrary_precision_integers)
3535
EXT(SPV_INTEL_optimization_hints)
3636
EXT(SPV_INTEL_float_controls2)
3737
EXT(SPV_INTEL_vector_compute)
38-
EXT(SPV_INTEL_fast_composite)
38+
EXT(SPV_INTEL_fast_composite) // TODO: to remove
3939
EXT(SPV_INTEL_usm_storage_classes)
4040
EXT(SPV_INTEL_fpga_buffer_location)
4141
EXT(SPV_INTEL_arbitrary_precision_fixed_point)

lib/SPIRV/PreprocessMetadata.cpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -359,12 +359,6 @@ void PreprocessMetadataBase::preprocessVectorComputeMetadata(Module *M,
359359
.add(SLMSize)
360360
.done();
361361
}
362-
if (Attrs.hasFnAttr(kVCMetadata::VCFCEntry)) {
363-
EM.addOp()
364-
.add(&F)
365-
.add(spv::internal::ExecutionModeFastCompositeKernelINTEL)
366-
.done();
367-
}
368362

369363
if (Attrs.hasFnAttr(kVCMetadata::VCNamedBarrierCount)) {
370364
SPIRVWord NBarrierCnt = 0;

lib/SPIRV/SPIRVReader.cpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4628,12 +4628,6 @@ bool SPIRVToLLVM::transMetadata() {
46284628
if (BM->getDesiredBIsRepresentation() == BIsRepresentation::SPIRVFriendlyIR)
46294629
transFunctionDecorationsToMetadata(BF, F);
46304630

4631-
if (BF->hasDecorate(internal::DecorationCallableFunctionINTEL))
4632-
F->addFnAttr(kVCMetadata::VCCallable);
4633-
if (isKernel(BF) &&
4634-
BF->getExecutionMode(internal::ExecutionModeFastCompositeKernelINTEL))
4635-
F->addFnAttr(kVCMetadata::VCFCEntry);
4636-
46374631
if (F->getCallingConv() != CallingConv::SPIR_KERNEL)
46384632
continue;
46394633

lib/SPIRV/SPIRVWriter.cpp

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1013,11 +1013,6 @@ SPIRVFunction *LLVMToSPIRVBase::transFunctionDecl(Function *F) {
10131013
BF->addDecorate(DecorationReferencedIndirectlyINTEL);
10141014
}
10151015

1016-
if (Attrs.hasFnAttr(kVCMetadata::VCCallable) &&
1017-
BM->isAllowedToUseExtension(ExtensionID::SPV_INTEL_fast_composite)) {
1018-
BF->addDecorate(internal::DecorationCallableFunctionINTEL);
1019-
}
1020-
10211016
if (BM->isAllowedToUseExtension(ExtensionID::SPV_INTEL_vector_compute))
10221017
transVectorComputeMetadata(F);
10231018

@@ -6230,11 +6225,6 @@ bool LLVMToSPIRVBase::transExecutionMode() {
62306225
break;
62316226
AddSingleArgExecutionMode(static_cast<ExecutionMode>(EMode));
62326227
} break;
6233-
case spv::internal::ExecutionModeFastCompositeKernelINTEL: {
6234-
if (BM->isAllowedToUseExtension(ExtensionID::SPV_INTEL_fast_composite))
6235-
BF->addExecutionMode(BM->add(new SPIRVExecutionMode(
6236-
OpExecutionMode, BF, static_cast<ExecutionMode>(EMode))));
6237-
} break;
62386228
case spv::internal::ExecutionModeNamedSubgroupSizeINTEL: {
62396229
if (!BM->isAllowedToUseExtension(
62406230
ExtensionID::SPV_INTEL_subgroup_requirements))

lib/SPIRV/libSPIRV/SPIRVDecorate.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -182,8 +182,6 @@ class SPIRVDecorate : public SPIRVDecorateGeneric {
182182
return ExtensionID::SPV_INTEL_fpga_cluster_attributes;
183183
case DecorationFuseLoopsInFunctionINTEL:
184184
return ExtensionID::SPV_INTEL_loop_fuse;
185-
case internal::DecorationCallableFunctionINTEL:
186-
return ExtensionID::SPV_INTEL_fast_composite;
187185
case DecorationMathOpDSPModeINTEL:
188186
return ExtensionID::SPV_INTEL_fpga_dsp_control;
189187
case DecorationInitiationIntervalINTEL:

lib/SPIRV/libSPIRV/SPIRVEntry.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -910,8 +910,6 @@ class SPIRVCapability : public SPIRVEntryNoId<OpCapability> {
910910
case CapabilityVectorComputeINTEL:
911911
case CapabilityVectorAnyINTEL:
912912
return ExtensionID::SPV_INTEL_vector_compute;
913-
case internal::CapabilityFastCompositeINTEL:
914-
return ExtensionID::SPV_INTEL_fast_composite;
915913
case internal::CapabilitySubgroupRequirementsINTEL:
916914
return ExtensionID::SPV_INTEL_subgroup_requirements;
917915
case CapabilityFPFastMathModeINTEL:

lib/SPIRV/libSPIRV/SPIRVEnum.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -288,8 +288,6 @@ template <> inline void SPIRVMap<SPIRVExecutionModeKind, SPIRVCapVec>::init() {
288288
{CapabilityFloatingPointModeINTEL});
289289
ADD_VEC_INIT(ExecutionModeSharedLocalMemorySizeINTEL,
290290
{CapabilityVectorComputeINTEL});
291-
ADD_VEC_INIT(internal::ExecutionModeFastCompositeKernelINTEL,
292-
{internal::CapabilityFastCompositeINTEL});
293291
ADD_VEC_INIT(ExecutionModeRegisterMapInterfaceINTEL,
294292
{CapabilityFPGAKernelAttributesv2INTEL});
295293
ADD_VEC_INIT(ExecutionModeStreamingInterfaceINTEL,
@@ -471,8 +469,6 @@ template <> inline void SPIRVMap<Decoration, SPIRVCapVec>::init() {
471469
ADD_VEC_INIT(DecorationAliasScopeINTEL,
472470
{CapabilityMemoryAccessAliasingINTEL});
473471
ADD_VEC_INIT(DecorationNoAliasINTEL, {CapabilityMemoryAccessAliasingINTEL});
474-
ADD_VEC_INIT(internal::DecorationCallableFunctionINTEL,
475-
{internal::CapabilityFastCompositeINTEL});
476472
ADD_VEC_INIT(DecorationMediaBlockIOINTEL, {CapabilityVectorComputeINTEL});
477473
ADD_VEC_INIT(DecorationStallEnableINTEL,
478474
{CapabilityFPGAClusterAttributesINTEL});

lib/SPIRV/libSPIRV/SPIRVNameMapEnum.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,6 @@ template <> inline void SPIRVMap<Decoration, std::string>::init() {
212212
add(DecorationCacheControlStoreINTEL, "CacheControlStoreINTEL");
213213

214214
// From spirv_internal.hpp
215-
add(internal::DecorationCallableFunctionINTEL, "CallableFunctionINTEL");
216215
add(internal::DecorationRuntimeAlignedINTEL, "RuntimeAlignedINTEL");
217216
add(internal::DecorationHostAccessINTEL, "HostAccessINTEL");
218217
add(internal::DecorationInitModeINTEL, "InitModeINTEL");
@@ -652,7 +651,6 @@ template <> inline void SPIRVMap<Capability, std::string>::init() {
652651
add(CapabilitySubgroupMatrixMultiplyAccumulateINTEL,
653652
"SubgroupMatrixMultiplyAccumulateINTEL");
654653
// From spirv_internal.hpp
655-
add(internal::CapabilityFastCompositeINTEL, "FastCompositeINTEL");
656654
add(internal::CapabilityTokenTypeINTEL, "TokenTypeINTEL");
657655
add(internal::CapabilityJointMatrixINTEL, "JointMatrixINTEL");
658656
add(internal::CapabilityHWThreadQueryINTEL, "HWThreadQueryINTEL");

lib/SPIRV/libSPIRV/spirv_internal.hpp

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,6 @@ enum InternalDecoration {
103103
};
104104

105105
enum InternalCapability {
106-
ICapFastCompositeINTEL = 6093,
107106
ICapTokenTypeINTEL = 6112,
108107
ICapabilityJointMatrixINTEL = 6118,
109108
ICapabilityHWThreadQueryINTEL = 6134,
@@ -126,7 +125,6 @@ enum InternalCapability {
126125
};
127126

128127
enum InternalExecutionMode {
129-
IExecModeFastCompositeKernelINTEL = 6088,
130128
IExecModeNamedSubgroupSizeINTEL = 6446,
131129
};
132130

@@ -262,8 +260,6 @@ constexpr SourceLanguage SourceLanguageCPP20 =
262260
constexpr Op OpForward = static_cast<Op>(IOpForward);
263261
constexpr Op OpTypeTokenINTEL = static_cast<Op>(IOpTypeTokenINTEL);
264262

265-
constexpr Decoration DecorationCallableFunctionINTEL =
266-
static_cast<Decoration>(IDecCallableFunctionINTEL);
267263
constexpr Decoration DecorationRuntimeAlignedINTEL =
268264
static_cast<Decoration>(IDecRuntimeAlignedINTEL);
269265
constexpr Decoration DecorationHostAccessINTEL =
@@ -275,16 +271,11 @@ constexpr Decoration DecorationImplementInCSRINTEL =
275271
constexpr Decoration DecorationArgumentAttributeINTEL =
276272
static_cast<Decoration>(IDecArgumentAttributeINTEL);
277273

278-
constexpr Capability CapabilityFastCompositeINTEL =
279-
static_cast<Capability>(ICapFastCompositeINTEL);
280274
constexpr Capability CapabilityTokenTypeINTEL =
281275
static_cast<Capability>(ICapTokenTypeINTEL);
282276
constexpr Capability CapabilityGlobalVariableDecorationsINTEL =
283277
static_cast<Capability>(ICapGlobalVariableDecorationsINTEL);
284278

285-
constexpr ExecutionMode ExecutionModeFastCompositeKernelINTEL =
286-
static_cast<ExecutionMode>(IExecModeFastCompositeKernelINTEL);
287-
288279
constexpr ExecutionMode ExecutionModeNamedSubgroupSizeINTEL =
289280
static_cast<ExecutionMode>(IExecModeNamedSubgroupSizeINTEL);
290281

test/extensions/INTEL/SPV_INTEL_fast_composite/callable-attribute-decoration.ll

Lines changed: 0 additions & 19 deletions
This file was deleted.

0 commit comments

Comments
 (0)