Skip to content

Commit 81c9ac6

Browse files
aratajewsvenvh
authored andcommitted
Fix mangling of opcodes from SPV_KHR_bit_instructions in SPV-IR (#1869)
1 parent 5fdc47b commit 81c9ac6

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

lib/SPIRV/SPIRVUtil.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2224,6 +2224,7 @@ class SPIRVFriendlyIRMangleInfo : public BuiltinFuncMangleInfo {
22242224
case OpGroupNonUniformBallotFindMSB:
22252225
addUnsignedArg(1);
22262226
break;
2227+
case OpBitFieldSExtract:
22272228
case OpGroupNonUniformBallotBitExtract:
22282229
addUnsignedArg(1);
22292230
addUnsignedArg(2);
@@ -2244,6 +2245,7 @@ class SPIRVFriendlyIRMangleInfo : public BuiltinFuncMangleInfo {
22442245
case OpGroupNonUniformLogicalXor:
22452246
addUnsignedArg(3);
22462247
break;
2248+
case OpBitFieldInsert:
22472249
case OpGroupNonUniformUMax:
22482250
case OpGroupNonUniformUMin:
22492251
addUnsignedArg(2);
@@ -2294,6 +2296,7 @@ class SPIRVFriendlyIRMangleInfo : public BuiltinFuncMangleInfo {
22942296
case OpSubgroupAvcImeSetSingleReferenceINTEL:
22952297
addUnsignedArg(1);
22962298
break;
2299+
case OpBitFieldUExtract:
22972300
case OpSubgroupAvcImeInitializeINTEL:
22982301
case OpSubgroupAvcMceSetMotionVectorCostFunctionINTEL:
22992302
case OpSubgroupAvcSicSetIntraLumaModeCostFunctionINTEL:

test/extensions/KHR/SPV_KHR_bit_instructions/cl_khr_extended_bit_ops.cl

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,15 @@
33
// RUN: llvm-spirv %t.bc --spirv-ext=+SPV_KHR_bit_instructions -o %t.spv
44
// RUN: llvm-spirv -r -emit-opaque-pointers %t.spv -o %t.rev.bc
55
// RUN: llvm-dis < %t.rev.bc | FileCheck %s --check-prefix=CHECK-LLVM
6+
// RUN: llvm-spirv -r --spirv-target-env=SPV-IR -emit-opaque-pointers %t.spv -o %t.rev.bc
7+
// RUN: llvm-dis < %t.rev.bc | FileCheck %s --check-prefix=CHECK-SPV-IR
68

79
// CHECK-SPIRV: Capability BitInstructions
810
// CHECK-SPIRV: Extension "SPV_KHR_bit_instructions"
911

1012
// CHECK-LLVM-LABEL: @testInsert
1113
// CHECK-LLVM: call spir_func <2 x i32> @_Z15bitfield_insertDv2_iS_jj(
14+
// CHECK-SPV-IR: call spir_func <2 x i32> @_Z22__spirv_BitFieldInsertDv2_iS_jj(
1215
// CHECK-SPIRV: Function
1316
// CHECK-SPIRV: FunctionParameter {{[0-9]+}} [[insbase:[0-9]+]]
1417
// CHECK-SPIRV: FunctionParameter {{[0-9]+}} [[insins:[0-9]+]]
@@ -20,6 +23,8 @@ kernel void testInsert(int2 b, int2 i, global int2 *res) {
2023
// CHECK-LLVM-LABEL: @testExtractS
2124
// CHECK-LLVM: call spir_func i16 @_Z23bitfield_extract_signedsjj(
2225
// CHECK-LLVM: call spir_func i16 @_Z23bitfield_extract_signedsjj(
26+
// CHECK-SPV-IR: call spir_func i16 @_Z24__spirv_BitFieldSExtractsjj(
27+
// CHECK-SPV-IR: call spir_func i16 @_Z24__spirv_BitFieldSExtractsjj(
2328
// CHECK-SPIRV: Function
2429
// CHECK-SPIRV: FunctionParameter {{[0-9]+}} [[sextrbase:[0-9]+]]
2530
// CHECK-SPIRV: FunctionParameter {{[0-9]+}} [[sextrbaseu:[0-9]+]]
@@ -33,6 +38,8 @@ kernel void testExtractS(short b, ushort bu, global short *res) {
3338
// CHECK-LLVM-LABEL: @testExtractU
3439
// CHECK-LLVM: call spir_func <8 x i8> @_Z25bitfield_extract_unsignedDv8_cjj(
3540
// CHECK-LLVM: call spir_func <8 x i8> @_Z25bitfield_extract_unsignedDv8_cjj(
41+
// CHECK-SPV-IR: call spir_func <8 x i8> @_Z24__spirv_BitFieldUExtractDv8_hjj(
42+
// CHECK-SPV-IR: call spir_func <8 x i8> @_Z24__spirv_BitFieldUExtractDv8_hjj(
3643
// CHECK-SPIRV: Function
3744
// CHECK-SPIRV: FunctionParameter {{[0-9]+}} [[uextrbase:[0-9]+]]
3845
// CHECK-SPIRV: FunctionParameter {{[0-9]+}} [[uextrbaseu:[0-9]+]]
@@ -45,6 +52,7 @@ kernel void testExtractU(char8 b, uchar8 bu, global uchar8 *res) {
4552

4653
// CHECK-LLVM-LABEL: @testBitReverse
4754
// CHECK-LLVM: call <4 x i64> @llvm.bitreverse.v4i64(
55+
// CHECK-SPV-IR: call <4 x i64> @llvm.bitreverse.v4i64(
4856
// CHECK-SPIRV: Function
4957
// CHECK-SPIRV: FunctionParameter {{[0-9]+}} [[revbase:[0-9]+]]
5058
// CHECK-SPIRV: BitReverse {{[0-9]+}} {{[0-9]+}} [[revbase]]

0 commit comments

Comments
 (0)