Skip to content

Commit a104311

Browse files
authored
[SPIR-V 1.5] Move the version to supported (#2497)
1 parent c6e9fea commit a104311

File tree

5 files changed

+6
-5
lines changed

5 files changed

+6
-5
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ the version of the SPIR-V file which is being generated/consumed.
203203
the input file and emit an error if the SPIR-V version in it is higher than
204204
one specified via this option.
205205
206-
Allowed values are `1.0`, `1.1`, `1.2`, `1.3`, and `1.4`.
206+
Allowed values are `1.0`, `1.1`, `1.2`, `1.3`, `1.4`, and `1.5`.
207207
208208
More information can be found in
209209
[SPIR-V versions and extensions handling](docs/SPIRVVersionsAndExtensionsHandling.rst)

docs/SPIRVVersionsAndExtensionsHandling.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ the version of the SPIR-V file which is being generated/consumed.
6565
one exception: resulting SPIR-V version cannot be raised higher than
6666
specified by this option.
6767

68-
Allowed values are ``1.0``, ``1.1``, ``1.2``, ``1.3``, and ``1.4``.
68+
Allowed values are ``1.0``, ``1.1``, ``1.2``, ``1.3``, ``1.4``, and ``1.5``.
6969

7070
.. warning::
7171
These two options are mutually exclusive and cannot be specified at the

lib/SPIRV/SPIRVWriter.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6673,6 +6673,8 @@ VersionNumber getVersionFromTriple(const Triple &TT, SPIRVErrorLog &ErrorLog) {
66736673
return VersionNumber::SPIRV_1_3;
66746674
case Triple::SPIRVSubArch_v14:
66756675
return VersionNumber::SPIRV_1_4;
6676+
case Triple::SPIRVSubArch_v15:
6677+
return VersionNumber::SPIRV_1_5;
66766678
default:
66776679
ErrorLog.checkError(false, SPIRVEC_InvalidSubArch, TT.getArchName().str());
66786680
return VersionNumber::MaximumVersion;

lib/SPIRV/libSPIRV/SPIRVErrorEnum.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
_SPIRV_OP(Success, "Success")
33
_SPIRV_OP(InvalidTargetTriple,
44
"Expects spir-unknown-unknown or spir64-unknown-unknown.")
5-
_SPIRV_OP(InvalidSubArch, "Expecting v1.0-v1.4.")
5+
_SPIRV_OP(InvalidSubArch, "Expecting v1.0-v1.5.")
66
_SPIRV_OP(TripleMaxVersionIncompatible,
77
"Triple version and maximum version are incompatible.")
88
_SPIRV_OP(InvalidAddressingModel, "Expects 0-2.")

tools/llvm-spirv/llvm-spirv.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,8 +112,7 @@ static cl::opt<VersionNumber> MaxSPIRVVersion(
112112
clEnumValN(VersionNumber::SPIRV_1_2, "1.2", "SPIR-V 1.2"),
113113
clEnumValN(VersionNumber::SPIRV_1_3, "1.3", "SPIR-V 1.3"),
114114
clEnumValN(VersionNumber::SPIRV_1_4, "1.4", "SPIR-V 1.4"),
115-
clEnumValN(VersionNumber::SPIRV_1_5, "1.5",
116-
"SPIR-V 1.5 (experimental)")),
115+
clEnumValN(VersionNumber::SPIRV_1_5, "1.5", "SPIR-V 1.5")),
117116
cl::init(VersionNumber::MaximumVersion));
118117

119118
static cl::list<std::string>

0 commit comments

Comments
 (0)