Fix code quality issues. (#3361)

Fix code quality issues reported by a static analysis tool.

Author: Marcos Maronas

include/LLVMSPIRVOpts.h

@@ -273,14 +273,14 @@ class TranslatorOpts {
   }
 
   void setFnVarFeatures(std::vector<uint32_t> Features) noexcept {
-    FnVarFeatures = Features;
+    FnVarFeatures = std::move(Features);
   }
   std::vector<uint32_t> getFnVarFeatures() const noexcept {
     return FnVarFeatures;
   }
 
   void setFnVarCapabilities(std::vector<uint32_t> Capabilities) noexcept {
-    FnVarCapabilities = Capabilities;
+    FnVarCapabilities = std::move(Capabilities);
   }
   std::vector<uint32_t> getFnVarCapabilities() const noexcept {
     return FnVarCapabilities;
@@ -289,7 +289,9 @@ class TranslatorOpts {
   void setFnVarSpecEnable(bool Val) noexcept { FnVarSpecEnable = Val; }
   bool getFnVarSpecEnable() const noexcept { return FnVarSpecEnable; }
 
-  void setFnVarSpvOut(std::string Val) noexcept { FnVarSpvOut = Val; }
+  void setFnVarSpvOut(std::string Val) noexcept {
+    FnVarSpvOut = std::move(Val);
+  }
   std::string getFnVarSpvOut() const noexcept { return FnVarSpvOut; }
 
   // Check that options passed to --fnvar-xxx flags make sense. Return true on

lib/SPIRV/libSPIRV/SPIRVFnVar.cpp

@@ -205,7 +205,7 @@ bool specializeFnVariants(SPIRVModule *BM, std::string &ErrMsg) {
   }
 
   for (const auto &CondExt : CondExtensions) {
-    const auto Ext = CondExt.first;
+    const auto &Ext = CondExt.first;
     const bool ShouldKeep = CondExt.second;
     if (ShouldKeep) {
       BM->getExtension().insert(Ext.second);

lib/SPIRV/libSPIRV/SPIRVFnVar.h

@@ -59,9 +59,9 @@ class SPIRVConditionalEntryPointINTEL : public SPIRVAnnotation {
                         TheModule->get<SPIRVFunction>(TheId),
                         getSizeInWords(TheName) + Variables.size() + 4),
         Condition(Condition), ExecModel(TheExecModel), Name(TheName),
-        Variables(Variables) {}
+        Variables(std::move(Variables)) {}
   SPIRVConditionalEntryPointINTEL()
-      : SPIRVAnnotation(OpConditionalEntryPointINTEL) {}
+      : SPIRVAnnotation(OpConditionalEntryPointINTEL), Condition() {}
 
   SPIRVId getCondition() const { return Condition; }
   SPIRVExecutionModelKind getExecModel() const { return ExecModel; }
@@ -95,7 +95,7 @@ class SPIRVConditionalExtensionINTEL
   SPIRVConditionalExtensionINTEL(SPIRVModule *M, SPIRVId C,
                                  const std::string &SS)
       : SPIRVEntryNoId(M, 2 + getSizeInWords(SS)), Condition(C), S(SS) {}
-  SPIRVConditionalExtensionINTEL() {}
+  SPIRVConditionalExtensionINTEL() : Condition() {}
 
   std::string getExtensionName() const { return S; }
   SPIRVId getCondition() const { return Condition; }
@@ -124,7 +124,7 @@ class SPIRVConditionalCapabilityINTEL
       : SPIRVEntryNoId(M, 3), Condition(C), Kind(K) {
     updateModuleVersion();
   }
-  SPIRVConditionalCapabilityINTEL() {}
+  SPIRVConditionalCapabilityINTEL() : Condition(), Kind() {}
 
   SPIRVId getCondition() const { return Condition; }
 
@@ -202,7 +202,7 @@ class SPIRVSpecConstantTargetINTEL : public SPIRVValue {
     validate();
   }
   // Incomplete constructor
-  SPIRVSpecConstantTargetINTEL() : SPIRVValue(OC) {}
+  SPIRVSpecConstantTargetINTEL() : SPIRVValue(OC), NumWords(), Target() {}
 
   SPIRVWord getTarget() const { return Target; }
   bool matchesDevice() {
@@ -279,7 +279,8 @@ class SPIRVSpecConstantArchitectureINTEL : public SPIRVValue {
     validate();
   }
   // Incomplete constructor
-  SPIRVSpecConstantArchitectureINTEL() : SPIRVValue(OC) {}
+  SPIRVSpecConstantArchitectureINTEL()
+      : SPIRVValue(OC), Category(), Family(), CmpOp(), Architecture() {}
 
   SPIRVWord getCategory() { return Category; }
   SPIRVWord getFamily() { return Family; }
@@ -375,7 +376,7 @@ class SPIRVSpecConstantCapabilitiesINTEL : public SPIRVValue {
     validate();
   }
   // Incomplete constructor
-  SPIRVSpecConstantCapabilitiesINTEL() : SPIRVValue(OC) {}
+  SPIRVSpecConstantCapabilitiesINTEL() : SPIRVValue(OC), NumWords() {}
 
   std::vector<SPIRVWord> getCapabilities() const { return Capabilities; }
   bool matchesDevice() {

lib/SPIRV/libSPIRV/SPIRVModule.cpp

@@ -2241,7 +2241,7 @@ spv_ostream &operator<<(spv_ostream &O, SPIRVModule &M) {
 
   for (auto &I : M.getConditionalExtensions()) {
     auto Cond = I.first;
-    auto Ext = I.second;
+    const auto &Ext = I.second;
     assert(!Ext.empty() && "Invalid conditional extension");
     O << SPIRVConditionalExtensionINTEL(&M, Cond, Ext);
   }