Abort on error instead of asserting 0

Let the translator abort on error instead of calling `assert(0)`.
This makes the error behavior consistent across debug and release
builds, and allows us to write negative tests for the translator.

Author: svenvh

lib/SPIRV/libSPIRV/SPIRVDebug.cpp

@@ -42,5 +42,5 @@
 using namespace SPIRV;
 
 bool SPIRV::SPIRVDbgEnable = false;
-bool SPIRV::SPIRVDbgAssertOnError = true;
+bool SPIRV::SPIRVDbgAbortOnError = true;
 bool SPIRV::SPIRVDbgErrorMsgIncludesSourceInfo = true;

lib/SPIRV/libSPIRV/SPIRVDebug.h

@@ -63,7 +63,7 @@ extern bool SPIRVDbgEnable;
 extern bool SPIRVDbgErrorMsgIncludesSourceInfo;
 
 // Enable assert on error
-extern bool SPIRVDbgAssertOnError;
+extern bool SPIRVDbgAbortOnError;
 
 // Output stream for SPIRV debug information.
 inline spv_ostream &spvdbgs() {

lib/SPIRV/libSPIRV/SPIRVError.h

@@ -113,10 +113,10 @@ inline bool SPIRVErrorLog::checkError(bool Cond, SPIRVErrorCode ErrCode,
   if (SPIRVDbgErrorMsgIncludesSourceInfo)
     SS << " [Src: " << FileName << ":" << LineNo << " " << CondString << " ]";
   setError(ErrCode, SS.str());
-  if (SPIRVDbgAssertOnError) {
+  if (SPIRVDbgAbortOnError) {
     spvdbgs() << SS.str() << '\n';
     spvdbgs().flush();
-    assert(0);
+    abort();
   }
   return Cond;
 }