Skip to content

Commit 8a1139b

Browse files
Re-add ReadDir interception on macOS
This was disabled due to issues with address sanitizer, which appear to no longer exist. The effects of intercepting readdir are an important part of the test framework shim, so disabling that makes some tests unreliable. It would be better to disable address sanitizer in CI where it is found to be an issue rather than disable readdir interception.
1 parent 11f8921 commit 8a1139b

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

tests/framework/shim/unix_shim.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -397,8 +397,7 @@ struct Interposer {
397397
};
398398

399399
__attribute__((used)) static Interposer _interpose_opendir MACOS_ATTRIB = {VOIDP_CAST(my_opendir), VOIDP_CAST(opendir)};
400-
// don't intercept readdir as it crashes when using ASAN with macOS
401-
// __attribute__((used)) static Interposer _interpose_readdir MACOS_ATTRIB = {VOIDP_CAST(my_readdir), VOIDP_CAST(readdir)};
400+
__attribute__((used)) static Interposer _interpose_readdir MACOS_ATTRIB = {VOIDP_CAST(my_readdir), VOIDP_CAST(readdir)};
402401
__attribute__((used)) static Interposer _interpose_closedir MACOS_ATTRIB = {VOIDP_CAST(my_closedir), VOIDP_CAST(closedir)};
403402
__attribute__((used)) static Interposer _interpose_access MACOS_ATTRIB = {VOIDP_CAST(my_access), VOIDP_CAST(access)};
404403
__attribute__((used)) static Interposer _interpose_fopen MACOS_ATTRIB = {VOIDP_CAST(my_fopen), VOIDP_CAST(fopen)};

0 commit comments

Comments
 (0)