Commit 8b5249c
fix call DestroyInstance after loader_platform_close_library
Found that vkcts crash after "Get real path to layer & driver
binaries : 77ccbe4" merged
into vullan-loader.
The root cause of crash is icd.so lib has been closed before
DestroyInstance called in loader free path when icd instance
has been created and oom in layer.
eg. fpCreateInstance success but table->populate oom in wsi.
TRY_LOG(fpCreateInstance(&modified_info, pAllocator, pInstance)
, "Failed to create the instance");
TRY_LOG_CALL(table->populate(*pInstance, fpGetInstanceProcAddr,
api_version));
So we need to defer close icd lib until DestroyInstance done.
Fix case: dEQP-VK.api.device_init.create_instance_device_
intentional_alloc_fail.basic
Signed-off-by: Ryan Zhang <ryan.zhang@nxp.com>1 parent 655909f commit 8b5249c
1 file changed
+1
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
735 | 735 | | |
736 | 736 | | |
737 | 737 | | |
738 | | - | |
739 | 738 | | |
740 | 739 | | |
741 | 740 | | |
| |||
755 | 754 | | |
756 | 755 | | |
757 | 756 | | |
| 757 | + | |
758 | 758 | | |
759 | 759 | | |
760 | 760 | | |
| |||
0 commit comments