Skip to content

Commit c913466

Browse files
jpr42charles-lunarg
authored andcommitted
ci: Test UBSAN + ASAN
Currently UBSAN isn't being tested on CI
1 parent 40390cd commit c913466

File tree

3 files changed

+4
-15
lines changed

3 files changed

+4
-15
lines changed

.github/workflows/build.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,6 @@ jobs:
5959
cmakeVersion: 3.22.1
6060
- run: sudo apt update
6161
- run: sudo apt install --yes --no-install-recommends libwayland-dev libxrandr-dev
62-
# This is to combat a bug when using 6.6 linux kernels with thread/address sanitizer
63-
# https://github.com/google/sanitizers/issues/1716
64-
- run: sudo sysctl vm.mmap_rnd_bits=28
6562
- run: |
6663
cmake -S. -B build \
6764
-D CMAKE_BUILD_TYPE=${{ matrix.config }} \

loader/CMakeLists.txt

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -430,17 +430,13 @@ else()
430430
set_target_properties(vulkan PROPERTIES OUTPUT_NAME ${API_TYPE})
431431

432432
if (LOADER_ENABLE_ADDRESS_SANITIZER)
433-
target_compile_options(vulkan PUBLIC -fsanitize=address)
434-
target_link_options(vulkan PUBLIC -fsanitize=address)
433+
target_compile_options(vulkan PUBLIC -fsanitize=address,undefined)
434+
target_link_options(vulkan PUBLIC -fsanitize=address,undefined)
435435
endif()
436436
if (LOADER_ENABLE_THREAD_SANITIZER)
437437
target_compile_options(vulkan PUBLIC -fsanitize=thread)
438438
target_link_options(vulkan PUBLIC -fsanitize=thread)
439439
endif()
440-
if (LOADER_ENABLE_UNDEFINED_BEHAVIOR_SANITIZER)
441-
target_compile_options(vulkan PUBLIC -fsanitize=undefined)
442-
target_link_options(vulkan PUBLIC -fsanitize=undefined)
443-
endif()
444440

445441
if(APPLE)
446442
find_library(COREFOUNDATION_LIBRARY NAMES CoreFoundation)

tests/framework/CMakeLists.txt

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,19 +30,15 @@ target_include_directories(testing_framework_util PUBLIC "${CMAKE_CURRENT_SOURCE
3030

3131
if (UNIX)
3232
if (LOADER_ENABLE_ADDRESS_SANITIZER)
33-
target_compile_options(testing_framework_util PUBLIC -fsanitize=address)
34-
target_link_options(testing_framework_util PUBLIC -fsanitize=address)
33+
target_compile_options(testing_framework_util PUBLIC -fsanitize=address,undefined)
34+
target_link_options(testing_framework_util PUBLIC -fsanitize=address,undefined)
3535
endif()
3636
if (LOADER_ENABLE_THREAD_SANITIZER)
3737
target_compile_options(testing_framework_util PUBLIC -fsanitize=thread)
3838
target_link_options(testing_framework_util PUBLIC -fsanitize=thread)
3939
target_compile_options(gtest PUBLIC -fsanitize=thread)
4040
target_link_options(gtest PUBLIC -fsanitize=thread)
4141
endif()
42-
if (LOADER_ENABLE_UNDEFINED_BEHAVIOR_SANITIZER)
43-
target_compile_options(testing_framework_util PUBLIC -fsanitize=undefined)
44-
target_link_options(testing_framework_util PUBLIC -fsanitize=undefined)
45-
endif()
4642
endif()
4743

4844
if (MSVC)

0 commit comments

Comments
 (0)