Skip to content

Commit 4e46f43

Browse files
committed
Address 1st round of PR comments
* Fixed issues highlighted by reviewers * Fixed copyright headers Signed-off-by: Aron Virginas-Tar <[email protected]>
1 parent 06ce09f commit 4e46f43

File tree

10 files changed

+694
-673
lines changed

10 files changed

+694
-673
lines changed

framework/vulkan_type_mapping.h

Lines changed: 31 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
/* Copyright (c) 2024, NVIDIA CORPORATION. All rights reserved.
2-
* Copyright (c) 2025, Arm Limited and Contributors
1+
/* Copyright (c) 2025, Arm Limited and Contributors
2+
* Copyright (c) 2024, NVIDIA CORPORATION. All rights reserved.
33
*
44
* SPDX-License-Identifier: Apache-2.0
55
*
@@ -49,6 +49,12 @@ struct HPPType<VkCommandBuffer>
4949
using Type = vk::CommandBuffer;
5050
};
5151

52+
template <>
53+
struct HPPType<VkDataGraphPipelineSessionARM>
54+
{
55+
using Type = vk::DataGraphPipelineSessionARM;
56+
};
57+
5258
template <>
5359
struct HPPType<VkDevice>
5460
{
@@ -73,6 +79,18 @@ struct HPPType<VkImageView>
7379
using Type = vk::ImageView;
7480
};
7581

82+
template <>
83+
struct HPPType<VkPipeline>
84+
{
85+
using Type = vk::Pipeline;
86+
};
87+
88+
template <>
89+
struct HPPType<VkPipelineLayout>
90+
{
91+
using Type = vk::PipelineLayout;
92+
};
93+
7694
template <>
7795
struct HPPType<VkRenderPass>
7896
{
@@ -86,15 +104,21 @@ struct HPPType<VkSampler>
86104
};
87105

88106
template <>
89-
struct HPPType<VkPipeline>
107+
struct HPPType<VkTensorARM>
90108
{
91-
using Type = vk::Pipeline;
109+
using Type = vk::TensorARM;
92110
};
93111

94112
template <>
95-
struct HPPType<VkPipelineLayout>
113+
struct HPPType<VkTensorCreateInfoARM>
96114
{
97-
using Type = vk::PipelineLayout;
115+
using Type = vk::TensorCreateInfoARM;
116+
};
117+
118+
template <>
119+
struct HPPType<VkTensorViewARM>
120+
{
121+
using Type = vk::TensorViewARM;
98122
};
99123
} // namespace detail
100124

@@ -113,4 +137,4 @@ struct VulkanTypeMapping<vkb::BindingType::C, T>
113137
using Type = typename detail::HPPType<T>::Type;
114138
};
115139

116-
} // namespace vkb
140+
} // namespace vkb

samples/extensions/README.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
////
2-
- Copyright (c) 2021-2024, The Khronos Group
32
- Copyright (c) 2025, Arm Limited and Contributors
3+
- Copyright (c) 2021-2024, The Khronos Group
44
-
55
- SPDX-License-Identifier: Apache-2.0
66
-

samples/extensions/tensor_and_data_graph/simple_tensor_and_data_graph/README.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ set_layout_create_info.pBindings = layout_bindings.data();
9797
VK_CHECK(vkCreateDescriptorSetLayout(get_device().get_handle(),
9898
&set_layout_create_info,
9999
nullptr,
100-
descriptor_set_layout));
100+
&descriptor_set_layout));
101101
102102
// Create pipeline layout
103103
VkPipelineLayoutCreateInfo pipeline_layout_create_info

samples/extensions/tensor_and_data_graph/simple_tensor_and_data_graph/images/flow.dot

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// Copyright (c) 2025, Arm Limited and Contributors
12
digraph D {
23

34
{

samples/extensions/tensor_and_data_graph/simple_tensor_and_data_graph/images/flow.svg

Lines changed: 3 additions & 0 deletions
Loading

samples/extensions/tensor_and_data_graph/simple_tensor_and_data_graph/images/network.svg

Lines changed: 3 additions & 0 deletions
Loading

samples/extensions/tensor_and_data_graph/simple_tensor_and_data_graph/images/pipeline_interface.svg

Lines changed: 3 additions & 0 deletions
Loading

samples/extensions/tensor_and_data_graph/simple_tensor_and_data_graph/simple_tensor_and_data_graph.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,6 @@ bool SimpleTensorAndDataGraph::prepare(const vkb::ApplicationOptions &options)
7777
return false;
7878
}
7979

80-
volkLoadDevice(get_device().get_handle());
81-
8280
// We use the GUI framework for labels on the visualization
8381
create_gui(*window, &get_stats());
8482

0 commit comments

Comments
 (0)