Make image in loop a referene

SaschaWillems · SaschaWillems · commit 12c6467bc6cc · 2025-11-22T13:55:24.000+01:00
diff --git a/attachments/07_image_views.cpp b/attachments/07_image_views.cpp
@@ -277,7 +277,7 @@ class HelloTriangleApplication
 		assert(swapChainImageViews.empty());
 
 		vk::ImageViewCreateInfo imageViewCreateInfo{.viewType = vk::ImageViewType::e2D, .format = swapChainSurfaceFormat.format, .subresourceRange = {vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1}};
-		for (auto image : swapChainImages)
+		for (auto& image : swapChainImages)
 		{
 			imageViewCreateInfo.image = image;
 			swapChainImageViews.emplace_back(device, imageViewCreateInfo);
diff --git a/attachments/08_graphics_pipeline.cpp b/attachments/08_graphics_pipeline.cpp
@@ -278,7 +278,7 @@ class HelloTriangleApplication
 		assert(swapChainImageViews.empty());
 
 		vk::ImageViewCreateInfo imageViewCreateInfo{.viewType = vk::ImageViewType::e2D, .format = swapChainSurfaceFormat.format, .subresourceRange = {vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1}};
-		for (auto image : swapChainImages)
+		for (auto& image : swapChainImages)
 		{
 			imageViewCreateInfo.image = image;
 			swapChainImageViews.emplace_back(device, imageViewCreateInfo);
diff --git a/attachments/09_shader_modules.cpp b/attachments/09_shader_modules.cpp
@@ -288,7 +288,7 @@ class HelloTriangleApplication
 		assert(swapChainImageViews.empty());
 
 		vk::ImageViewCreateInfo imageViewCreateInfo{.viewType = vk::ImageViewType::e2D, .format = swapChainSurfaceFormat.format, .subresourceRange = {vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1}};
-		for (auto image : swapChainImages)
+		for (auto& image : swapChainImages)
 		{
 			imageViewCreateInfo.image = image;
 			swapChainImageViews.emplace_back(device, imageViewCreateInfo);
diff --git a/attachments/10_fixed_functions.cpp b/attachments/10_fixed_functions.cpp
@@ -290,7 +290,7 @@ class HelloTriangleApplication
 		assert(swapChainImageViews.empty());
 
 		vk::ImageViewCreateInfo imageViewCreateInfo{.viewType = vk::ImageViewType::e2D, .format = swapChainSurfaceFormat.format, .subresourceRange = {vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1}};
-		for (auto image : swapChainImages)
+		for (auto& image : swapChainImages)
 		{
 			imageViewCreateInfo.image = image;
 			swapChainImageViews.emplace_back(device, imageViewCreateInfo);
diff --git a/attachments/12_graphics_pipeline_complete.cpp b/attachments/12_graphics_pipeline_complete.cpp
@@ -291,7 +291,7 @@ class HelloTriangleApplication
 		assert(swapChainImageViews.empty());
 
 		vk::ImageViewCreateInfo imageViewCreateInfo{.viewType = vk::ImageViewType::e2D, .format = swapChainSurfaceFormat.format, .subresourceRange = {vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1}};
-		for (auto image : swapChainImages)
+		for (auto& image : swapChainImages)
 		{
 			imageViewCreateInfo.image = image;
 			swapChainImageViews.emplace_back(device, imageViewCreateInfo);
diff --git a/attachments/14_command_buffers.cpp b/attachments/14_command_buffers.cpp
@@ -295,7 +295,7 @@ class HelloTriangleApplication
 		assert(swapChainImageViews.empty());
 
 		vk::ImageViewCreateInfo imageViewCreateInfo{.viewType = vk::ImageViewType::e2D, .format = swapChainSurfaceFormat.format, .subresourceRange = {vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1}};
-		for (auto image : swapChainImages)
+		for (auto& image : swapChainImages)
 		{
 			imageViewCreateInfo.image = image;
 			swapChainImageViews.emplace_back(device, imageViewCreateInfo);
diff --git a/attachments/16_frames_in_flight.cpp b/attachments/16_frames_in_flight.cpp
@@ -308,7 +308,7 @@ class HelloTriangleApplication
 		assert(swapChainImageViews.empty());
 
 		vk::ImageViewCreateInfo imageViewCreateInfo{.viewType = vk::ImageViewType::e2D, .format = swapChainSurfaceFormat.format, .subresourceRange = {vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1}};
-		for (auto image : swapChainImages)
+		for (auto& image : swapChainImages)
 		{
 			imageViewCreateInfo.image = image;
 			swapChainImageViews.emplace_back(device, imageViewCreateInfo);
diff --git a/attachments/17_swap_chain_recreation.cpp b/attachments/17_swap_chain_recreation.cpp
@@ -341,7 +341,7 @@ class HelloTriangleApplication
 		assert(swapChainImageViews.empty());
 
 		vk::ImageViewCreateInfo imageViewCreateInfo{.viewType = vk::ImageViewType::e2D, .format = swapChainSurfaceFormat.format, .subresourceRange = {vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1}};
-		for (auto image : swapChainImages)
+		for (auto& image : swapChainImages)
 		{
 			imageViewCreateInfo.image = image;
 			swapChainImageViews.emplace_back(device, imageViewCreateInfo);
diff --git a/attachments/19_vertex_buffer.cpp b/attachments/19_vertex_buffer.cpp
@@ -362,7 +362,7 @@ class HelloTriangleApplication
 		assert(swapChainImageViews.empty());
 
 		vk::ImageViewCreateInfo imageViewCreateInfo{.viewType = vk::ImageViewType::e2D, .format = swapChainSurfaceFormat.format, .subresourceRange = {vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1}};
-		for (auto image : swapChainImages)
+		for (auto& image : swapChainImages)
 		{
 			imageViewCreateInfo.image = image;
 			swapChainImageViews.emplace_back(device, imageViewCreateInfo);
diff --git a/attachments/20_staging_buffer.cpp b/attachments/20_staging_buffer.cpp
@@ -362,7 +362,7 @@ class HelloTriangleApplication
 		assert(swapChainImageViews.empty());
 
 		vk::ImageViewCreateInfo imageViewCreateInfo{.viewType = vk::ImageViewType::e2D, .format = swapChainSurfaceFormat.format, .subresourceRange = {vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1}};
-		for (auto image : swapChainImages)
+		for (auto& image : swapChainImages)
 		{
 			imageViewCreateInfo.image = image;
 			swapChainImageViews.emplace_back(device, imageViewCreateInfo);
diff --git a/attachments/21_index_buffer.cpp b/attachments/21_index_buffer.cpp
@@ -369,7 +369,7 @@ class HelloTriangleApplication
 		assert(swapChainImageViews.empty());
 
 		vk::ImageViewCreateInfo imageViewCreateInfo{.viewType = vk::ImageViewType::e2D, .format = swapChainSurfaceFormat.format, .subresourceRange = {vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1}};
-		for (auto image : swapChainImages)
+		for (auto& image : swapChainImages)
 		{
 			imageViewCreateInfo.image = image;
 			swapChainImageViews.emplace_back(device, imageViewCreateInfo);
diff --git a/attachments/22_descriptor_layout.cpp b/attachments/22_descriptor_layout.cpp
@@ -387,7 +387,7 @@ class HelloTriangleApplication
 		assert(swapChainImageViews.empty());
 
 		vk::ImageViewCreateInfo imageViewCreateInfo{.viewType = vk::ImageViewType::e2D, .format = swapChainSurfaceFormat.format, .subresourceRange = {vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1}};
-		for (auto image : swapChainImages)
+		for (auto& image : swapChainImages)
 		{
 			imageViewCreateInfo.image = image;
 			swapChainImageViews.emplace_back(device, imageViewCreateInfo);
diff --git a/attachments/23_descriptor_sets.cpp b/attachments/23_descriptor_sets.cpp
@@ -392,7 +392,7 @@ class HelloTriangleApplication
 		assert(swapChainImageViews.empty());
 
 		vk::ImageViewCreateInfo imageViewCreateInfo{.viewType = vk::ImageViewType::e2D, .format = swapChainSurfaceFormat.format, .subresourceRange = {vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1}};
-		for (auto image : swapChainImages)
+		for (auto& image : swapChainImages)
 		{
 			imageViewCreateInfo.image = image;
 			swapChainImageViews.emplace_back(device, imageViewCreateInfo);
diff --git a/attachments/24_texture_image.cpp b/attachments/24_texture_image.cpp
@@ -399,7 +399,7 @@ class HelloTriangleApplication
 		assert(swapChainImageViews.empty());
 
 		vk::ImageViewCreateInfo imageViewCreateInfo{.viewType = vk::ImageViewType::e2D, .format = swapChainSurfaceFormat.format, .subresourceRange = {vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1}};
-		for (auto image : swapChainImages)
+		for (auto& image : swapChainImages)
 		{
 			imageViewCreateInfo.image = image;
 			swapChainImageViews.emplace_back(device, imageViewCreateInfo);
diff --git a/attachments/25_sampler.cpp b/attachments/25_sampler.cpp
@@ -402,7 +402,7 @@ class HelloTriangleApplication
 		assert(swapChainImageViews.empty());
 
 		vk::ImageViewCreateInfo imageViewCreateInfo{.viewType = vk::ImageViewType::e2D, .format = swapChainSurfaceFormat.format, .subresourceRange = {vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1}};
-		for (auto image : swapChainImages)
+		for (auto& image : swapChainImages)
 		{
 			imageViewCreateInfo.image = image;
 			swapChainImageViews.emplace_back(device, imageViewCreateInfo);
diff --git a/attachments/26_texture_mapping.cpp b/attachments/26_texture_mapping.cpp
@@ -404,7 +404,7 @@ class HelloTriangleApplication
 		assert(swapChainImageViews.empty());
 
 		vk::ImageViewCreateInfo imageViewCreateInfo{.viewType = vk::ImageViewType::e2D, .format = swapChainSurfaceFormat.format, .subresourceRange = {vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1}};
-		for (auto image : swapChainImages)
+		for (auto& image : swapChainImages)
 		{
 			imageViewCreateInfo.image = image;
 			swapChainImageViews.emplace_back(device, imageViewCreateInfo);
diff --git a/attachments/27_depth_buffering.cpp b/attachments/27_depth_buffering.cpp
@@ -420,7 +420,7 @@ class HelloTriangleApplication
 		    .viewType         = vk::ImageViewType::e2D,
 		    .format           = swapChainSurfaceFormat.format,
 		    .subresourceRange = {vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1}};
-		for (auto image : swapChainImages)
+		for (auto& image : swapChainImages)
 		{
 			imageViewCreateInfo.image = image;
 			swapChainImageViews.emplace_back(device, imageViewCreateInfo);
diff --git a/attachments/28_model_loading.cpp b/attachments/28_model_loading.cpp
@@ -429,7 +429,7 @@ class HelloTriangleApplication
 		    .viewType         = vk::ImageViewType::e2D,
 		    .format           = swapChainSurfaceFormat.format,
 		    .subresourceRange = {vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1}};
-		for (auto image : swapChainImages)
+		for (auto& image : swapChainImages)
 		{
 			imageViewCreateInfo.image = image;
 			swapChainImageViews.emplace_back(device, imageViewCreateInfo);
diff --git a/attachments/29_mipmapping.cpp b/attachments/29_mipmapping.cpp
@@ -429,7 +429,7 @@ class HelloTriangleApplication
 		    .viewType         = vk::ImageViewType::e2D,
 		    .format           = swapChainSurfaceFormat.format,
 		    .subresourceRange = {vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1}};
-		for (auto image : swapChainImages)
+		for (auto& image : swapChainImages)
 		{
 			imageViewCreateInfo.image = image;
 			swapChainImageViews.emplace_back(device, imageViewCreateInfo);
diff --git a/attachments/30_multisampling.cpp b/attachments/30_multisampling.cpp
@@ -438,7 +438,7 @@ class HelloTriangleApplication
 		    .viewType         = vk::ImageViewType::e2D,
 		    .format           = swapChainSurfaceFormat.format,
 		    .subresourceRange = {vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1}};
-		for (auto image : swapChainImages)
+		for (auto& image : swapChainImages)
 		{
 			imageViewCreateInfo.image = image;
 			swapChainImageViews.emplace_back(device, imageViewCreateInfo);
diff --git a/attachments/31_compute_shader.cpp b/attachments/31_compute_shader.cpp
@@ -413,7 +413,7 @@ class ComputeShaderApplication
 		    .format           = swapChainSurfaceFormat.format,
 		    .components       = {vk::ComponentSwizzle::eIdentity, vk::ComponentSwizzle::eIdentity, vk::ComponentSwizzle::eIdentity, vk::ComponentSwizzle::eIdentity},
 		    .subresourceRange = {vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1}};
-		for (auto image : swapChainImages)
+		for (auto& image : swapChainImages)
 		{
 			imageViewCreateInfo.image = image;
 			swapChainImageViews.emplace_back(device, imageViewCreateInfo);
diff --git a/attachments/32_ecosystem_utilities.cpp b/attachments/32_ecosystem_utilities.cpp
@@ -568,7 +568,7 @@ class HelloTriangleApplication
 		    .viewType         = vk::ImageViewType::e2D,
 		    .format           = swapChainSurfaceFormat.format,
 		    .subresourceRange = {vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1}};
-		for (auto image : swapChainImages)
+		for (auto& image : swapChainImages)
 		{
 			imageViewCreateInfo.image = image;
 			swapChainImageViews.emplace_back(device, imageViewCreateInfo);
diff --git a/attachments/35_gltf_ktx.cpp b/attachments/35_gltf_ktx.cpp
@@ -639,7 +639,7 @@ class VulkanApplication
 		    .viewType         = vk::ImageViewType::e2D,
 		    .format           = swapChainSurfaceFormat.format,
 		    .subresourceRange = {vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1}};
-		for (auto image : swapChainImages)
+		for (auto& image : swapChainImages)
 		{
 			imageViewCreateInfo.image = image;
 			swapChainImageViews.emplace_back(device, imageViewCreateInfo);
diff --git a/attachments/36_multiple_objects.cpp b/attachments/36_multiple_objects.cpp
@@ -712,7 +712,7 @@ class VulkanApplication
 		    .viewType         = vk::ImageViewType::e2D,
 		    .format           = swapChainSurfaceFormat.format,
 		    .subresourceRange = {vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1}};
-		for (auto image : swapChainImages)
+		for (auto& image : swapChainImages)
 		{
 			imageViewCreateInfo.image = image;
 			swapChainImageViews.emplace_back(device, imageViewCreateInfo);
diff --git a/attachments/37_multithreading.cpp b/attachments/37_multithreading.cpp
@@ -704,7 +704,7 @@ class MultithreadedApplication
 		    .format           = swapChainSurfaceFormat.format,
 		    .components       = {vk::ComponentSwizzle::eIdentity, vk::ComponentSwizzle::eIdentity, vk::ComponentSwizzle::eIdentity, vk::ComponentSwizzle::eIdentity},
 		    .subresourceRange = {vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1}};
-		for (auto image : swapChainImages)
+		for (auto& image : swapChainImages)
 		{
 			imageViewCreateInfo.image = image;
 			swapChainImageViews.emplace_back(device, imageViewCreateInfo);
diff --git a/attachments/38_ray_tracing.cpp b/attachments/38_ray_tracing.cpp
@@ -539,7 +539,7 @@ class VulkanRaytracingApplication
 		    .viewType         = vk::ImageViewType::e2D,
 		    .format           = swapChainImageFormat,
 		    .subresourceRange = {vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1}};
-		for (auto image : swapChainImages)
+		for (auto& image : swapChainImages)
 		{
 			imageViewCreateInfo.image = image;
 			swapChainImageViews.emplace_back(device, imageViewCreateInfo);

Original file line number	Diff line number	Diff line change
`@@ -277,7 +277,7 @@ class HelloTriangleApplication`
`277`	`277`	`assert(swapChainImageViews.empty());`
`278`	`278`
`279`	`279`	`vk::ImageViewCreateInfo imageViewCreateInfo{.viewType = vk::ImageViewType::e2D, .format = swapChainSurfaceFormat.format, .subresourceRange = {vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1}};`
`280`		`- for (auto image : swapChainImages)`
	`280`	`+ for (auto& image : swapChainImages)`
`281`	`281`	`{`
`282`	`282`	`imageViewCreateInfo.image = image;`
`283`	`283`	`swapChainImageViews.emplace_back(device, imageViewCreateInfo);`
Original file line number	Diff line number	Diff line change
`@@ -278,7 +278,7 @@ class HelloTriangleApplication`
`278`	`278`	`assert(swapChainImageViews.empty());`
`279`	`279`
`280`	`280`	`vk::ImageViewCreateInfo imageViewCreateInfo{.viewType = vk::ImageViewType::e2D, .format = swapChainSurfaceFormat.format, .subresourceRange = {vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1}};`
`281`		`- for (auto image : swapChainImages)`
	`281`	`+ for (auto& image : swapChainImages)`
`282`	`282`	`{`
`283`	`283`	`imageViewCreateInfo.image = image;`
`284`	`284`	`swapChainImageViews.emplace_back(device, imageViewCreateInfo);`
Original file line number	Diff line number	Diff line change
`@@ -288,7 +288,7 @@ class HelloTriangleApplication`
`288`	`288`	`assert(swapChainImageViews.empty());`
`289`	`289`
`290`	`290`	`vk::ImageViewCreateInfo imageViewCreateInfo{.viewType = vk::ImageViewType::e2D, .format = swapChainSurfaceFormat.format, .subresourceRange = {vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1}};`
`291`		`- for (auto image : swapChainImages)`
	`291`	`+ for (auto& image : swapChainImages)`
`292`	`292`	`{`
`293`	`293`	`imageViewCreateInfo.image = image;`
`294`	`294`	`swapChainImageViews.emplace_back(device, imageViewCreateInfo);`
Original file line number	Diff line number	Diff line change
`@@ -290,7 +290,7 @@ class HelloTriangleApplication`
`290`	`290`	`assert(swapChainImageViews.empty());`
`291`	`291`
`292`	`292`	`vk::ImageViewCreateInfo imageViewCreateInfo{.viewType = vk::ImageViewType::e2D, .format = swapChainSurfaceFormat.format, .subresourceRange = {vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1}};`
`293`		`- for (auto image : swapChainImages)`
	`293`	`+ for (auto& image : swapChainImages)`
`294`	`294`	`{`
`295`	`295`	`imageViewCreateInfo.image = image;`
`296`	`296`	`swapChainImageViews.emplace_back(device, imageViewCreateInfo);`
Original file line number	Diff line number	Diff line change
`@@ -291,7 +291,7 @@ class HelloTriangleApplication`
`291`	`291`	`assert(swapChainImageViews.empty());`
`292`	`292`
`293`	`293`	`vk::ImageViewCreateInfo imageViewCreateInfo{.viewType = vk::ImageViewType::e2D, .format = swapChainSurfaceFormat.format, .subresourceRange = {vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1}};`
`294`		`- for (auto image : swapChainImages)`
	`294`	`+ for (auto& image : swapChainImages)`
`295`	`295`	`{`
`296`	`296`	`imageViewCreateInfo.image = image;`
`297`	`297`	`swapChainImageViews.emplace_back(device, imageViewCreateInfo);`
Original file line number	Diff line number	Diff line change
`@@ -295,7 +295,7 @@ class HelloTriangleApplication`
`295`	`295`	`assert(swapChainImageViews.empty());`
`296`	`296`
`297`	`297`	`vk::ImageViewCreateInfo imageViewCreateInfo{.viewType = vk::ImageViewType::e2D, .format = swapChainSurfaceFormat.format, .subresourceRange = {vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1}};`
`298`		`- for (auto image : swapChainImages)`
	`298`	`+ for (auto& image : swapChainImages)`
`299`	`299`	`{`
`300`	`300`	`imageViewCreateInfo.image = image;`
`301`	`301`	`swapChainImageViews.emplace_back(device, imageViewCreateInfo);`
Original file line number	Diff line number	Diff line change
`@@ -308,7 +308,7 @@ class HelloTriangleApplication`
`308`	`308`	`assert(swapChainImageViews.empty());`
`309`	`309`
`310`	`310`	`vk::ImageViewCreateInfo imageViewCreateInfo{.viewType = vk::ImageViewType::e2D, .format = swapChainSurfaceFormat.format, .subresourceRange = {vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1}};`
`311`		`- for (auto image : swapChainImages)`
	`311`	`+ for (auto& image : swapChainImages)`
`312`	`312`	`{`
`313`	`313`	`imageViewCreateInfo.image = image;`
`314`	`314`	`swapChainImageViews.emplace_back(device, imageViewCreateInfo);`
Original file line number	Diff line number	Diff line change
`@@ -341,7 +341,7 @@ class HelloTriangleApplication`
`341`	`341`	`assert(swapChainImageViews.empty());`
`342`	`342`
`343`	`343`	`vk::ImageViewCreateInfo imageViewCreateInfo{.viewType = vk::ImageViewType::e2D, .format = swapChainSurfaceFormat.format, .subresourceRange = {vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1}};`
`344`		`- for (auto image : swapChainImages)`
	`344`	`+ for (auto& image : swapChainImages)`
`345`	`345`	`{`
`346`	`346`	`imageViewCreateInfo.image = image;`
`347`	`347`	`swapChainImageViews.emplace_back(device, imageViewCreateInfo);`
Original file line number	Diff line number	Diff line change
`@@ -362,7 +362,7 @@ class HelloTriangleApplication`
`362`	`362`	`assert(swapChainImageViews.empty());`
`363`	`363`
`364`	`364`	`vk::ImageViewCreateInfo imageViewCreateInfo{.viewType = vk::ImageViewType::e2D, .format = swapChainSurfaceFormat.format, .subresourceRange = {vk::ImageAspectFlagBits::eColor, 0, 1, 0, 1}};`
`365`		`- for (auto image : swapChainImages)`
	`365`	`+ for (auto& image : swapChainImages)`
`366`	`366`	`{`
`367`	`367`	`imageViewCreateInfo.image = image;`
`368`	`368`	`swapChainImageViews.emplace_back(device, imageViewCreateInfo);`