everything runs and can close without validation warnings other than the semaphore. resizing still doesn't work. Next step is to get the parts of the engine to demonstrate things.

Author: gpx1000

attachments/simple_engine/engine.cpp

@@ -299,6 +299,16 @@ void Engine::HandleResize(int width, int height) {
     if (activeCamera) {
         activeCamera->SetAspectRatio(static_cast<float>(width) / static_cast<float>(height));
     }
+
+    // Notify the renderer that the framebuffer has been resized
+    if (renderer) {
+        renderer->SetFramebufferResized();
+    }
+
+    // Notify ImGui system about the resize
+    if (imguiSystem) {
+        imguiSystem->HandleResize(static_cast<uint32_t>(width), static_cast<uint32_t>(height));
+    }
 }
 
 #if PLATFORM_ANDROID

attachments/simple_engine/imgui_system.cpp

@@ -63,21 +63,6 @@ void ImGuiSystem::Cleanup() {
     if (renderer) {
         renderer->WaitIdle();
     }
-
-    // Clean up Vulkan resources - using RAII, these will be automatically destroyed
-    pipeline = nullptr;
-    pipelineLayout = nullptr;
-    descriptorSetLayout = nullptr;
-    fontSampler = nullptr;
-    fontView = nullptr;
-    fontImage = nullptr;
-    fontMemory = nullptr;
-    vertexBuffer = nullptr;
-    vertexBufferMemory = nullptr;
-    indexBuffer = nullptr;
-    indexBufferMemory = nullptr;
-    descriptorPool = nullptr;
-
     // Destroy ImGui context
     if (context) {
         ImGui::DestroyContext(context);
@@ -612,11 +597,13 @@ bool ImGuiSystem::createPipeline() {
         dynamicState.dynamicStateCount = static_cast<uint32_t>(dynamicStates.size());
         dynamicState.pDynamicStates = dynamicStates.data();
 
+        vk::Format depthFormat = renderer->findDepthFormat();
         // Create the graphics pipeline with dynamic rendering
         vk::PipelineRenderingCreateInfo renderingInfo;
         renderingInfo.colorAttachmentCount = 1;
         vk::Format colorFormat = renderer->GetSwapChainImageFormat(); // Get the actual swapchain format
         renderingInfo.pColorAttachmentFormats = &colorFormat;
+        renderingInfo.depthAttachmentFormat = depthFormat;
 
         vk::GraphicsPipelineCreateInfo pipelineInfo;
         pipelineInfo.stageCount = static_cast<uint32_t>(shaderStages.size());

attachments/simple_engine/renderer.h

@@ -215,6 +215,15 @@ class Renderer {
         return swapChainImageFormat;
     }
 
+    /**
+     * @brief Set the framebuffer resized flag.
+     * This should be called when the window is resized to trigger swap chain recreation.
+     */
+    void SetFramebufferResized() {
+        framebufferResized = true;
+    }
+    vk::Format findDepthFormat();
+
 private:
     // Platform
     Platform* platform = nullptr;
@@ -415,7 +424,6 @@ class Renderer {
 
     vk::raii::ImageView createImageView(vk::raii::Image& image, vk::Format format, vk::ImageAspectFlags aspectFlags);
     vk::Format findSupportedFormat(const std::vector<vk::Format>& candidates, vk::ImageTiling tiling, vk::FormatFeatureFlags features);
-    vk::Format findDepthFormat();
     bool hasStencilComponent(vk::Format format);
 
     std::vector<char> readFile(const std::string& filename);

attachments/simple_engine/renderer_core.cpp

@@ -3,6 +3,7 @@
 #include <iostream>
 #include <set>
 #include <cstring>
+#include <ranges>
 
 VULKAN_HPP_DEFAULT_DISPATCH_LOADER_DYNAMIC_STORAGE; // In a .cpp file
 
@@ -173,6 +174,14 @@ void Renderer::Cleanup() {
 
         // Wait for the device to be idle before cleaning up
         device.waitIdle();
+        for (auto& resources : entityResources | std::views::values) {
+            for (auto& memory : resources.uniformBuffersMemory) {
+                memory.unmapMemory();
+            }
+            resources.descriptorSets.clear();
+            resources.uniformBuffers.clear();
+            resources.uniformBuffersMemory.clear();
+        }
         std::cout << "Renderer cleanup completed." << std::endl;
         initialized = false;
     }

attachments/simple_engine/renderer_rendering.cpp

@@ -1,5 +1,6 @@
 #include "renderer.h"
 #include "imgui_system.h"
+#include "imgui/imgui.h"
 #include <fstream>
 #include <stdexcept>
 #include <array>
@@ -246,6 +247,23 @@ void Renderer::cleanupSwapChain() {
     // Clean up swap chain image views
     swapChainImageViews.clear();
 
+    // Clean up descriptor pool (this will automatically clean up descriptor sets)
+    descriptorPool = nullptr;
+
+    // Clean up pipelines
+    graphicsPipeline = nullptr;
+    pbrGraphicsPipeline = nullptr;
+    lightingPipeline = nullptr;
+
+    // Clean up pipeline layouts
+    pipelineLayout = nullptr;
+    pbrPipelineLayout = nullptr;
+    lightingPipelineLayout = nullptr;
+
+    // Clean up sync objects (they need to be recreated with new swap chain image count)
+    imageAvailableSemaphores.clear();
+    renderFinishedSemaphores.clear();
+
     // Clean up swap chain
     swapChain = nullptr;
 }
@@ -258,10 +276,15 @@ void Renderer::recreateSwapChain() {
     // Clean up old swap chain resources
     cleanupSwapChain();
 
-    // Recreate swap chain
+    // Recreate swap chain and related resources
     createSwapChain();
     createImageViews();
     createDepthResources();
+
+    // Recreate sync objects with correct sizing for new swap chain
+    createSyncObjects();
+
+    // Recreate descriptor pool and pipelines
     createDescriptorPool();
     createGraphicsPipeline();
     createPBRPipeline();
@@ -314,6 +337,12 @@ void Renderer::Render(const std::vector<Entity*>& entities, CameraComponent* cam
     // Check if the swap chain needs to be recreated
     if (result.first == vk::Result::eErrorOutOfDateKHR || result.first == vk::Result::eSuboptimalKHR || framebufferResized) {
         framebufferResized = false;
+
+        // If ImGui has started a frame, we need to end it properly before returning
+        if (imguiSystem) {
+            ImGui::EndFrame();
+        }
+
         recreateSwapChain();
         return;
     } else if (result.first != vk::Result::eSuccess) {