layers: Add VK_QCOM_multiview_per_view_viewports #11245
Merged
+97
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
CI Vulkan-ValidationLayers build queued with queue ID 594620. |
Collaborator
|
CI Vulkan-ValidationLayers build # 21878 running. |
Collaborator
|
CI Vulkan-ValidationLayers build # 21878 passed. |
artem-lunarg
reviewed
Dec 6, 2025
| if (!pipeline.IsDynamic(CB_DYNAMIC_STATE_SCISSOR) && !pipeline.IsDynamic(CB_DYNAMIC_STATE_SCISSOR_WITH_COUNT)) { | ||
| for (uint32_t i = 0; i < rp_state.create_info.subpassCount; i++) { | ||
| const uint32_t view_mask = rp_state.create_info.pSubpasses[i].viewMask; | ||
| const uint32_t msb = (uint32_t)MostSignificantBit(view_mask); |
Contributor
There was a problem hiding this comment.
just in case observation: this code assumes that view_mask can't be 0, otherwise msb would be uint32_max and will report confusing error.
Contributor
Author
There was a problem hiding this comment.
ya, let me update that, good catch
Contributor
Author
There was a problem hiding this comment.
ok, looked, I added rp_state->has_multiview_enabled which if true, then zero is not allowed and should be an error to my knowledge
artem-lunarg
approved these changes
Dec 6, 2025
spencer-lunarg
force-pushed
the
spencer-lunarg-qcom-multiview
branch
from
5d9b634 to
5f28f2d
Compare
Collaborator
|
CI Vulkan-ValidationLayers build queued with queue ID 595075. |
Collaborator
|
CI Vulkan-ValidationLayers build # 21882 running. |
Collaborator
|
CI Vulkan-ValidationLayers build # 21882 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds
VK_QCOM_multiview_per_view_viewportsVUsthere should be dynamic rendering VUs, but waiting on https://gitlab.khronos.org/vulkan/vulkan/-/merge_requests/7892 to add them