Skip to content

Commit 8325d16

Browse files
committed
Remove MAX_COLOR_ATTACHMENTS_WITH_ACTIVE_PIXEL_LOCAL_STORAGE enum.
Remove this enum from the WEBGL_shader_pixel_local_storage extension, and renumber the remaining enums, both of which have already been done in the underlying ANGLE extension. Remove the use of this enum from the pixel local storage CTS test as well. The new test passes on Chromium with all of these changes made. Associated with https://anglebug.com/40096838 .
1 parent 62e1b77 commit 8325d16

File tree

2 files changed

+16
-20
lines changed

2 files changed

+16
-20
lines changed

extensions/WEBGL_shader_pixel_local_storage/extension.xml

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -68,20 +68,19 @@
6868
[Exposed=(Window,Worker), LegacyNoInterfaceObject]
6969
interface WEBGL_shader_pixel_local_storage {
7070
const GLenum MAX_PIXEL_LOCAL_STORAGE_PLANES_WEBGL = 0x96E0;
71-
const GLenum MAX_COLOR_ATTACHMENTS_WITH_ACTIVE_PIXEL_LOCAL_STORAGE_WEBGL = 0x96E1;
72-
const GLenum MAX_COMBINED_DRAW_BUFFERS_AND_PIXEL_LOCAL_STORAGE_PLANES_WEBGL = 0x96E2;
73-
const GLenum PIXEL_LOCAL_STORAGE_ACTIVE_PLANES_WEBGL = 0x96E3;
74-
const GLenum LOAD_OP_ZERO_WEBGL = 0x96E4;
75-
const GLenum LOAD_OP_CLEAR_WEBGL = 0x96E5;
76-
const GLenum LOAD_OP_LOAD_WEBGL = 0x96E6;
77-
const GLenum STORE_OP_STORE_WEBGL = 0x96E7;
78-
const GLenum PIXEL_LOCAL_FORMAT_WEBGL = 0x96E8;
79-
const GLenum PIXEL_LOCAL_TEXTURE_NAME_WEBGL = 0x96E9;
80-
const GLenum PIXEL_LOCAL_TEXTURE_LEVEL_WEBGL = 0x96EA;
81-
const GLenum PIXEL_LOCAL_TEXTURE_LAYER_WEBGL = 0x96EB;
82-
const GLenum PIXEL_LOCAL_CLEAR_VALUE_FLOAT_WEBGL = 0x96EC;
83-
const GLenum PIXEL_LOCAL_CLEAR_VALUE_INT_WEBGL = 0x96ED;
84-
const GLenum PIXEL_LOCAL_CLEAR_VALUE_UNSIGNED_INT_WEBGL = 0x96EE;
71+
const GLenum MAX_COMBINED_DRAW_BUFFERS_AND_PIXEL_LOCAL_STORAGE_PLANES_WEBGL = 0x96E1;
72+
const GLenum PIXEL_LOCAL_STORAGE_ACTIVE_PLANES_WEBGL = 0x96E2;
73+
const GLenum LOAD_OP_ZERO_WEBGL = 0x96E3;
74+
const GLenum LOAD_OP_CLEAR_WEBGL = 0x96E4;
75+
const GLenum LOAD_OP_LOAD_WEBGL = 0x96E5;
76+
const GLenum STORE_OP_STORE_WEBGL = 0x96E6;
77+
const GLenum PIXEL_LOCAL_FORMAT_WEBGL = 0x96E7;
78+
const GLenum PIXEL_LOCAL_TEXTURE_NAME_WEBGL = 0x96E8;
79+
const GLenum PIXEL_LOCAL_TEXTURE_LEVEL_WEBGL = 0x96E9;
80+
const GLenum PIXEL_LOCAL_TEXTURE_LAYER_WEBGL = 0x96EA;
81+
const GLenum PIXEL_LOCAL_CLEAR_VALUE_FLOAT_WEBGL = 0x96EB;
82+
const GLenum PIXEL_LOCAL_CLEAR_VALUE_INT_WEBGL = 0x96EC;
83+
const GLenum PIXEL_LOCAL_CLEAR_VALUE_UNSIGNED_INT_WEBGL = 0x96ED;
8584
GLboolean isCoherent();
8685
undefined framebufferTexturePixelLocalStorageWEBGL(GLint plane,
8786
WebGLTexture? texture,
@@ -221,7 +220,6 @@ interface WEBGL_shader_pixel_local_storage {
221220
<table>
222221
<tr><th>pname</th><th>returned type</th></tr>
223222
<tr><td>MAX_PIXEL_LOCAL_STORAGE_PLANES_WEBGL</td><td>GLint</td></tr>
224-
<tr><td>MAX_COLOR_ATTACHMENTS_WITH_ACTIVE_PIXEL_LOCAL_STORAGE_WEBGL</td><td>GLint</td></tr>
225223
<tr><td>MAX_COMBINED_DRAW_BUFFERS_AND_PIXEL_LOCAL_STORAGE_PLANES_WEBGL</td><td>GLint</td></tr>
226224
<tr><td>PIXEL_LOCAL_STORAGE_ACTIVE_PLANES_WEBGL</td><td>GLint</td></tr>
227225
</table>
@@ -282,5 +280,8 @@ interface WEBGL_shader_pixel_local_storage {
282280
<revision date="2023/09/08">
283281
<change>Changed srcOffset arguments to "unsigned long long" for Wasm.</change>
284282
</revision>
283+
<revision date="2025/03/24">
284+
<change>Removed MAX_COLOR_ATTACHMENTS_WITH_ACTIVE_PIXEL_LOCAL_STORAGE_WEBGL enum, which was removed from the underlying ANGLE extension.</change>
285+
</revision>
285286
</history>
286287
</draft>

sdk/tests/conformance2/extensions/webgl-shader-pixel-local-storage.html

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -120,8 +120,6 @@
120120
debug("\nVerify conformant implementation-dependent PLS limits.");
121121
window.MAX_PIXEL_LOCAL_STORAGE_PLANES =
122122
gl.getParameter(pls.MAX_PIXEL_LOCAL_STORAGE_PLANES_WEBGL);
123-
window.MAX_COLOR_ATTACHMENTS_WITH_ACTIVE_PIXEL_LOCAL_STORAGE =
124-
gl.getParameter(pls.MAX_COLOR_ATTACHMENTS_WITH_ACTIVE_PIXEL_LOCAL_STORAGE_WEBGL);
125123
window.MAX_COMBINED_DRAW_BUFFERS_AND_PIXEL_LOCAL_STORAGE_PLANES =
126124
gl.getParameter(pls.MAX_COMBINED_DRAW_BUFFERS_AND_PIXEL_LOCAL_STORAGE_PLANES_WEBGL);
127125
wtu.glErrorShouldBe(gl, gl.NONE, "Pixel local storage queries should be supported.");
@@ -131,14 +129,11 @@
131129

132130
// Table 6.X: Impementation Dependent Pixel Local Storage Limits.
133131
shouldBeTrue("MAX_PIXEL_LOCAL_STORAGE_PLANES >= 4");
134-
shouldBeTrue("MAX_COLOR_ATTACHMENTS_WITH_ACTIVE_PIXEL_LOCAL_STORAGE >= 0");
135132
shouldBeTrue("MAX_COMBINED_DRAW_BUFFERS_AND_PIXEL_LOCAL_STORAGE_PLANES >= 4");
136133

137134
// Logical deductions based on 6.X.
138135
shouldBeTrue(`MAX_COMBINED_DRAW_BUFFERS_AND_PIXEL_LOCAL_STORAGE_PLANES >=
139136
MAX_PIXEL_LOCAL_STORAGE_PLANES`);
140-
shouldBeTrue(`MAX_COMBINED_DRAW_BUFFERS_AND_PIXEL_LOCAL_STORAGE_PLANES >=
141-
MAX_COLOR_ATTACHMENTS_WITH_ACTIVE_PIXEL_LOCAL_STORAGE`);
142137
shouldBeTrue(`MAX_COLOR_ATTACHMENTS + MAX_PIXEL_LOCAL_STORAGE_PLANES >=
143138
MAX_COMBINED_DRAW_BUFFERS_AND_PIXEL_LOCAL_STORAGE_PLANES`);
144139
shouldBeTrue(`MAX_DRAW_BUFFERS + MAX_PIXEL_LOCAL_STORAGE_PLANES >=

0 commit comments

Comments
 (0)