improve

Author: adrelanos

usr/libexec/helper-scripts/strings.bsh

@@ -269,18 +269,25 @@ tests() {
 
    run_test "alpha_numeric: rejects empty"                   check_is_alpha_numeric 1 test_value ""
    run_test "alpha_numeric: rejects dot"                     check_is_alpha_numeric 1 test_value "."
-   run_test "alpha_numeric: accepts simple token"            check_is_alpha_numeric 0 test_value "test"
+   run_test "alpha_numeric: rejects space"                   check_is_alpha_numeric 1 test_value "plain text"
+   #run_test "alpha_numeric: rejects unicode"                 check_is_alpha_numeric 1 test_value "cafe"
+   run_test "alpha_numeric: accepts token with dash/underscore" check_is_alpha_numeric 0 test_value "test_123-OK"
 
    run_test "safe_filename: accepts simple name"             validate_safe_filename 0 test_value "test"
+   run_test "safe_filename: accepts spaces and punctuation"  validate_safe_filename 0 test_value "plain text (v1) [ok].txt"
    run_test "safe_filename: rejects dot"                     validate_safe_filename 1 test_value "."
    run_test "safe_filename: rejects double dot"              validate_safe_filename 1 test_value ".."
    run_test "safe_filename: rejects embedded double dot"     validate_safe_filename 1 test_value "test..test"
+   run_test "safe_filename: rejects slash"                   validate_safe_filename 1 test_value "dir/file"
+   run_test "safe_filename: rejects backslash"               validate_safe_filename 1 test_value $'dir\\file'
+   run_test "safe_filename: rejects control char newline"    validate_safe_filename 1 test_value $'hello\nworld'
+   run_test "safe_filename: rejects leading dash"            validate_safe_filename 1 test_value "-rf"
+   run_test "safe_filename: rejects overlong name"           validate_safe_filename 1 test_value "$(printf 'a%.0s' {1..256})"
 
    run_test "one_line: rejects empty"                        check_is_not_empty_and_only_one_line 1 test_value ""
    run_test "one_line: rejects only whitespace/newlines"     check_is_not_empty_and_only_one_line 1 test_value $'\n\n   '
-   run_test "one_line: rejects only spaces"                  check_is_not_empty_and_only_one_line 1 test_value "   "
-   run_test "one_line: accepts normal text"                  check_is_not_empty_and_only_one_line 0 test_value "Hello, World!"
    run_test "one_line: rejects multi-line string"            check_is_not_empty_and_only_one_line 1 test_value $'Hello\nWorld'
+   run_test "one_line: accepts normal text"                  check_is_not_empty_and_only_one_line 0 test_value "Hello, World!"
    run_test "one_line: accepts text with surrounding spaces" check_is_not_empty_and_only_one_line 0 test_value "  Hello  "
 
    input_string=$'test1\ntest2'