Skip to content

Commit fb92a10

Browse files
committed
make clippy happy
1 parent c51eda1 commit fb92a10

File tree

10 files changed

+106
-162
lines changed

10 files changed

+106
-162
lines changed

benches/decode_all.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ use ruzstd::decoding::FrameDecoder;
33

44
fn criterion_benchmark(c: &mut Criterion) {
55
let mut fr = FrameDecoder::new();
6-
let mut target_slice = &mut vec![0u8; 1024 * 1024 * 200];
6+
let target_slice = &mut vec![0u8; 1024 * 1024 * 200];
77
let src = include_bytes!("../decodecorpus_files/z000033.zst");
88

99
c.bench_function("decode_all_slice", |b| {

src/bin/zstd.rs

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,17 +34,14 @@ fn decompress(flags: &[String], file_paths: &[String]) {
3434
}
3535

3636
if flags.len() != 2 {
37-
eprintln!(
38-
"No flags other than -d and -c are currently implemented. Flags used: {:?}",
39-
flags
40-
);
37+
eprintln!("No flags other than -d and -c are currently implemented. Flags used: {flags:?}");
4138
return;
4239
}
4340

4441
let mut frame_dec = ruzstd::decoding::FrameDecoder::new();
4542

4643
for path in file_paths {
47-
eprintln!("File: {}", path);
44+
eprintln!("File: {path}");
4845
let mut f = File::open(path).unwrap();
4946

5047
let mut tracker = StateTracker {
@@ -146,7 +143,7 @@ impl<R: Read> Read for PercentPrintReader<R> {
146143
if progress > self.last_percent {
147144
self.last_percent = progress;
148145
eprint!("\r");
149-
eprint!("{} % done", progress);
146+
eprint!("{progress} % done");
150147
}
151148
Ok(new_bytes)
152149
}
@@ -215,7 +212,7 @@ fn do_something(data: &[u8], s: &mut StateTracker) {
215212
let percentage = (s.file_pos * 100) / s.file_size;
216213
if percentage as i8 != s.old_percentage {
217214
eprint!("\r");
218-
eprint!("{} % done", percentage);
215+
eprint!("{percentage} % done");
219216
s.old_percentage = percentage as i8;
220217
}
221218
}

src/bin/zstd_stream.rs

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,12 @@ fn main() {
1818
}
1919

2020
if flags.len() != 2 {
21-
eprintln!(
22-
"No flags other than -d and -c are currently implemented. Flags used: {:?}",
23-
flags
24-
);
21+
eprintln!("No flags other than -d and -c are currently implemented. Flags used: {flags:?}");
2522
return;
2623
}
2724

2825
for path in file_paths {
29-
eprintln!("File: {}", path);
26+
eprintln!("File: {path}");
3027
let f = File::open(path).unwrap();
3128
let mut buf_read = std::io::BufReader::new(f);
3229

src/bit_io/bit_reader.rs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -116,8 +116,7 @@ impl core::fmt::Display for GetBitsError {
116116
} => {
117117
write!(
118118
f,
119-
"Cant serve this request. The reader is limited to {} bits, requested {} bits",
120-
limit, num_requested_bits,
119+
"Cant serve this request. The reader is limited to {limit} bits, requested {num_requested_bits} bits",
121120
)
122121
}
123122
GetBitsError::NotEnoughRemainingBits {
@@ -126,8 +125,7 @@ impl core::fmt::Display for GetBitsError {
126125
} => {
127126
write!(
128127
f,
129-
"Can\'t read {} bits, only have {} bits left",
130-
requested, remaining,
128+
"Can\'t read {requested} bits, only have {remaining} bits left",
131129
)
132130
}
133131
}

src/decoding/errors.rs

Lines changed: 74 additions & 110 deletions
Large diffs are not rendered by default.

src/huff0/huff0_encoder.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -435,8 +435,7 @@ fn weights() {
435435
let code2_shifted = code2 >> (num_bits2 - num_bits);
436436
assert_ne!(
437437
code, code2_shifted,
438-
"{:b},{num_bits:} is prefix of {:b},{num_bits2:}",
439-
code, code2
438+
"{code:b},{num_bits:} is prefix of {code2:b},{num_bits2:}"
440439
);
441440
}
442441
}

src/tests/decode_corpus.rs

Lines changed: 8 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ fn test_decode_corpus_files() {
4343
if !p.ends_with(".zst") {
4444
continue;
4545
}
46-
println!("Trying file: {}", p);
46+
println!("Trying file: {p}");
4747

4848
let mut content = fs::File::open(f.path()).unwrap();
4949

@@ -125,7 +125,7 @@ fn test_decode_corpus_files() {
125125
}
126126

127127
if counter > 0 {
128-
println!("Result differs in at least {} bytes from original", counter);
128+
println!("Result differs in at least {counter} bytes from original");
129129
success = false;
130130
fail_counter_diff += 1;
131131
}
@@ -140,8 +140,8 @@ fn test_decode_corpus_files() {
140140
let dur = end_time.as_micros() as usize;
141141
let speed = result.len() / if dur == 0 { 1 } else { dur };
142142
let speed_read = file_size as usize / if dur == 0 { 1 } else { dur };
143-
println!("SPEED: {}", speed);
144-
println!("SPEED_read: {}", speed_read);
143+
println!("SPEED: {speed}");
144+
println!("SPEED_read: {speed_read}");
145145
speeds.push(speed);
146146
speeds_read.push(speed_read);
147147
}
@@ -150,25 +150,19 @@ fn test_decode_corpus_files() {
150150
println!("Summary:");
151151
println!("###################");
152152
println!(
153-
"Total: {}, Success: {}, WrongSize: {}, WrongBytecount: {}, WrongChecksum: {}, Diffs: {}",
154-
total_counter,
155-
success_counter,
156-
fail_counter_size,
157-
fail_counter_bytes_read,
158-
fail_counter_chksum,
159-
fail_counter_diff
153+
"Total: {total_counter}, Success: {success_counter}, WrongSize: {fail_counter_size}, WrongBytecount: {fail_counter_bytes_read}, WrongChecksum: {fail_counter_chksum}, Diffs: {fail_counter_diff}"
160154
);
161155
println!("Failed files: ");
162156
for f in &failed {
163-
println!("{}", f);
157+
println!("{f}");
164158
}
165159

166160
let speed_len = speeds.len();
167161
let sum_speed: usize = speeds.into_iter().sum();
168162
let avg_speed = sum_speed / speed_len;
169163
let avg_speed_bps = avg_speed * 1_000_000;
170164
if avg_speed_bps < 1000 {
171-
println!("Average speed: {} B/s", avg_speed_bps);
165+
println!("Average speed: {avg_speed_bps} B/s");
172166
} else if avg_speed_bps < 1_000_000 {
173167
println!("Average speed: {} KB/s", avg_speed_bps / 1000);
174168
} else {
@@ -180,7 +174,7 @@ fn test_decode_corpus_files() {
180174
let avg_speed_read = sum_speed_read / speed_read_len;
181175
let avg_speed_read_bps = avg_speed_read * 1_000_000;
182176
if avg_speed_read_bps < 1000 {
183-
println!("Average speed reading: {} B/s", avg_speed_read_bps);
177+
println!("Average speed reading: {avg_speed_read_bps} B/s");
184178
} else if avg_speed_bps < 1_000_000 {
185179
println!("Average speed reading: {} KB/s", avg_speed_read_bps / 1000);
186180
} else {

src/tests/dict_test.rs

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ fn test_dict_decoding() {
118118
if !p.ends_with(".zst") {
119119
continue;
120120
}
121-
println!("Trying file: {}", p);
121+
println!("Trying file: {p}");
122122

123123
let mut content = fs::File::open(f.path()).unwrap();
124124

@@ -198,7 +198,7 @@ fn test_dict_decoding() {
198198
}
199199

200200
if counter > 0 {
201-
println!("Result differs in at least {} bytes from original", counter);
201+
println!("Result differs in at least {counter} bytes from original");
202202
success = false;
203203
fail_counter_diff += 1;
204204
}
@@ -213,8 +213,8 @@ fn test_dict_decoding() {
213213
let dur = end_time.as_micros() as usize;
214214
let speed = result.len() / if dur == 0 { 1 } else { dur };
215215
let speed_read = file_size as usize / if dur == 0 { 1 } else { dur };
216-
println!("SPEED: {}", speed);
217-
println!("SPEED_read: {}", speed_read);
216+
println!("SPEED: {speed}");
217+
println!("SPEED_read: {speed_read}");
218218
speeds.push(speed);
219219
speeds_read.push(speed_read);
220220
}
@@ -223,24 +223,19 @@ fn test_dict_decoding() {
223223
println!("Summary:");
224224
println!("###################");
225225
println!(
226-
"Total: {}, Success: {}, WrongSize: {}, WrongBytecount: {}, Diffs: {}",
227-
total_counter,
228-
success_counter,
229-
fail_counter_size,
230-
fail_counter_bytes_read,
231-
fail_counter_diff
226+
"Total: {total_counter}, Success: {success_counter}, WrongSize: {fail_counter_size}, WrongBytecount: {fail_counter_bytes_read}, Diffs: {fail_counter_diff}"
232227
);
233228
println!("Failed files: ");
234229
for f in &failed {
235-
println!("{}", f);
230+
println!("{f}");
236231
}
237232

238233
let speed_len = speeds.len();
239234
let sum_speed: usize = speeds.into_iter().sum();
240235
let avg_speed = sum_speed / speed_len;
241236
let avg_speed_bps = avg_speed * 1_000_000;
242237
if avg_speed_bps < 1000 {
243-
println!("Average speed: {} B/s", avg_speed_bps);
238+
println!("Average speed: {avg_speed_bps} B/s");
244239
} else if avg_speed_bps < 1_000_000 {
245240
println!("Average speed: {} KB/s", avg_speed_bps / 1000);
246241
} else {
@@ -252,7 +247,7 @@ fn test_dict_decoding() {
252247
let avg_speed_read = sum_speed_read / speed_read_len;
253248
let avg_speed_read_bps = avg_speed_read * 1_000_000;
254249
if avg_speed_read_bps < 1000 {
255-
println!("Average speed reading: {} B/s", avg_speed_read_bps);
250+
println!("Average speed reading: {avg_speed_read_bps} B/s");
256251
} else if avg_speed_bps < 1_000_000 {
257252
println!("Average speed reading: {} KB/s", avg_speed_read_bps / 1000);
258253
} else {

src/tests/encode_corpus.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ fn test_encode_corpus_files_uncompressed_our_decompressor() {
2727
continue;
2828
}
2929

30-
println!("Trying file: {:?}", path);
30+
println!("Trying file: {path:?}");
3131
let input = fs::read(entry.path()).unwrap();
3232
let mut compressed_file: Vec<u8> = Vec::new();
3333
let mut compressor = FrameCompressor::new(crate::encoding::CompressionLevel::Fastest);
@@ -82,7 +82,7 @@ fn test_encode_corpus_files_uncompressed_original_decompressor() {
8282
if path.extension() == Some(OsStr::new("zst")) {
8383
continue;
8484
}
85-
println!("Trying file: {:?}", path);
85+
println!("Trying file: {path:?}");
8686
let input = fs::read(entry.path()).unwrap();
8787

8888
let mut compressed_file: Vec<u8> = Vec::new();
@@ -143,7 +143,7 @@ fn test_encode_corpus_files_compressed_our_decompressor() {
143143
if path.extension() == Some(OsStr::new("zst")) {
144144
continue;
145145
}
146-
println!("Trying file: {:?}", path);
146+
println!("Trying file: {path:?}");
147147
let input = fs::read(entry.path()).unwrap();
148148

149149
let mut compressed_file: Vec<u8> = Vec::new();
@@ -199,7 +199,7 @@ fn test_encode_corpus_files_compressed_original_decompressor() {
199199
if path.extension() == Some(OsStr::new("zst")) {
200200
continue;
201201
}
202-
println!("Trying file: {:?}", path);
202+
println!("Trying file: {path:?}");
203203
let input = fs::read(entry.path()).unwrap();
204204

205205
let mut compressed_file: Vec<u8> = Vec::new();

src/tests/mod.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ fn test_specific_file() {
259259
let original_f = fs::File::open("./decodecorpus_files/z000088").unwrap();
260260
let original: Vec<u8> = original_f.bytes().map(|x| x.unwrap()).collect();
261261

262-
std::println!("Results for file: {}", path);
262+
std::println!("Results for file: {path}");
263263

264264
if original.len() != result.len() {
265265
std::println!(
@@ -285,7 +285,7 @@ fn test_specific_file() {
285285
}
286286
}
287287
if counter > 0 {
288-
std::println!("Result differs in at least {} bytes from original", counter);
288+
std::println!("Result differs in at least {counter} bytes from original");
289289
}
290290
}
291291

0 commit comments

Comments
 (0)