feedback + opportunistic fixes

Author: sfierro

app/web_ui/src/routes/(app)/specs/[project_id]/[task_id]/create_spec/+page.svelte

@@ -139,15 +139,7 @@
       next_error = null
       submitting = true
 
-      // Validate required fields
-      for (const field of field_configs) {
-        if (field.required) {
-          const value = property_values[field.key]
-          if (!value || !value.trim()) {
-            throw new Error(`${field.label} is required`)
-          }
-        }
-      }
+      validateRequiredFields()
 
       if (!has_kiln_copilot) {
         submitting = false
@@ -165,15 +157,20 @@
     // Don't warn before unloading since we're intentionally navigating
     warn_before_unload = false
 
-    // Navigate to review_spec page
-    await navigateToReviewSpec(
-      project_id,
-      task_id,
-      name,
-      spec_type,
-      property_values,
-      evaluate_full_trace,
-    )
+    try {
+      // Navigate to review_spec page
+      await navigateToReviewSpec(
+        project_id,
+        task_id,
+        name,
+        spec_type,
+        property_values,
+        evaluate_full_trace,
+      )
+    } catch (error) {
+      warn_before_unload = true
+      next_error = createKilnError(error)
+    }
   }
 
   let show_continue_to_review = false
@@ -195,21 +192,24 @@
     return false
   }
 
+  function validateRequiredFields() {
+    for (const field of field_configs) {
+      if (field.required) {
+        const value = property_values[field.key]
+        if (!value || !value.trim()) {
+          throw new Error(`${field.label} is required`)
+        }
+      }
+    }
+  }
+
   async function do_create_spec(set_error: (error: KilnError | null) => void) {
     try {
       set_error(null)
       submitting = true
       complete = false
 
-      // Validate required fields
-      for (const field of field_configs) {
-        if (field.required) {
-          const value = property_values[field.key]
-          if (!value || !value.trim()) {
-            throw new Error(`${field.label} is required`)
-          }
-        }
-      }
+      validateRequiredFields()
 
       const spec_id = await createSpec(
         project_id,
@@ -256,7 +256,7 @@
     ]}
   >
     <FormContainer
-      submit_label="Next"
+      submit_label={has_kiln_copilot ? "Refine Spec with Copilot" : "Next"}
       on:submit={check_kiln_copilot_and_proceed}
       bind:error={next_error}
       bind:submitting
@@ -309,7 +309,7 @@
         <span class="text-xs text-gray-500">or</span>
         <button
           class="link underline text-xs text-gray-500"
-          on:click={create_spec_from_form}>Create Spec Without Analysis</button
+          on:click={create_spec_from_form}>Create Spec Without Copilot</button
         >
       </div>
     {/if}
@@ -341,8 +341,8 @@
       {#if show_continue_to_review}
         <button
           class="btn btn-primary mt-4 w-full"
-          on:click={() => {
-            proceed_to_review()
+          on:click={async () => {
+            await proceed_to_review()
             copilot_v_manual_dialog?.close()
           }}
         >

app/web_ui/src/routes/(app)/specs/[project_id]/[task_id]/refine_spec/+page.svelte

@@ -213,7 +213,7 @@
       <!-- Column Headers -->
       <div class="grid grid-cols-2 gap-8 mb-4">
         <div class="text-xl font-bold">Current</div>
-        <div class="text-xl font-bold">Suggestions</div>
+        <div class="text-xl font-bold">Refined</div>
       </div>
 
       <!-- Spec Name Row -->
@@ -266,36 +266,12 @@
                     class="badge badge-success badge-outline badge-sm gap-1 ml-2"
                   >
                     No changes
-                    <svg
-                      class="w-3 h-3"
-                      viewBox="0 0 24 24"
-                      fill="none"
-                      xmlns="http://www.w3.org/2000/svg"
-                    >
-                      <path
-                        d="M16 9L10 15.5L7.5 13M12 21C16.9706 21 21 16.9706 21 12C21 7.02944 16.9706 3 12 3C7.02944 3 3 7.02944 3 12C3 16.9706 7.02944 21 12 21Z"
-                        stroke="currentColor"
-                        stroke-width="2"
-                        stroke-linecap="round"
-                        stroke-linejoin="round"
-                      />
-                    </svg>
                   </span>
                 {:else}
                   <span
                     class="badge badge-warning badge-outline badge-sm gap-1 ml-2"
                   >
-                    Edit suggested
-                    <svg
-                      class="w-3 h-3"
-                      fill="currentColor"
-                      viewBox="0 0 256 256"
-                      xmlns="http://www.w3.org/2000/svg"
-                    >
-                      <path
-                        d="M128,20.00012a108,108,0,1,0,108,108A108.12217,108.12217,0,0,0,128,20.00012Zm0,192a84,84,0,1,1,84-84A84.0953,84.0953,0,0,1,128,212.00012Zm-12-80v-52a12,12,0,1,1,24,0v52a12,12,0,1,1-24,0Zm28,40a16,16,0,1,1-16-16A16.018,16.018,0,0,1,144,172.00012Z"
-                      />
-                    </svg>
+                    Refined
                   </span>
                 {/if}
               {/if}

app/web_ui/src/routes/(app)/specs/[project_id]/[task_id]/review_spec/+page.svelte

@@ -35,9 +35,7 @@
   let submitting = false
   let complete = false
 
-  $: submit_label = all_feedback_aligned
-    ? "Create Spec"
-    : "Refine Spec with Feedback"
+  $: submit_label = all_feedback_aligned ? "Create Spec" : "Next"
   $: submit_disabled = !all_feedback_aligned && !any_feedback_provided
 
   type ReviewRow = {
@@ -395,7 +393,7 @@
           <div class="flex justify-center">
             <Warning
               warning_color="warning"
-              warning_message="For best results, finish reviewing all examples before refining the spec."
+              warning_message="For best results, finish reviewing all examples before continuing."
               tight={true}
             />
           </div>