Merge pull request #3270 from Kilo-Org/christiaan/haiku-read-file

Use single file read_file tool for Haiku 4.5

Author: chrarnoldus

.changeset/nervous-nails-type.md

@@ -0,0 +1,5 @@
+---
+"kilo-code": patch
+---
+
+Claude Haiku 4.5 now uses a simplified read file tool for reduced error rate

packages/types/src/single-file-read-models.ts

@@ -10,6 +10,5 @@
  * @returns true if the model should use single file reads
  */
 export function shouldUseSingleFileRead(modelId: string): boolean {
-	return false // kilocode_change
-	return modelId.includes("grok-code-fast-1") || modelId.includes("code-supernova")
+	return modelId.includes("claude-haiku-4.5") || modelId.includes("claude-haiku-4-5") // kilocode_change
 }

src/core/prompts/tools/native-tools/__tests__/getAllowedJSONToolsForMode.spec.ts

@@ -34,7 +34,7 @@ describe("getAllowedJSONToolsForMode", () => {
 			mockCodeIndexManager,
 			providerState as ClineProviderState,
 			true,
-			false,
+			undefined,
 		)
 
 		const applyDiffTool = tools.find((tool) => "function" in tool && tool.function.name === "apply_diff")
@@ -59,7 +59,7 @@ describe("getAllowedJSONToolsForMode", () => {
 			mockCodeIndexManager,
 			providerState as ClineProviderState,
 			true,
-			false,
+			undefined,
 		)
 
 		const applyDiffTool = tools.find((tool) => "function" in tool && tool.function.name === "apply_diff")

src/core/prompts/tools/native-tools/getAllowedJSONToolsForMode.ts

@@ -1,4 +1,4 @@
-import { ToolName } from "@roo-code/types"
+import { ModelInfo, shouldUseSingleFileRead, ToolName } from "@roo-code/types"
 import { CodeIndexManager } from "../../../../services/code-index/manager"
 import { Mode, getModeConfig, isToolAllowedForMode, getGroupName } from "../../../../shared/modes"
 import { ClineProviderState } from "../../../webview/ClineProvider"
@@ -7,13 +7,14 @@ import { ALWAYS_AVAILABLE_TOOLS, TOOL_GROUPS } from "../../../../shared/tools"
 import { isFastApplyAvailable } from "../../../tools/editFileTool"
 import { nativeTools } from "."
 import { apply_diff_multi_file, apply_diff_single_file } from "./apply_diff"
+import { read_file_multi, read_file_single } from "./read_file"
 
 export function getAllowedJSONToolsForMode(
 	mode: Mode,
 	codeIndexManager: CodeIndexManager | undefined,
 	clineProviderState: ClineProviderState | undefined,
 	diffEnabled: boolean,
-	supportsImages: boolean,
+	model: { id: string; info: ModelInfo } | undefined,
 ): OpenAI.Chat.ChatCompletionTool[] {
 	const config = getModeConfig(mode, clineProviderState?.customModes)
 
@@ -75,28 +76,39 @@ export function getAllowedJSONToolsForMode(
 		tools.delete("run_slash_command")
 	}
 
-	if (!clineProviderState?.browserToolEnabled || !supportsImages) {
+	if (!clineProviderState?.browserToolEnabled || !model?.info.supportsImages) {
 		tools.delete("browser_action")
 	}
 
 	// Create a map of tool names to native tool definitions for quick lookup
 	// Exclude apply_diff tools as they are handled specially below
 	const allowedTools: OpenAI.Chat.ChatCompletionTool[] = []
 
+	let isReadFileToolAllowedForMode = false
 	let isApplyDiffToolAllowedForMode = false
 	for (const nativeTool of nativeTools) {
 		const toolName = nativeTool.function.name
 
 		// If the tool is in the allowed set, add it.
 		if (tools.has(toolName)) {
-			if (toolName === "apply_diff") {
+			if (toolName === "read_file") {
+				isReadFileToolAllowedForMode = true
+			} else if (toolName === "apply_diff") {
 				isApplyDiffToolAllowedForMode = true
 			} else {
 				allowedTools.push(nativeTool)
 			}
 		}
 	}
 
+	if (isReadFileToolAllowedForMode) {
+		if (model?.id && shouldUseSingleFileRead(model?.id)) {
+			allowedTools.push(read_file_single)
+		} else {
+			allowedTools.push(read_file_multi)
+		}
+	}
+
 	// Handle the "apply_diff" logic separately because the same tool has different
 	// implementations depending on whether multi-file diffs are enabled, but the same name is used.
 	if (isApplyDiffToolAllowedForMode && diffEnabled) {

src/core/prompts/tools/native-tools/index.ts

@@ -11,7 +11,7 @@ import insertContent from "./insert_content"
 import listCodeDefinitionNames from "./list_code_definition_names"
 import listFiles from "./list_files"
 import newTask from "./new_task"
-import readFile from "./read_file"
+import { read_file_single, read_file_multi } from "./read_file"
 import runSlashCommand from "./run_slash_command"
 import searchAndReplace from "./search_and_replace"
 import searchFiles from "./search_files"
@@ -35,7 +35,8 @@ export const nativeTools = [
 	listCodeDefinitionNames,
 	listFiles,
 	newTask,
-	readFile,
+	read_file_single,
+	read_file_multi,
 	runSlashCommand,
 	searchAndReplace,
 	searchFiles,

src/core/prompts/tools/native-tools/read_file.ts

@@ -1,6 +1,6 @@
 import type OpenAI from "openai"
 
-export default {
+export const read_file_multi = {
 	type: "function",
 	function: {
 		name: "read_file",
@@ -42,3 +42,24 @@ export default {
 		},
 	},
 } satisfies OpenAI.Chat.ChatCompletionTool
+
+export const read_file_single = {
+	type: "function",
+	function: {
+		name: "read_file",
+		description:
+			'Request to read the contents of a file. The tool outputs line-numbered content (e.g. "1 | const x = 1") for easy reference when discussing code.',
+		strict: true,
+		parameters: {
+			type: "object",
+			properties: {
+				path: {
+					type: "string",
+					description: "Path to the file to read, relative to the workspace",
+				},
+			},
+			required: ["path"],
+			additionalProperties: false,
+		},
+	},
+} satisfies OpenAI.Chat.ChatCompletionTool

src/core/task/Task.ts

@@ -2964,7 +2964,7 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
 					undefined, // codeIndexManager is private, not accessible here
 					providerState,
 					this.diffEnabled,
-					this.api?.getModel()?.info?.supportsImages ?? false,
+					this.api?.getModel(),
 				)
 
 				metadata.allowedTools = allowedTools