detach cmd-l from inline completions

instead use a method call, so can disable inline completions fully when autocomplete is turned of

Author: markijbema

src/services/ghost/GhostServiceManager.ts

@@ -276,8 +276,41 @@ export class GhostServiceManager {
 			await this.load()
 		}
 
-		// Trigger the inline completion provider
-		await vscode.commands.executeCommand("editor.action.inlineSuggest.trigger")
+		// Call the inline completion provider directly with manual trigger context
+		const position = editor.selection.active
+		const context: vscode.InlineCompletionContext = {
+			triggerKind: vscode.InlineCompletionTriggerKind.Invoke,
+			selectedCompletionInfo: undefined,
+		}
+		const tokenSource = new vscode.CancellationTokenSource()
+
+		try {
+			const completions = await this.inlineCompletionProvider.provideInlineCompletionItems(
+				document,
+				position,
+				context,
+				tokenSource.token,
+			)
+
+			// If we got completions, directly insert the first one
+			if (completions && (Array.isArray(completions) ? completions.length > 0 : completions.items.length > 0)) {
+				const items = Array.isArray(completions) ? completions : completions.items
+				const firstCompletion = items[0]
+
+				if (firstCompletion && firstCompletion.insertText) {
+					const insertText =
+						typeof firstCompletion.insertText === "string"
+							? firstCompletion.insertText
+							: firstCompletion.insertText.value
+
+					await editor.edit((editBuilder) => {
+						editBuilder.insert(position, insertText)
+					})
+				}
+			}
+		} finally {
+			tokenSource.dispose()
+		}
 	}
 
 	private async updateGlobalContext() {

src/services/ghost/__tests__/GhostServiceManager.spec.ts

@@ -144,4 +144,150 @@ console.log('test');]]></replace></change>`
 			expect(result.suggestions.hasSuggestions()).toBe(true)
 		})
 	})
+
+	describe("codeSuggestion", () => {
+		it("should call provideInlineCompletionItems and directly insert completion", async () => {
+			// This test verifies that codeSuggestion calls the provider directly
+			// and inserts the completion without using the VSCode inline suggest UI
+			const initialContent = `console.log('test');`
+			const { mockDocument } = await setupTestDocument("test.js", initialContent)
+
+			const suggestionText = "// suggestion"
+
+			// Mock the inline completion provider
+			const mockProvider = {
+				provideInlineCompletionItems: vi.fn().mockResolvedValue([
+					{
+						insertText: suggestionText,
+						range: new vscode.Range(new vscode.Position(0, 0), new vscode.Position(0, 0)),
+					},
+				]),
+			}
+
+			// Mock editor.edit
+			const mockEdit = vi.fn().mockImplementation((callback) => {
+				const editBuilder = {
+					insert: vi.fn(),
+				}
+				callback(editBuilder)
+				return Promise.resolve(true)
+			})
+
+			// Mock the GhostServiceManager instance with necessary properties
+			const mockManager = {
+				inlineCompletionProvider: mockProvider,
+				model: { loaded: true },
+				taskId: null,
+				async hasAccess(_document: any) {
+					return true
+				},
+				async load() {},
+				async codeSuggestion() {
+					const editor = vscode.window.activeTextEditor
+					if (!editor) {
+						return
+					}
+
+					const document = editor.document
+					if (!(await this.hasAccess(document))) {
+						return
+					}
+
+					if (!this.model.loaded) {
+						await this.load()
+					}
+
+					const position = editor.selection.active
+					const context: vscode.InlineCompletionContext = {
+						triggerKind: 1, // InlineCompletionTriggerKind.Invoke
+						selectedCompletionInfo: undefined,
+					}
+					const tokenSource = {
+						token: { isCancellationRequested: false, onCancellationRequested: vi.fn() },
+						dispose: vi.fn(),
+					}
+
+					try {
+						const completions = await this.inlineCompletionProvider.provideInlineCompletionItems(
+							document,
+							position,
+							context,
+							tokenSource.token,
+						)
+
+						if (
+							completions &&
+							(Array.isArray(completions) ? completions.length > 0 : completions.items.length > 0)
+						) {
+							const items = Array.isArray(completions) ? completions : completions.items
+							const firstCompletion = items[0]
+
+							if (firstCompletion && firstCompletion.insertText) {
+								const insertText =
+									typeof firstCompletion.insertText === "string"
+										? firstCompletion.insertText
+										: firstCompletion.insertText.value
+
+								await editor.edit((editBuilder) => {
+									editBuilder.insert(position, insertText)
+								})
+							}
+						}
+					} finally {
+						tokenSource.dispose()
+					}
+				},
+			}
+
+			// Set up active editor with mock edit function
+			;(vscode.window as any).activeTextEditor = {
+				document: mockDocument,
+				selection: {
+					active: new vscode.Position(0, 0),
+				},
+				edit: mockEdit,
+			}
+
+			// Call codeSuggestion
+			await mockManager.codeSuggestion()
+
+			// Verify that provideInlineCompletionItems was called with correct parameters
+			expect(mockProvider.provideInlineCompletionItems).toHaveBeenCalledWith(
+				mockDocument,
+				expect.any(vscode.Position),
+				expect.objectContaining({
+					triggerKind: 1, // InlineCompletionTriggerKind.Invoke
+				}),
+				expect.any(Object),
+			)
+
+			// Verify that editor.edit was called to insert the completion
+			expect(mockEdit).toHaveBeenCalled()
+		})
+
+		it("should not call provider when no active editor", async () => {
+			const mockProvider = {
+				provideInlineCompletionItems: vi.fn(),
+			}
+
+			const mockManager = {
+				inlineCompletionProvider: mockProvider,
+				async codeSuggestion() {
+					const editor = vscode.window.activeTextEditor
+					if (!editor) {
+						return
+					}
+					// Rest of the logic would go here
+				},
+			}
+
+			// No active editor
+			;(vscode.window as any).activeTextEditor = null
+
+			await mockManager.codeSuggestion()
+
+			// Verify provider was not called
+			expect(mockProvider.provideInlineCompletionItems).not.toHaveBeenCalled()
+		})
+	})
 })