less fill in the blanks inheritance

make it possible for strategies to fully define their system prompt

Author: markijbema

src/services/ghost/strategies/AutoTriggerStrategy.ts

@@ -24,11 +24,14 @@ export class AutoTriggerStrategy extends BasePromptStrategy {
 	/**
 	 * System instructions for auto-trigger
 	 */
-	protected getSpecificSystemInstructions(): string {
-		return `Task: Subtle Auto-Completion
+	getSystemInstructions(): string {
+		return (
+			this.getBaseSystemInstructions() +
+			`Task: Subtle Auto-Completion
 Provide non-intrusive completions after a typing pause. Be conservative and helpful.
 
 `
+		)
 	}
 
 	/**

src/services/ghost/strategies/BasePromptStrategy.ts

@@ -24,16 +24,6 @@ export abstract class BasePromptStrategy implements PromptStrategy {
 	 */
 	abstract canHandle(context: GhostSuggestionContext): boolean
 
-	/**
-	 * Generates system instructions for the AI model
-	 */
-	getSystemInstructions(): string {
-		const baseInstructions = this.getBaseSystemInstructions()
-		const specificInstructions = this.getSpecificSystemInstructions()
-
-		return `${baseInstructions}${specificInstructions}`
-	}
-
 	/**
 	 * Gets the base system instructions that apply to all strategies
 	 */
@@ -82,7 +72,7 @@ EXAMPLE:
 	 * Gets strategy-specific system instructions
 	 * Must be implemented by each strategy
 	 */
-	protected abstract getSpecificSystemInstructions(): string
+	abstract getSystemInstructions(): string
 
 	/**
 	 * Generates the user prompt with context

src/services/ghost/strategies/CommentDrivenStrategy.ts

@@ -30,8 +30,10 @@ export class CommentDrivenStrategy extends BasePromptStrategy {
 		return isComment && !context.userInput // User input takes precedence
 	}
 
-	protected getSpecificSystemInstructions(): string {
-		return `You are an expert code generation assistant that implements code based on comments.
+	getSystemInstructions(): string {
+		return (
+			this.getBaseSystemInstructions() +
+			`You are an expert code generation assistant that implements code based on comments.
 
 ## Core Responsibilities:
 1. Read and understand the comment's intent
@@ -63,6 +65,7 @@ export class CommentDrivenStrategy extends BasePromptStrategy {
 - Do not add explanatory comments unless necessary for complex logic
 - Ensure the code is production-ready
 - When using search/replace format, include ALL existing code to preserve it`
+		)
 	}
 
 	getUserPrompt(context: GhostSuggestionContext): string {

src/services/ghost/strategies/InlineCompletionStrategy.ts

@@ -25,8 +25,10 @@ export class InlineCompletionStrategy extends BasePromptStrategy {
 		return hasContentBefore && !context.userInput && !context.range.isEmpty === false && isNotAtEnd
 	}
 
-	protected getSpecificSystemInstructions(): string {
-		return `You are an expert code completion assistant specializing in inline completions.
+	getSystemInstructions(): string {
+		return (
+			this.getBaseSystemInstructions() +
+			`You are an expert code completion assistant specializing in inline completions.
 
 ## Core Responsibilities:
 1. Complete partial statements and expressions
@@ -63,6 +65,7 @@ export class InlineCompletionStrategy extends BasePromptStrategy {
 - Complete just enough to finish the current expression
 - Ensure syntactic correctness
 - Match the existing code style`
+		)
 	}
 
 	getUserPrompt(context: GhostSuggestionContext): string {

src/services/ghost/strategies/NewLineCompletionStrategy.ts

@@ -25,8 +25,10 @@ export class NewLineCompletionStrategy extends BasePromptStrategy {
 	/**
 	 * System instructions for new line completion
 	 */
-	protected getSpecificSystemInstructions(): string {
-		return `Task: Proactive Code Completion for New Lines
+	getSystemInstructions(): string {
+		return (
+			this.getBaseSystemInstructions() +
+			`Task: Proactive Code Completion for New Lines
 The user has created a new line. Suggest the most logical next code based on context.
 
 Completion Guidelines:
@@ -59,6 +61,7 @@ Important:
 - Respect existing code patterns and comments
 - Maintain consistent style
 - Consider the most likely next step`
+		)
 	}
 
 	/**

src/services/ghost/strategies/SelectionRefactorStrategy.ts

@@ -17,8 +17,10 @@ export class SelectionRefactorStrategy extends BasePromptStrategy {
 		return !!(context.range && !context.range.isEmpty && !context.userInput)
 	}
 
-	protected getSpecificSystemInstructions(): string {
-		return `You are an expert code refactoring assistant. Your task is to improve selected code while maintaining its functionality.
+	getSystemInstructions(): string {
+		return (
+			this.getBaseSystemInstructions() +
+			`You are an expert code refactoring assistant. Your task is to improve selected code while maintaining its functionality.
 
 ## Core Responsibilities:
 1. Analyze the selected code for improvement opportunities
@@ -44,6 +46,7 @@ export class SelectionRefactorStrategy extends BasePromptStrategy {
 - Do not include explanations outside the code
 
 Remember: The goal is to improve the code quality while keeping the exact same behavior.`
+		)
 	}
 
 	getUserPrompt(context: GhostSuggestionContext): string {

src/services/ghost/strategies/UserRequestStrategy.ts

@@ -22,8 +22,10 @@ export class UserRequestStrategy extends BasePromptStrategy {
 	/**
 	 * System instructions specific to user requests
 	 */
-	protected getSpecificSystemInstructions(): string {
-		return `Task: Execute User's Explicit Request
+	getSystemInstructions(): string {
+		return (
+			this.getBaseSystemInstructions() +
+			`Task: Execute User's Explicit Request
 You are responding to a direct user instruction. Your primary goal is to fulfill their specific request accurately.
 
 Priority Order:
@@ -48,6 +50,7 @@ Common Request Patterns:
 - "add comments" → add JSDoc or inline comments
 - "extract function" → move selected code to a new function
 - "fix" → resolve errors, warnings, or obvious issues`
+		)
 	}
 
 	/**