Skip to content

Commit b2b5d9e

Browse files
committed
Make publishing of the extension a manual action
Previously we automatically published the extension when the Changeset PR got merged, but now that we also bump the CLI version through changeset that means that we have to publish the extension whenever we want to release the CLI, which is not great, especially because we want to limit the number of releases of the extension. This PR removes the PR-closed trigger, which means that to release the extension we have to manually trigger this workflow.
1 parent 15fa99c commit b2b5d9e

File tree

1 file changed

+8
-20
lines changed

1 file changed

+8
-20
lines changed

.github/workflows/marketplace-publish.yml

Lines changed: 8 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
name: Publish Extension
22
on:
3-
pull_request:
4-
types: [closed]
53
workflow_dispatch:
64

75
env:
@@ -16,11 +14,6 @@ jobs:
1614
runs-on: ubuntu-latest
1715
permissions:
1816
contents: write # Required for pushing tags.
19-
if: >
20-
( github.event_name == 'pull_request' &&
21-
github.event.pull_request.base.ref == 'main' &&
22-
contains(github.event.pull_request.title, 'Changeset version bump') ) ||
23-
github.event_name == 'workflow_dispatch'
2417
steps:
2518
- name: Checkout code
2619
uses: actions/checkout@v4
@@ -110,11 +103,6 @@ jobs:
110103
publish-jetbrains:
111104
needs: publish-extension
112105
runs-on: ubuntu-latest
113-
if: >
114-
( github.event_name == 'pull_request' &&
115-
github.event.pull_request.base.ref == 'main' &&
116-
contains(github.event.pull_request.title, 'Changeset version bump') ) ||
117-
github.event_name == 'workflow_dispatch'
118106
steps:
119107
- name: Checkout code
120108
uses: actions/checkout@v4
@@ -177,11 +165,11 @@ jobs:
177165
path: jetbrains/plugin/build/distributions/${{ env.BUNDLE_NAME }}
178166
- name: JetBrains Marketplace Publisher
179167
run: |
180-
curl \
181-
-X POST \
182-
-H "Authorization: Bearer ${{ secrets.JETBRAINS_MARKETPLACE_TOKEN }}" \
183-
-F "file=@jetbrains/plugin/build/distributions/${{ env.BUNDLE_NAME }}" \
184-
-F "pluginId=28350" \
185-
-F "channel=stable" \
186-
-F "isHidden=false" \
187-
https://plugins.jetbrains.com/plugin/uploadPlugin
168+
curl \
169+
-X POST \
170+
-H "Authorization: Bearer ${{ secrets.JETBRAINS_MARKETPLACE_TOKEN }}" \
171+
-F "file=@jetbrains/plugin/build/distributions/${{ env.BUNDLE_NAME }}" \
172+
-F "pluginId=28350" \
173+
-F "channel=stable" \
174+
-F "isHidden=false" \
175+
https://plugins.jetbrains.com/plugin/uploadPlugin

0 commit comments

Comments
 (0)