remove indirection

Author: markijbema

src/services/ghost/strategies/AutoTriggerStrategy.ts

@@ -34,7 +34,7 @@ Provide non-intrusive completions after a typing pause. Be conservative and help
 	/**
 	 * Build minimal prompt for auto-trigger
 	 */
-	protected buildUserPrompt(context: Partial<GhostSuggestionContext>): string {
+	getUserPrompt(context: GhostSuggestionContext): string {
 		let prompt = ""
 
 		// Start with recent typing context

src/services/ghost/strategies/BasePromptStrategy.ts

@@ -85,15 +85,7 @@ EXAMPLE:
 	/**
 	 * Generates the user prompt with context
 	 */
-	getUserPrompt(context: GhostSuggestionContext): string {
-		return this.buildUserPrompt(context)
-	}
-
-	/**
-	 * Builds the user prompt from the relevant context
-	 * Must be implemented by each strategy
-	 */
-	protected abstract buildUserPrompt(context: GhostSuggestionContext): string
+	abstract getUserPrompt(context: GhostSuggestionContext): string
 
 	/**
 	 * Adds the cursor marker to the document text at the specified position

src/services/ghost/strategies/CommentDrivenStrategy.ts

@@ -65,7 +65,7 @@ export class CommentDrivenStrategy extends BasePromptStrategy {
 - When using search/replace format, include ALL existing code to preserve it`
 	}
 
-	protected buildUserPrompt(context: Partial<GhostSuggestionContext>): string {
+	getUserPrompt(context: GhostSuggestionContext): string {
 		if (!context.document || !context.range) {
 			return "No context available for comment-driven generation."
 		}

src/services/ghost/strategies/InlineCompletionStrategy.ts

@@ -65,7 +65,7 @@ export class InlineCompletionStrategy extends BasePromptStrategy {
 - Match the existing code style`
 	}
 
-	protected buildUserPrompt(context: Partial<GhostSuggestionContext>): string {
+	getUserPrompt(context: GhostSuggestionContext): string {
 		if (!context.document || !context.range) {
 			return "No context available for inline completion."
 		}

src/services/ghost/strategies/NewLineCompletionStrategy.ts

@@ -64,7 +64,7 @@ Important:
 	/**
 	 * Build prompt focused on surrounding context
 	 */
-	protected buildUserPrompt(context: Partial<GhostSuggestionContext>): string {
+	getUserPrompt(context: GhostSuggestionContext): string {
 		let prompt = ""
 
 		// Start with cursor context

src/services/ghost/strategies/SelectionRefactorStrategy.ts

@@ -46,7 +46,7 @@ export class SelectionRefactorStrategy extends BasePromptStrategy {
 Remember: The goal is to improve the code quality while keeping the exact same behavior.`
 	}
 
-	protected buildUserPrompt(context: Partial<GhostSuggestionContext>): string {
+	getUserPrompt(context: GhostSuggestionContext): string {
 		if (!context.document || !context.range) {
 			return "No selection available for refactoring."
 		}

src/services/ghost/strategies/UserRequestStrategy.ts

@@ -53,7 +53,7 @@ Common Request Patterns:
 	/**
 	 * Build the user prompt with all relevant context
 	 */
-	protected buildUserPrompt(context: Partial<GhostSuggestionContext>): string {
+	getUserPrompt(context: GhostSuggestionContext): string {
 		let prompt = ""
 
 		// User request is the most important part
@@ -123,23 +123,6 @@ Common Request Patterns:
 		return prompt
 	}
 
-	/**
-	 * Override to provide more context for certain types of requests
-	 */
-	override getUserPrompt(context: GhostSuggestionContext): string {
-		// For certain requests, we might want to include more context
-		const request = context.userInput?.toLowerCase() || ""
-
-		// If the request mentions other files or imports, include more context
-		if (request.includes("import") || request.includes("from")) {
-			// Could potentially include information about available modules
-			// For now, we'll use the standard approach
-		}
-
-		// Use the standard prompt building
-		return super.getUserPrompt(context)
-	}
-
 	/**
 	 * Gets the file path from the document
 	 */