allow ! when input is non-empty

Author: iscekic

cli/src/state/atoms/__tests__/shell.test.ts

@@ -444,6 +444,31 @@ describe("shell mode - comprehensive tests", () => {
 			expect(store.get(shellModeActiveAtom)).toBe(false)
 			expect(store.get(inputModeAtom)).toBe("normal")
 		})
+
+		it("should insert '!' when Shift+1 is pressed with text in input", async () => {
+			const shift1Key: Key = {
+				name: "shift-1",
+				sequence: "!",
+				ctrl: false,
+				meta: false,
+				shift: true,
+				paste: false,
+			}
+
+			// Add text to input
+			store.set(setTextAtom, "some command")
+			expect(store.get(textBufferStringAtom)).toBe("some command")
+
+			// Press Shift+1
+			await store.set(keyboardHandlerAtom, shift1Key)
+
+			// Should NOT activate shell mode
+			expect(store.get(shellModeActiveAtom)).toBe(false)
+			expect(store.get(inputModeAtom)).toBe("normal")
+
+			// Should insert "!" into the text
+			expect(store.get(textBufferStringAtom)).toBe("some command!")
+		})
 	})
 
 	describe("edge cases", () => {

cli/src/state/atoms/keyboard.ts

@@ -811,10 +811,17 @@ function handleGlobalHotkeys(get: any, set: any, key: Key): boolean {
 				return true
 			}
 			break
-		case "shift-1":
-			// Toggle shell mode with Shift+1 or Shift+!
-			set(toggleShellModeAtom)
-			return true
+		case "shift-1": {
+			// Toggle shell mode with Shift+1 or Shift+! only if input is empty
+			const isEmpty = get(textBufferIsEmptyAtom)
+			if (isEmpty) {
+				// Input is empty, toggle shell mode
+				set(toggleShellModeAtom)
+				return true
+			}
+			// Input has text, don't consume the key - let it be inserted as "!"
+			return false
+		}
 	}
 	return false
 }