Avoid type system duplication #710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
Collaborator
I think this is a good idea if it works. We should probably try to go straight to Roo indeed. |
11 tasks
Contributor
Author
Contributor
Author
|
Merged in roo, so merging here is just going to make the next merge less conflict-heavy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
keeping all those keys in sync is annoying, a bunch of busiwork when implementing and reviewing, and slightly increases the chance of merge conflicts - and useless, since
zodby design has a runtime representation of the types; in these cases we don't need to duplicate that..Implementation
Just use TS+zod features to ensure the keys-of lists are correct.
main:
this branch:
main:
this branch:
If we think this is a good idea, I think I should try and contribute this to roo: DRAFT because I want to try that first if we approve.
....so, is it a good idea?