Skip to content

Commit 95f38e5

Browse files
cad(enclosure): fix bottom enclosure errata (v2)
* standoffs were in the way * cam interface too short
1 parent 5b92c1d commit 95f38e5

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

cad/column_rod_enclosure.py

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ class Spec:
9191
enclosure_wall_thickness_bottom: float = 2
9292
enclosure_wall_thickness_top: float = 2
9393
enclosure_bottom_wall_standoff_height: float = 4.0 # Avoid THT solder points, nuts.
94-
enclosure_bottom_wall_standoff_od: float = 6
94+
enclosure_bottom_wall_standoff_od: float = 9.0
9595

9696
# Bolts for joining the top/bottom halves of the enclosure securely.
9797
joiner_bolt_d: float = 3 # M3.
@@ -344,8 +344,14 @@ def make_enclosure_bottom(spec: Spec) -> bd.Part | bd.Compound:
344344
)
345345

346346
# Add the stand offs from the bottom wall.
347-
for x_val, y_val in spec.get_pcb_raiser_screw_coordinates():
348-
p += bd.Pos(x_val, y_val, spec.enclosure_wall_thickness_bottom) * bd.Cylinder(
347+
# Used to be at the `spec.get_pcb_raiser_screw_coordinates()` locations, but place
348+
# at the corners now.
349+
for x_sign, y_sign in product((1, -1), (1, -1)):
350+
p += bd.Pos(
351+
x_sign * spec.pcb_length_x / 2,
352+
y_sign * spec.pcb_length_y / 2,
353+
spec.enclosure_wall_thickness_bottom,
354+
) * bd.Cylinder(
349355
radius=spec.enclosure_bottom_wall_standoff_od / 2,
350356
height=spec.enclosure_bottom_wall_standoff_height,
351357
align=bde.align.ANCHOR_BOTTOM,
@@ -367,7 +373,7 @@ def make_enclosure_bottom(spec: Spec) -> bd.Part | bd.Compound:
367373
spec.enclosure_bottom_wall_standoff_height
368374
+ spec.pcb_thickness
369375
+ spec.cam_motor_od / 2
370-
- spec.cam_max_od / 2 # TODO(KS): Not sure what to pick. Min or max for sure.
376+
- spec.cam_min_od / 2 # Min: you need max engagement so it can push against.
371377
)
372378
for x_sign, y_sign in product((1, -1), (1, -1)):
373379
p += bd.Pos(

0 commit comments

Comments
 (0)