Adding ts-pc branch to master?

[Potajito]

Hi!
I've been using the ts-pc branch for a while in arch, but I want to move to bazzite, which includes this driver, but not the ts-pc branch. Is there anything preventing it to become stable enough? So far on my end there have been no issues. Also, could we do anything to help it get the stable treatment?

Thanks again for the amazing work on this project!

[Kimplul]

Hi, the main reason I've kept it in a separate branch is because the patches in use were allegedly drafts, and I've been waiting for what else might show up, as hinted to here. The code itself is fairly straightforward for the most part, so if there really aren't any functional issues (in the base mode at least) I'm not opposed to merging into main and fixing the remaining bits later.

At least from my perspective the most significant lacking feature is the mode switching, which is kind of there but could use some fixups. The advanced mode is currently indistinguishable from a T248 so to get back to the base mode you presumably have to unplug the wheel, which I don't love. Fixing that would require asking the wheel at runtime what it thinks it is, this affects other wheels as well so it was kind of started over in #143 (comment) but that's also gone a bit inactive recently.

Apparently there might be more issues as well, based on

Maybe i will have time this evening to dig in the source and try to find remaining problems but this is promising, thanks Kimplul

but not really sure what or if they only apply to the advanced mode.

[Potajito]

Thanks for the answer! Also, another thing that I believe is still needed and is not very user friendly is tmdrv init for this wheel. I think I still need to use my fork (https://gitlab.com/potajito/tmdrv) for it to work, but I don't know if there has been any changes on that regard, or if there are planned to.
About the advanced mode, sadly I don't have a supported wheel for that, so I can't test that one.

[Kimplul]

Oh, really? Interesting, I thought the provided tminit patches worked. I asked about them in #65 (comment) and nobody piped up to say that they didn't work. Could you double check?

[Potajito]

ahh my bad for spreading missinformation, yeah, it's not needed anymore, just checked. I was just so used to run it that didn't try without it!

[jmta]

I've just recently switched to Bazzite and keen to get my TS-PC working as well. It sound like this is probably in a good state from the comments above for a basic first integration, noting the mode switching being experimental, and once in main can hopefully get a bit more feedback of any lingering bugs. Happy to help if there is any donkey working needing doing here.

[Kimplul]

I rebased the tspc branch to be on top of the current master, there were some merge conflicts so please check that everything still works (I don't see why it wouldn't but best to be sure) and then I'll merge into master.

[jmta]

Unfortunately it doesn't look like Bazzite is likely to play nicely with side loaded drivers. @Potajito are you still in a place you can test on Arch?

[Potajito]

im full time on bazzite now, but I still have my arch install where I test this kind if stuff, so I'll give it a proper spin this week.

[Potajito]

Hi!
I've been testing this for about a week or so, so far, no issues at all, the only thing worth mentioning is that in Assetto Corsa Competizione, what was previously being detected as 'TS-PC FFB' (or something along the lines) was now being picked as my mouse device, but just in name. The input and FFB were fine, no issues at all.
This has probably nothing to do with the driver, but maybe has something to do with me having to force the proton version from default (which afaik was proton 10) to 9 because the game wasn't launching, and probably the prefix stuff got messed up.
Rest of the games that I tried (Dirt 2, Automobilista 2, carx drift) didn't have that (or any) issue.

[Kimplul]

Thanks! I went ahead and merged, so the TS-PC is now 'officially' supported. Since I don't have one myself, I would really appreciate it if you follow this repo for issues related to the TS-PC and help out if possible.

[Potajito]

Thanks! I went ahead and merged, so the TS-PC is now 'officially' supported. Since I don't have one myself, I would really appreciate it if you follow this repo for issues related to the TS-PC and help out if possible.

Sure, I'm not going anywhere! Thanks for all your work!